From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9871DA5E; Thu, 12 Sep 2024 05:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726117609; cv=none; b=tKrWkE/7SwXsIOtEeAEZWZ9ZHfuxtnxAhUPsaI62h4NCVaEEb8CaqTQ+R+KE1jwm0OiFsX0tvLWOE4Etj3ZherkOSi7aiE+ocirtykqRAQVb6irHIuUxqor7U/BndocubIRSc7fJvV8iMAMtPTquBYQw8Rv1u9TGxPyO3znpMLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726117609; c=relaxed/simple; bh=PSBPRfpXCTFazNXYG5W2cn6TzhVgjMf+nyJ5Kwf2BV0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IbANjSvsNwkO97h1hs8ygexHTlXBWXjNwTmb3mIh+wCJBPtfiuC2AXIw7VNhjTM81cx+A1r//uoR3xXnTl0DCPqZx963jmBe+5YUL0Vk/A+nIu1fEmelS+2BXz060TBcwDbppwuq6YOxvxhgL1cJLY5tsUOV3hs9cjkDjt+ttAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=a7opEU62; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="a7opEU62" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E54B9C4CEC3; Thu, 12 Sep 2024 05:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726117609; bh=PSBPRfpXCTFazNXYG5W2cn6TzhVgjMf+nyJ5Kwf2BV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a7opEU627fSf6p/Dp4wCT3UqZKD4Oqa97nQxj+sRqTmijf2HMv2X5fTBy7Hqh0tiX XF5+cEV34zubsNMI2Z7JyQwhUOZu0kz18YlT9t4oKhARbP+otA6ZoPXmk868EwFxST vjnYXbvwGawdYUgDuxDr/WXOhliIvzu4ow8GQHEM= Date: Thu, 12 Sep 2024 07:06:45 +0200 From: Greg KH To: Abhishek Tamboli Cc: Alan Stern , usb-storage@lists.one-eyed-alien.net, linux-usb@vger.kernel.org, skhan@linuxfoundation.org, dan.carpenter@linaro.org, rbmarliere@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings Message-ID: <2024091228-bootie-name-4867@gregkh> References: <20240729182348.451436-1-abhishektamboli9@gmail.com> <5d7870b0-6b63-430b-8885-2509b33dc78a@suse.com> <804a6d40-73a4-4af6-944b-95e9324d7429@rowland.harvard.edu> <890e0ed1-25c3-414e-9e8e-f5925fe8c778@rowland.harvard.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 12, 2024 at 06:15:18AM +0530, Abhishek Tamboli wrote: > Hi Alan, > On Thu, Aug 01, 2024 at 10:51:35AM -0400, Alan Stern wrote: > > On Thu, Aug 01, 2024 at 08:54:18AM +0200, 'Oliver Neukum' via USB Mass Storage on Linux wrote: > > > > > > > > > On 31.07.24 20:19, Alan Stern wrote: > > > > On Wed, Jul 31, 2024 at 11:34:45PM +0530, Abhishek Tamboli wrote: > > > > > On Wed, Jul 31, 2024 at 10:04:33AM -0400, Alan Stern wrote: > > > > > > Hi, > > > > > > I should make my reasoning clearer. > > > > > > > > > Replacing the variable with a constant won't make much difference. The > > > > > > compiler will realize that bl_len has a constant value and will generate > > > > > > appropriate code anyway. I think just changing the type is a fine fix. > > > > > > While that is absolutely true, it kind of removes the reason for the patch > > > in the first place. The code gcc generates is unlikely to be changed. > > > > > > We are reacting to a warning an automatic tool generates. That is a good thing. > > > We should have clean code. The question is how we react to such a report. > > > It just seems to me that if we fix such a warning, the code should really be clean > > > after that. Just doing the minimum that will make the checker shut up is > > > no good. > > > > With this fix, the code seems clean to me. It may not be as short as > > possible, but it's clean. > > I noticed that the patch has not yet been pulled into linux-next, > even though it has been acked-by you for over a month. Is there > anything else I need to do on my end? Yes, please resend it, it is long gone from my review queue, sorry. thanks, greg k-h