From: warp5tw@gmail.com
To: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, andi.shyti@kernel.org,
andriy.shevchenko@linux.intel.com, wsa@kernel.org,
rand.sec96@gmail.com, wsa+renesas@sang-engineering.com,
warp5tw@gmail.com, tali.perry@nuvoton.com,
Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com
Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/6] i2c: npcm: Bug fixes read/write operation, checkpatch
Date: Fri, 13 Sep 2024 18:14:40 +0800 [thread overview]
Message-ID: <20240913101445.16513-1-kfting@nuvoton.com> (raw)
From: Tyrone Ting <kfting@nuvoton.com>
This patchset includes the following fixes:
- Enable the target functionality in the interrupt handling routine
when the i2c transfer is about to finish.
- Correct the read/write operation procedure.
- Introduce a software flag to handle the bus error (BER) condition
which is not caused by the i2c transfer.
- Modify timeout calculation.
- Assign the client address earlier logically.
- Use an i2c frequency table for the frequency parameters assignment.
- Coding style fix.
The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.
Addressed comments from:
- Andi Shyti : https://lore.kernel.org/lkml/
cfdfldh5tuhb4r5pdpgolcr2roeewsobedet2uvmpbnqlw5yh4@c4a2szsbs2r2/
- Andi Shyti : https://lore.kernel.org/lkml/
stnyjmnqdobzq2f2ntq32tu4kq6ohsxyevjn5rgz3uu2qncuzl@nt4ifscgokgj/
- Andy Shevchenko : https://lore.kernel.org/lkml/ZtWnd8bmiu-M4fQg
@smile.fi.intel.com/
- Andy Shevchenko : https://lore.kernel.org/lkml/Zt7Nn9uJSeHFUZZF
@smile.fi.intel.com/
- Andi Shyti : https://lore.kernel.org/lkml/
2kqhf2ad3omx3dsjucrqhtnonnox7ghtp7vkogrwrdfh3dgg2o@4cpa4gfg6c3f/
Changes since version 2:
- Add more explanations in the commit message and code modification.
- Use lower character names for declarations.
- Remove Fixes tags in commits which are not to fix bugs.
Changes since version 1:
- Restore the npcm_i2caddr array length to fix the smatch warning.
- Remove unused variables.
- Handle the condition where scl_table_cnt reaches to the maximum value.
- Fix the checkpatch warning.
Charles Boyer (1):
i2c: npcm: Enable slave in eob interrupt
Tyrone Ting (5):
i2c: npcm: correct the read/write operation procedure
i2c: npcm: use a software flag to indicate a BER condition
i2c: npcm: Modify timeout evaluation mechanism
i2c: npcm: Modify the client address assignment
i2c: npcm: use i2c frequency table
drivers/i2c/busses/i2c-npcm7xx.c | 281 ++++++++++++++++++++-----------
1 file changed, 179 insertions(+), 102 deletions(-)
base-commit: 48b83f5f68edb4d19771d5ecc54bbbc37166f753
--
2.34.1
next reply other threads:[~2024-09-13 10:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 10:14 warp5tw [this message]
2024-09-13 10:14 ` [PATCH v3 1/6] i2c: npcm: correct the read/write operation procedure warp5tw
2024-09-13 10:14 ` [PATCH v3 2/6] i2c: npcm: use a software flag to indicate a BER condition warp5tw
2024-09-13 10:14 ` [PATCH v3 3/6] i2c: npcm: Modify timeout evaluation mechanism warp5tw
2024-09-13 10:14 ` [PATCH v3 4/6] i2c: npcm: Modify the client address assignment warp5tw
2024-09-13 10:32 ` Andy Shevchenko
2024-09-16 1:37 ` Tyrone Ting
2024-09-13 10:14 ` [PATCH v3 5/6] i2c: npcm: use i2c frequency table warp5tw
2024-09-13 10:39 ` Andy Shevchenko
2024-09-16 1:39 ` Tyrone Ting
2024-09-13 10:30 ` [PATCH v3 0/6] i2c: npcm: Bug fixes read/write operation, checkpatch Andy Shevchenko
2024-09-16 1:37 ` Tyrone Ting
2024-09-13 10:31 ` Andy Shevchenko
2024-09-16 1:35 ` Tyrone Ting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913101445.16513-1-kfting@nuvoton.com \
--to=warp5tw@gmail.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=kfting@nuvoton.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rand.sec96@gmail.com \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox