The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abhishek Tamboli <abhishektamboli9@gmail.com>
Cc: skhan@linuxfoundation.org, rbmarliere@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: octeon: Use new initialization api for tasklet
Date: Sat, 14 Sep 2024 10:20:02 +0200	[thread overview]
Message-ID: <2024091424-glisten-unmanned-bb8f@gregkh> (raw)
In-Reply-To: <20240913191734.805815-1-abhishektamboli9@gmail.com>

On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote:
> Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
> introduced in commit 12cc923f1ccc ("tasklet: Introduce new
> initialization API").

This says what you are doing, but not why you are doing this.

Why is this needed?  What bug does this fix?  The code is the exact same
afterward so why should this be accepted?

thanks,

greg k-h

  reply	other threads:[~2024-09-14  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 19:17 [PATCH v2] staging: octeon: Use new initialization api for tasklet Abhishek Tamboli
2024-09-14  8:20 ` Greg KH [this message]
2024-09-14 16:44   ` Abhishek Tamboli
2024-09-14 16:51     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024091424-glisten-unmanned-bb8f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=abhishektamboli9@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rbmarliere@gmail.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox