public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Vinod Koul <vkoul@kernel.org>, Nishad Saraf <nishads@amd.com>,
	Lizhi Hou <lizhi.hou@amd.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Please revert the addition of the AMD QDMA driver
Date: Mon, 16 Sep 2024 09:40:51 +0200	[thread overview]
Message-ID: <20240916074051.GA18902@lst.de> (raw)

Hi Vinod,

I just noticed you added the AMD QDMA driver for this merge window,
which is completely broken in terms of DMA API usage by using the
private get/set_dma_ops APIs.  These were never for driver use (
and I've been working for years to fix the few abusers), but with the
DMA changes in 6.12 it actually can't work at all, as the dma-iommu
driver now also sets NULL DMA ops in addition to dma-direct.

As a reminder drivers must never try to inherit dma settings from
one device or another, instead pass the actual DMA device to whatever
layer does the DMA mapping.  Without that you break all kinds of
thing.

             reply	other threads:[~2024-09-16  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  7:40 Christoph Hellwig [this message]
2024-09-16 23:48 ` Please revert the addition of the AMD QDMA driver Lizhi Hou
2024-09-17  4:39   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916074051.GA18902@lst.de \
    --to=hch@lst.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=nishads@amd.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox