From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Matt Wu <wuqiang.matt@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 09/19] lib: test_objpool: Use kthread_run_on_cpu()
Date: Tue, 17 Sep 2024 00:49:13 +0200 [thread overview]
Message-ID: <20240916224925.20540-10-frederic@kernel.org> (raw)
In-Reply-To: <20240916224925.20540-1-frederic@kernel.org>
Use the proper API instead of open coding it.
Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
lib/test_objpool.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/lib/test_objpool.c b/lib/test_objpool.c
index bfdb81599832..2c09dd91e731 100644
--- a/lib/test_objpool.c
+++ b/lib/test_objpool.c
@@ -371,14 +371,10 @@ static int ot_start_sync(struct ot_test *test)
if (!cpu_online(cpu))
continue;
- work = kthread_create_on_node(ot_thread_worker, item,
- cpu_to_node(cpu), "ot_worker_%d", cpu);
- if (IS_ERR(work)) {
+ work = kthread_run_on_cpu(ot_thread_worker, item,
+ cpu, "ot_worker_%d");
+ if (IS_ERR(work))
pr_err("failed to create thread for cpu %d\n", cpu);
- } else {
- kthread_bind(work, cpu);
- wake_up_process(work);
- }
}
/* wait a while to make sure all threads waiting at start line */
@@ -562,14 +558,9 @@ static int ot_start_async(struct ot_test *test)
if (!cpu_online(cpu))
continue;
- work = kthread_create_on_node(ot_thread_worker, item,
- cpu_to_node(cpu), "ot_worker_%d", cpu);
- if (IS_ERR(work)) {
+ work = kthread_run_on_cpu(ot_thread_worker, item, cpu, "ot_worker_%d");
+ if (IS_ERR(work))
pr_err("failed to create thread for cpu %d\n", cpu);
- } else {
- kthread_bind(work, cpu);
- wake_up_process(work);
- }
}
/* wait a while to make sure all threads waiting at start line */
--
2.46.0
next prev parent reply other threads:[~2024-09-16 22:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 22:49 [PATCH 00/19] kthread: Introduce preferred affinity v3 Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 01/19] arm/bL_switcher: Use kthread_run_on_cpu() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 02/19] x86/resctrl: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 03/19] firmware: stratix10-svc: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 04/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 05/19] scsi: bnx2i: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 06/19] scsi: qedi: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 07/19] soc/qman: test: Use kthread_run_on_cpu() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 08/19] kallsyms: " Frederic Weisbecker
2024-09-16 22:49 ` Frederic Weisbecker [this message]
2024-09-16 22:49 ` [PATCH 10/19] net: pktgen: Use kthread_create_on_node() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 11/19] kthread: Make sure kthread hasn't started while binding it Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-09-17 6:26 ` Michal Hocko
2024-09-17 7:01 ` Vlastimil Babka
2024-09-17 7:05 ` Michal Hocko
2024-09-17 7:14 ` Vlastimil Babka
2024-09-17 10:34 ` Frederic Weisbecker
2024-09-17 11:07 ` Michal Hocko
2024-09-18 9:37 ` Frederic Weisbecker
2024-09-18 11:17 ` Michal Hocko
2024-09-16 22:49 ` [PATCH 13/19] mm: Create/affine kcompactd to its preferred node Frederic Weisbecker
2024-09-17 6:04 ` Michal Hocko
2024-09-16 22:49 ` [PATCH 14/19] mm: Create/affine kswapd " Frederic Weisbecker
2024-09-17 6:05 ` Michal Hocko
2024-09-16 22:49 ` [PATCH 15/19] kthread: Implement preferred affinity Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 16/19] rcu: Use kthread preferred affinity for RCU boost Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 17/19] kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 18/19] treewide: Introduce kthread_run_worker[_on_cpu]() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 19/19] rcu: Use kthread preferred affinity for RCU exp kworkers Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2024-08-07 16:02 [PATCH 00/19] kthread: Introduce preferred affinity v2 Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 09/19] lib: test_objpool: Use kthread_run_on_cpu() Frederic Weisbecker
2024-08-14 2:53 ` wuqiang.matt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916224925.20540-10-frederic@kernel.org \
--to=frederic@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox