Re: [PATCHv4 02/14] uprobe: Add support for session consumer

Oleg Nesterov
2024-09-23T12:13:50Z

On 09/23, Jiri Olsa wrote:
>
> On Mon, Sep 23, 2024 at 12:05:53PM +0200, Oleg Nesterov wrote:
> > On 09/23, Jiri Olsa wrote:
> > >
> > > change below should do what you proposed originally
> >
> > LGTM, just one nit below.
> >
> > But I guess you need to do this on top of bpf/bpf.git, Andrii has already
> > applied your series.
>
> that seems confusing

Yes ;)

> but looks like just that one fix with the
> commit link in [1] was applied

Ah, OK.

> > And to remind, 02/14 must be fixed in any case unless I am totally confused,
> > handler_chain() can leak return_instance.
>
> yep it was missing kfree, but it's not needed in this new version

Yes, yes, the new version looks fine to me.

Oleg.