* [PATCH] nvmet: Fix warnings given by checkpatch
@ 2024-09-18 8:11 Rohit Chavan
2024-09-18 12:03 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Rohit Chavan @ 2024-09-18 8:11 UTC (permalink / raw)
To: Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni, linux-nvme,
linux-kernel
Cc: Rohit Chavan
This patch addresses below issues produced by checkpatch script.
ERROR: space required before the open brace '{'
drivers/nvme/target/debugfs.h:25
WARNING: please, no spaces at the start of a line
drivers/nvme/target/debugfs.h:35
Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
---
drivers/nvme/target/debugfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/target/debugfs.h b/drivers/nvme/target/debugfs.h
index cfb8bbf6a297..166de8c7fc49 100644
--- a/drivers/nvme/target/debugfs.h
+++ b/drivers/nvme/target/debugfs.h
@@ -22,7 +22,7 @@ static inline int nvmet_debugfs_subsys_setup(struct nvmet_subsys *subsys)
{
return 0;
}
-static inline void nvmet_debugfs_subsys_free(struct nvmet_subsys *subsys){}
+static inline void nvmet_debugfs_subsys_free(struct nvmet_subsys *subsys) {}
static inline int nvmet_debugfs_ctrl_setup(struct nvmet_ctrl *ctrl)
{
@@ -32,7 +32,7 @@ static inline void nvmet_debugfs_ctrl_free(struct nvmet_ctrl *ctrl) {}
static inline int __init nvmet_init_debugfs(void)
{
- return 0;
+ return 0;
}
static inline void nvmet_exit_debugfs(void) {}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmet: Fix warnings given by checkpatch
2024-09-18 8:11 [PATCH] nvmet: Fix warnings given by checkpatch Rohit Chavan
@ 2024-09-18 12:03 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2024-09-18 12:03 UTC (permalink / raw)
To: Rohit Chavan
Cc: Christoph Hellwig, Sagi Grimberg, Chaitanya Kulkarni, linux-nvme,
linux-kernel
Please don't waste peoples time by sending checkpatch cleanups.
Good coding style is nice to have, but unless you do actualy substantial
work in the area that has issues it's just churn that creates work.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-18 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 8:11 [PATCH] nvmet: Fix warnings given by checkpatch Rohit Chavan
2024-09-18 12:03 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox