From: Mohammed Anees <pvmohammedanees2003@gmail.com>
To: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Mohammed Anees <pvmohammedanees2003@gmail.com>,
syzbot+18a87160c7d64ba2e2f6@syzkaller.appspotmail.com
Subject: [PATCH 2/2] osfs2: Fix kernel BUG in ocfs2_write_cluster
Date: Wed, 18 Sep 2024 17:20:26 +0000 [thread overview]
Message-ID: <20240918172026.2532-3-pvmohammedanees2003@gmail.com> (raw)
In-Reply-To: <20240918172026.2532-1-pvmohammedanees2003@gmail.com>
syzbot has found a kernel BUG in ocfs2_write_cluster_by_desc [1].
The issue arises because ocfs2_insert_extent receives start_blk
as 0, which incorrectly maps to a physical address of 0. This
occurs when block is 0 after the call to ocfs2_clusters_to_blocks
which is invoked inside the ocfs2_add_clusters_in_btree. The block
value is then passed to ocfs2_insert_extent, leading to the problem.
[1] https://syzkaller.appspot.com/bug?extid=18a87160c7d64ba2e2f6
Reported-and-tested-by: syzbot+18a87160c7d64ba2e2f6@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=18a87160c7d64ba2e2f6
Signed-off-by: Mohammed Anees <pvmohammedanees2003@gmail.com>
---
fs/ocfs2/alloc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index 395e23920..926ffeed8 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -4843,6 +4843,13 @@ int ocfs2_add_clusters_in_btree(handle_t *handle,
}
block = ocfs2_clusters_to_blocks(osb->sb, bit_off);
+ if (block == 0) {
+ mlog(ML_ERROR, "Conversion resulted in zero block number");
+ status = -EIO;
+ need_free = 1;
+ goto bail;
+ }
+
trace_ocfs2_add_clusters_in_btree(
(unsigned long long)ocfs2_metadata_cache_owner(et->et_ci),
bit_off, num_bits);
--
2.46.0
next prev parent reply other threads:[~2024-09-18 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 17:20 [PATCH 0/2] ocfs2: Fix deadlock in extent_map and handle zero Mohammed Anees
2024-09-18 17:20 ` [PATCH 1/2] ocfs2: Fix deadlock in ocfs2_read_virt_blocks Mohammed Anees
2024-09-19 8:13 ` heming.zhao
2024-09-21 14:22 ` Mohammed Anees
2024-09-18 17:20 ` Mohammed Anees [this message]
2024-09-19 7:44 ` [PATCH 2/2] osfs2: Fix kernel BUG in ocfs2_write_cluster heming.zhao
2024-09-21 17:30 ` Mohammed Anees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918172026.2532-3-pvmohammedanees2003@gmail.com \
--to=pvmohammedanees2003@gmail.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=syzbot+18a87160c7d64ba2e2f6@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox