Re: [PATCH 5/5] arm64: dts: imx8qm: enable dsp node for rproc usage

Laurentiu Mihalcea
2024-09-22T23:16:05Z

On 9/18/2024 10:00 PM, Frank Li wrote:
> On Wed, Sep 18, 2024 at 02:21:17PM -0400, Laurentiu Mihalcea wrote:
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>
>> Set the status of the dsp node to "okay" and assign
>> its reserved memory regions.
> wrap at 75 chars.
>
> Add dsp node and related reserved memory regions.
>
> Frank
>
>> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 27 ++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
>> index 62203eed6a6c..7ee69ce7b193 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
>> @@ -92,6 +92,27 @@ vdevbuffer: memory@90400000 {
>> reg = <0 0x90400000 0 0x100000>;
>> no-map;
>> };
>> +
>> + dsp_reserved: dsp@92400000 {
>> + reg = <0 0x92400000 0 0x1000000>;
>> + no-map;
>> + };
>> +
>> + dsp_vdev0vring0: vdev0vring0@942f0000 {
> 'vdev0vring0' should be genernal name, such as 'memory'

Driver expects reserved memory node names to have a certain format.
If possible and if too problematic I'd rather have this fixed in a separate patch series.

>
>> + reg = <0 0x942f0000 0 0x8000>;
>> + no-map;
>> + };
>> +
>> + dsp_vdev0vring1: vdev0vring1@942f8000 {
>> + reg = <0 0x942f8000 0 0x8000>;
>> + no-map;
>> + };
>> +
>> + dsp_vdev0buffer: vdev0buffer@94300000 {
>> + compatible = "shared-dma-pool";
>> + reg = <0 0x94300000 0 0x100000>;
>> + no-map;
>> + };
>> };
>>
>> lvds_backlight0: backlight-lvds0 {
>> @@ -640,6 +661,12 @@ &sai7 {
>> status = "okay";
>> };
>>
>> +&vpu_dsp {
>> + memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>,
>> + <&dsp_vdev0vring1>, <&dsp_reserved>;
>> + status = "okay";
>> +};
>> +
>> &iomuxc {
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_hog>;
>> --
>> 2.34.1
>>