Re: [PATCH 4/5] arm64: dts: imx8qm: add node for VPU dsp

Frank Li
2024-09-18T18:57:26Z

On Wed, Sep 18, 2024 at 02:21:16PM -0400, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Add DT node for i.MX8QM's DSP, which is found in
> the VPU subsystem.
>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 27 +++++++++++++++++++++++

why not add a file imx8qm-ss-vpu.dtsi to keep consistent with others.

Frank

> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> index f8b577ebdbef..ae0165a44dcd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> @@ -581,6 +581,33 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll {
> clock-output-names = "mipi_pll_div2_clk";
> };
>
> + vpu_subsys_dsp: bus@55000000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x55000000 0x0 0x55000000 0x1000000>;
> +
> + vpu_dsp: dsp@556e8000 {
> + compatible = "fsl,imx8qm-hifi4";
> + reg = <0x556e8000 0x88000>;
> + clocks = <&clk_dummy>,
> + <&clk_dummy>,
> + <&clk_dummy>;
> + clock-names = "ipg", "ocram", "core";
> + power-domains = <&pd IMX_SC_R_MU_13B>,
> + <&pd IMX_SC_R_DSP>,
> + <&pd IMX_SC_R_DSP_RAM>,
> + <&pd IMX_SC_R_IRQSTR_DSP>,
> + <&pd IMX_SC_R_MU_2A>;
> + mbox-names = "tx", "rx", "rxdb";
> + mboxes = <&lsio_mu13 0 0>,
> + <&lsio_mu13 1 0>,
> + <&lsio_mu13 3 0>;
> + firmware-name = "imx/dsp/hifi4.bin";
> + status = "disabled";
> + };
> + };
> +
> /* sorted in register address */
> #include "imx8-ss-cm41.dtsi"
> #include "imx8-ss-audio.dtsi"
> --
> 2.34.1
>