Re: [PATCH V5 4/5] bnxt_en: Add TPH support in BNXT driver

kernel test robot
2024-09-20T10:39:48Z

Hi Wei,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on next-20240920]
[cannot apply to pci/next pci/for-linus v6.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Wei-Huang/PCI-Add-TLP-Processing-Hints-TPH-support/20240917-045345
base: linus/master
patch link: https://lore.kernel.org/r/20240916205103.3882081-5-wei.huang2%40amd.com
patch subject: [PATCH V5 4/5] bnxt_en: Add TPH support in BNXT driver
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240920/202409201831.ToruGbMs-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240920/202409201831.ToruGbMs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409201831.ToruGbMs-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function '__bnxt_irq_affinity_notify':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:10873:35: warning: variable 'rxr' set but not used [-Wunused-but-set-variable]
10873 | struct bnxt_rx_ring_info *rxr;
| ^~~

vim +/rxr +10873 drivers/net/ethernet/broadcom/bnxt/bnxt.c

10869
10870 static void __bnxt_irq_affinity_notify(struct irq_affinity_notify *notify,
10871 const cpumask_t *mask)
10872 {
10873 struct bnxt_rx_ring_info *rxr;
10874 struct bnxt_irq *irq;
10875 u16 tag;
10876 int err;
10877
10878 irq = container_of(notify, struct bnxt_irq, affinity_notify);
10879 cpumask_copy(irq->cpu_mask, mask);
10880
10881 if (pcie_tph_get_cpu_st(irq->bp->pdev, TPH_MEM_TYPE_VM,
10882 cpumask_first(irq->cpu_mask), &tag))
10883 return;
10884
10885 if (pcie_tph_set_st_entry(irq->bp->pdev, irq->msix_nr, tag))
10886 return;
10887
10888 if (netif_running(irq->bp->dev)) {
10889 rxr = &irq->bp->rx_ring[irq->ring_nr];
10890 rtnl_lock();
10891 err = netdev_rx_queue_restart(irq->bp->dev, irq->ring_nr);
10892 if (err)
10893 netdev_err(irq->bp->dev,
10894 "rx queue restart failed: err=%d\n", err);
10895 rtnl_unlock();
10896 }
10897 }
10898

--
0-DAY CI Kernel Test Service