* [PATCH v2 0/2] Add ES7243E ADC driver
@ 2024-09-20 15:41 Igor Prusov
2024-09-20 15:41 ` [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E Igor Prusov
2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov
0 siblings, 2 replies; 8+ messages in thread
From: Igor Prusov @ 2024-09-20 15:41 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Igor Prusov
Cc: linux-sound, linux-kernel, devicetree, kernel, prusovigor,
David Yang, Martin Kurbanov
This series adds Everest Semi ES7243E ADC driver and bindings.
Driver is based on David Yang's implementation [1].
[1] https://github.com/BPI-SINOVOIP/BPI-R2PRO-BSP/blob/main/kernel/sound/soc/codecs/es7243e.c
Changes in V2:
- use generic node name in bindings
- remove unused include statements
- add sclk and lrck clocks
- add const where possible
- Link to V1: https://lore.kernel.org/lkml/20240709104117.33431-1-ivprusov@salutedevices.com
---
Igor Prusov (2):
ASoC: dt-bindings: Add Everest ES7243E
ASoC: codecs: add ES7243E ADC driver
.../devicetree/bindings/sound/everest,es7243e.yaml | 56 ++
sound/soc/codecs/Kconfig | 4 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/es7243e.c | 693 +++++++++++++++++++++
4 files changed, 755 insertions(+)
---
base-commit: baeb9a7d8b60b021d907127509c44507539c15e5
change-id: 20240920-es7243e-adc-0e30d3c48bf6
Best regards,
--
Igor Prusov <ivprusov@salutedevices.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E 2024-09-20 15:41 [PATCH v2 0/2] Add ES7243E ADC driver Igor Prusov @ 2024-09-20 15:41 ` Igor Prusov 2024-09-24 12:31 ` Mark Brown 2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov 1 sibling, 1 reply; 8+ messages in thread From: Igor Prusov @ 2024-09-20 15:41 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Igor Prusov Cc: linux-sound, linux-kernel, devicetree, kernel, prusovigor Add dt-bindings for Everest Semi ES7243E ADC. Signed-off-by: Igor Prusov <ivprusov@salutedevices.com> --- .../devicetree/bindings/sound/everest,es7243e.yaml | 56 ++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/everest,es7243e.yaml b/Documentation/devicetree/bindings/sound/everest,es7243e.yaml new file mode 100644 index 0000000000000000000000000000000000000000..6afb467f389a70ad406a0fd953448b83b39ed858 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/everest,es7243e.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/everest,es7243e.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Everest ES7243E audio ADC + +maintainers: + - Igor Prusov <ivprusov@salutedevices.com> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + const: everest,es7243e + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + + clocks: + minItems: 2 + maxItems: 2 + + clock-names: + items: + - const: sclk + - const: lrclk + +required: + - compatible + - reg + - "#sound-dai-cells" + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + es7243e: audio-codec@14 { + compatible = "everest,es7243e"; + reg = <0x14>; + #sound-dai-cells = <0>; + clocks = <&clk_audio_sclk>, + <&clk_audio_lrclk>; + clock-names = "sclk", "lrclk"; + }; + }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E 2024-09-20 15:41 ` [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E Igor Prusov @ 2024-09-24 12:31 ` Mark Brown 0 siblings, 0 replies; 8+ messages in thread From: Mark Brown @ 2024-09-24 12:31 UTC (permalink / raw) To: Igor Prusov Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-sound, linux-kernel, devicetree, kernel, prusovigor [-- Attachment #1: Type: text/plain, Size: 797 bytes --] On Fri, Sep 20, 2024 at 06:41:07PM +0300, Igor Prusov wrote: > + clocks: > + minItems: 2 > + maxItems: 2 > + clock-names: > + items: > + - const: sclk > + - const: lrclk This is quite weird and doesn't seem to correspond to the chip datasheet at: http://www.everest-semi.com/pdf/ES7243%20PB.pdf https://www.pawpaw.cn/media/documents/2022-04/ES7243E_DS_pawpaw%E6%9C%A8%E7%93%9C%E7%A7%91%E6%8A%80.pdf The SCLK and LRCLK appear to be the bit and frame sync clocks which would not normally be exposed directly via the clock API (so this is probably not going to be joined up with whatever SoC it's connected to). On the other hand there *is* a MCLK which would much more normally be represented in the DT bindings and isn't represented here or managed by the driver. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver 2024-09-20 15:41 [PATCH v2 0/2] Add ES7243E ADC driver Igor Prusov 2024-09-20 15:41 ` [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E Igor Prusov @ 2024-09-20 15:41 ` Igor Prusov 2024-09-21 12:59 ` kernel test robot ` (3 more replies) 1 sibling, 4 replies; 8+ messages in thread From: Igor Prusov @ 2024-09-20 15:41 UTC (permalink / raw) To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Igor Prusov Cc: linux-sound, linux-kernel, devicetree, kernel, prusovigor, David Yang, Martin Kurbanov Add support for Everest Semi es7243e, which is a 24 bit, 8 to 48 kHz stereo audio ADC with I2C control and I2S output. Datasheet: https://www.pawpaw.cn/media/documents/2022-04/ES7243E_DS_pawpaw%E6%9C%A8%E7%93%9C%E7%A7%91%E6%8A%80.pdf Signed-off-by: David Yang <yangxiaohua@everest-semi.com> Signed-off-by: Viktor Prutyanov <vvprutyanov@sberdevices.ru> Signed-off-by: Igor Prusov <ivprusov@salutedevices.com> Signed-off-by: Martin Kurbanov <mmkurbanov@salutedevices.com> --- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/es7243e.c | 693 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 699 insertions(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 7092842480ef17d705920a6ac62a85158119352e..e4b34b61f10ed9e75673c85afbde500387658eab 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -117,6 +117,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_ES8328_I2C imply SND_SOC_ES7134 imply SND_SOC_ES7241 + imply SND_SOC_ES7243E imply SND_SOC_FRAMER imply SND_SOC_GTM601 imply SND_SOC_HDAC_HDMI @@ -1131,6 +1132,9 @@ config SND_SOC_ES7134 config SND_SOC_ES7241 tristate "Everest Semi ES7241 CODEC" +config SND_SOC_ES7243E + tristate "Everest Semi ES7243E CODEC" + config SND_SOC_ES83XX_DSM_COMMON depends on ACPI tristate diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile index 54cbc3feae3277ae29d6ea8fe891d4d17e5c9b17..fcf3cdd18aa6fa2a342ade8ccaacb22436fdd725 100644 --- a/sound/soc/codecs/Makefile +++ b/sound/soc/codecs/Makefile @@ -122,6 +122,7 @@ snd-soc-da9055-y := da9055.o snd-soc-dmic-y := dmic.o snd-soc-es7134-y := es7134.o snd-soc-es7241-y := es7241.o +snd-soc-es7243e-y := es7243e.o snd-soc-es83xx-dsm-common-y := es83xx-dsm-common.o snd-soc-es8311-y := es8311.o snd-soc-es8316-y := es8316.o @@ -529,6 +530,7 @@ obj-$(CONFIG_SND_SOC_DA9055) += snd-soc-da9055.o obj-$(CONFIG_SND_SOC_DMIC) += snd-soc-dmic.o obj-$(CONFIG_SND_SOC_ES7134) += snd-soc-es7134.o obj-$(CONFIG_SND_SOC_ES7241) += snd-soc-es7241.o +obj-$(CONFIG_SND_SOC_ES7243E) += snd-soc-es7243e.o obj-$(CONFIG_SND_SOC_ES83XX_DSM_COMMON) += snd-soc-es83xx-dsm-common.o obj-$(CONFIG_SND_SOC_ES8311) += snd-soc-es8311.o obj-$(CONFIG_SND_SOC_ES8316) += snd-soc-es8316.o diff --git a/sound/soc/codecs/es7243e.c b/sound/soc/codecs/es7243e.c new file mode 100644 index 0000000000000000000000000000000000000000..a33d5f0be16001975b23326c5960a866fdc55596 --- /dev/null +++ b/sound/soc/codecs/es7243e.c @@ -0,0 +1,693 @@ +// SPDX-License-Identifier: GPL-2.0-only +/** + * es7243e.c - ASoC Everest Semiconductor ES7243E audio ADC driver + * + * Copyright (c) 2024, SaluteDevices. All Rights Reserved. + * + * Authors: Viktor Prutyanov <vvprutyanov@sberdevices.ru> + * Igor Prusov <ivprusov@salutedevices.com> + * + * Based on ES7243E driver by David Yang <yangxiaohua@everest-semi.com> + */ + +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/i2c.h> +#include <linux/regmap.h> +#include <sound/core.h> +#include <sound/pcm.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> +#include <sound/tlv.h> + +#define ES7243E_RESET 0x00 +#define ES7243E_CLK1 0x01 +#define ES7243E_CLK1_ANA_ON BIT(1) +#define ES7243E_CLK1_ADC_ON BIT(3) +#define ES7243E_CLK2 0x02 +#define ES7243E_CLK2_BCLK_INV BIT(0) +#define ES7243E_ADC_OSR 0x03 +#define ES7243E_MCLK_PRE 0x04 +#define ES7243E_CF_DSP_DIV 0x05 +#define ES7243E_BCLK_DIV 0x06 +#define ES7243E_CLK7 0x07 +#define ES7243E_CLK7_LRCK_DIV_HI GENMASK(3, 0) +#define ES7243E_LRCK_DIV 0x08 +#define ES7243E_S1_SEL 0x09 +#define ES7243E_S3_SEL 0x0A +#define ES7243E_SDP 0x0B +#define ES7243E_SDP_MUTE GENMASK(7, 6) +#define ES7243E_SDP_LRP BIT(5) +#define ES7243E_SDP_WL GENMASK(4, 2) +#define ES7243E_SDP_FMT GENMASK(1, 0) +#define ES7243E_TDM 0x0B +#define ES7243E_ADCCTL1 0x0D +#define ES7243E_ADCCTL1_SCALE GENMASK(2, 0) +#define ES7243E_ADC_VOL 0x0E +#define ES7243E_ADCCTL2 0x0F +#define ES7243E_AUTOMUTE1 0x10 +#define ES7243E_AUTOMUTE2 0x11 +#define ES7243E_AUTOMUTE3 0x12 +#define ES7243E_AUTOMUTE4 0x13 +#define ES7243E_ADC_HPF1 0x14 +#define ES7243E_ADC_HPF2 0x15 +#define ES7243E_PDN 0x16 +#define ES7243E_PDN_ANA BIT(7) +#define ES7243E_PDN_BIAS BIT(6) +#define ES7243E_PDN_MOD1_RST BIT(5) +#define ES7243E_PDN_MOD2_RST BIT(4) +#define ES7243E_PDN_MOD1 BIT(3) +#define ES7243E_PDN_MOD2 BIT(2) +#define ES7243E_PDN_PGA1 BIT(1) +#define ES7243E_PDN_PGA2 BIT(0) +#define ES7243E_VMIDSEL 0x17 +#define ES7243E_ADC_BIAS_0x18 0x18 +#define ES7243E_PGA_BIAS 0x19 +#define ES7243E_ADC_BIAS_0x1A 0x1A +#define ES7243E_ADC_MICBIAS 0x1B +#define ES7243E_ADC_VRPBIAS 0x1C +#define ES7243E_ADC_LP 0x1D +#define ES7243E_ADC_PGA_LP 0x1E +#define ES7243E_ADC_VMID 0x1F +#define ES7243E_PGA1 0x20 +#define ES7243E_PGA1_EN BIT(4) +#define ES7243E_PGA2 0x21 +#define ES7243E_PGA2_EN BIT(4) +#define ES7243E_DLL_PWN 0xF9 +#define ES7243E_I2C_CONFIG 0xFC +#define ES7243E_FLAG 0xFA +#define ES7243E_CHIP_ID1 0xFD +#define ES7243E_CHIP_ID2 0xFE +#define ES7243E_CHIP_VER 0xFF + +struct es7243e_priv { + struct i2c_client *i2c; + struct clk *sclk; + struct clk *lrclk; + unsigned int sysclk; + const struct snd_pcm_hw_constraint_list *sysclk_constraints; +}; + +struct coeff_div { + u32 mclk; /* mclk frequency */ + u32 sr_rate; /* sample rate */ + u8 osr; /* ADC over sample rate */ + u8 mclk_pre; /* mclk prediv/premult */ + u8 cf_dsp_div; /* adclrck divider and daclrck divider */ + u8 scale; /* ADC gain scale up */ + u8 lrckdiv; /* lrck divider */ + u8 bclkdiv; /* sclk divider */ +}; + +static const struct regmap_config es7243e_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = ES7243E_CHIP_VER, + .cache_type = REGCACHE_MAPLE, +}; + +static const struct coeff_div coeff_div[] = { + /* mclk lrck osr pre div scale lrdiv bclkdiv */ + { 24576000, 8000, 0x20, 0x50, 0x00, 0x00, 0x0b, 0x2f }, + { 24576000, 12000, 0x20, 0x30, 0x00, 0x00, 0x07, 0x1f }, + { 24576000, 16000, 0x20, 0x20, 0x00, 0x00, 0x05, 0x17 }, + { 24576000, 24000, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 24576000, 32000, 0x20, 0x21, 0x00, 0x00, 0x02, 0x0b }, + { 24576000, 48000, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 12288000, 8000, 0x20, 0x20, 0x00, 0x00, 0x05, 0x17 }, + { 12288000, 12000, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 12288000, 16000, 0x20, 0x21, 0x00, 0x00, 0x02, 0x0b }, + { 12288000, 24000, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 12288000, 32000, 0x20, 0x22, 0x00, 0x00, 0x01, 0x05 }, + { 12288000, 48000, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 6144000, 8000, 0x20, 0x21, 0x00, 0x00, 0x02, 0x0b }, + { 6144000, 12000, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 6144000, 16000, 0x20, 0x22, 0x00, 0x00, 0x01, 0x05 }, + { 6144000, 24000, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 6144000, 32000, 0x20, 0x23, 0x00, 0x00, 0x00, 0x02 }, + { 6144000, 48000, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 3072000, 8000, 0x20, 0x22, 0x00, 0x00, 0x01, 0x05 }, + { 3072000, 12000, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 3072000, 16000, 0x20, 0x23, 0x00, 0x00, 0x00, 0x02 }, + { 3072000, 24000, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 3072000, 32000, 0x10, 0x03, 0x20, 0x04, 0x00, 0x02 }, + { 3072000, 48000, 0x20, 0x03, 0x00, 0x00, 0x00, 0x00 }, + { 1536000, 8000, 0x20, 0x23, 0x00, 0x00, 0x00, 0x02 }, + { 1536000, 12000, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 1536000, 16000, 0x10, 0x03, 0x20, 0x04, 0x00, 0x00 }, + { 1536000, 24000, 0x20, 0x03, 0x00, 0x00, 0x00, 0x00 }, + { 32768000, 8000, 0x20, 0x70, 0x00, 0x00, 0x0f, 0x3f }, + { 32768000, 16000, 0x20, 0x30, 0x00, 0x00, 0x07, 0x1f }, + { 32768000, 32000, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 16384000, 8000, 0x20, 0x30, 0x00, 0x00, 0x07, 0x1f }, + { 16384000, 16000, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 16384000, 32000, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 8192000, 8000, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 8192000, 16000, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 8192000, 32000, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 4096000, 8000, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 4096000, 16000, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 4096000, 32000, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 2048000, 8000, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 2048000, 16000, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 2048000, 32000, 0x20, 0x03, 0x00, 0x00, 0x00, 0x00 }, + { 1024000, 8000, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 1024000, 16000, 0x20, 0x03, 0x00, 0x00, 0x00, 0x00 }, + { 22579200, 11025, 0x20, 0x30, 0x00, 0x00, 0x07, 0x1f }, + { 22579200, 22050, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 22579200, 44100, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 11289600, 11025, 0x20, 0x10, 0x00, 0x00, 0x03, 0x0f }, + { 11289600, 22050, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 11289600, 44100, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 56448000, 11025, 0x20, 0x00, 0x00, 0x00, 0x01, 0x07 }, + { 56448000, 22050, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 56448000, 44100, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 28224000, 11025, 0x20, 0x01, 0x00, 0x00, 0x00, 0x03 }, + { 28224000, 22050, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 28224000, 44100, 0x20, 0x03, 0x00, 0x00, 0x00, 0x00 }, + { 14112000, 11025, 0x20, 0x02, 0x00, 0x00, 0x00, 0x01 }, + { 14112000, 22050, 0x20, 0x03, 0x00, 0x00, 0x00, 0x00 }, +}; + +static const struct coeff_div *get_coeff(int mclk, int rate) +{ + int i; + + for (i = 0; i < ARRAY_SIZE(coeff_div); i++) + if (coeff_div[i].sr_rate == rate && coeff_div[i].mclk == mclk) + return &coeff_div[i]; + + return NULL; +} + +static const unsigned int rates_12288[] = { + 8000, 12000, 16000, 24000, 32000, 48000, 64000, 96000, 128000, 192000, +}; + +static const struct snd_pcm_hw_constraint_list constraints_12288 = { + .count = ARRAY_SIZE(rates_12288), + .list = rates_12288, +}; + +static const unsigned int rates_8192[] = { + 8000, 16000, 32000, 64000, 128000, +}; + +static const struct snd_pcm_hw_constraint_list constraints_8192 = { + .count = ARRAY_SIZE(rates_8192), + .list = rates_8192, +}; + +static const unsigned int rates_112896[] = { + 8000, 11025, 22050, 44100, +}; + +static const struct snd_pcm_hw_constraint_list constraints_112896 = { + .count = ARRAY_SIZE(rates_112896), + .list = rates_112896, +}; + +static int es7243e_set_dai_sysclk(struct snd_soc_dai *dai, + int clk_id, unsigned int freq, int dir) +{ + struct snd_soc_component *component = dai->component; + struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); + struct es7243e_priv *es7243e = snd_soc_component_get_drvdata(component); + + switch (freq) { + case 11289600: + case 22579200: + es7243e->sysclk_constraints = &constraints_112896; + es7243e->sysclk = freq; + break; + case 12288000: + case 24576000: + es7243e->sysclk_constraints = &constraints_12288; + es7243e->sysclk = freq; + break; + case 4096000: + case 8192000: + es7243e->sysclk_constraints = &constraints_8192; + es7243e->sysclk = freq; + break; + default: + return -EINVAL; + } + + return snd_soc_dapm_sync(dapm); +} + +static int es7243e_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) +{ + struct snd_soc_component *component = dai->component; + unsigned int sdpfmt = 0; + unsigned int clk2 = 0; + bool is_dsp = false; + bool invert_lrck = false; + int ret; + + /* Set protocol of the serial data port */ + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { + case SND_SOC_DAIFMT_I2S: + sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 0); + break; + case SND_SOC_DAIFMT_LEFT_J: + sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 1); + break; + case SND_SOC_DAIFMT_DSP_A: + sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 3); + is_dsp = true; + break; + case SND_SOC_DAIFMT_DSP_B: + sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 3); + is_dsp = true; + break; + default: + return -EINVAL; + } + + /* Set LR and BCLK polarity */ + switch (fmt & SND_SOC_DAIFMT_INV_MASK) { + case SND_SOC_DAIFMT_NB_NF: + clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); + sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 0); + break; + case SND_SOC_DAIFMT_IB_IF: + clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 1); + sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 1); + invert_lrck = true; + break; + case SND_SOC_DAIFMT_IB_NF: + clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 1); + sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 0); + break; + case SND_SOC_DAIFMT_NB_IF: + clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); + sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 1); + invert_lrck = true; + break; + default: + return -EINVAL; + } + + /* Inverted LRCK is not available in DSP mode. */ + if (is_dsp && invert_lrck) + return -EINVAL; + + ret = snd_soc_component_update_bits(component, ES7243E_CLK2, + ES7243E_CLK2_BCLK_INV, clk2); + if (ret < 0) + return ret; + + return snd_soc_component_update_bits(component, ES7243E_SDP, + ES7243E_SDP_LRP, sdpfmt); +} + +static int es7243e_pcm_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct es7243e_priv *es7243e = snd_soc_component_get_drvdata(dai->component); + + if (!es7243e->sysclk_constraints) + return 0; + + return snd_pcm_hw_constraint_list(substream->runtime, 0, + SNDRV_PCM_HW_PARAM_RATE, + es7243e->sysclk_constraints); +} + +static int es7243e_pcm_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_soc_dai *dai) +{ + struct snd_soc_component *component = dai->component; + struct es7243e_priv *es7243e = dev_get_drvdata(dai->component->dev); + const struct coeff_div *cd; + unsigned int val; + int width; + int ret; + + cd = get_coeff(es7243e->sysclk, params_rate(params)); + if (!cd) { + dev_err(dai->component->dev, + "Can't set sample rate = %uHz, F_mclk = %uHz\n", + params_rate(params), es7243e->sysclk); + + return -EINVAL; + } + + ret = snd_soc_component_write(component, ES7243E_ADC_OSR, cd->osr); + if (ret < 0) + return ret; + + ret = snd_soc_component_write(component, ES7243E_MCLK_PRE, cd->mclk_pre); + if (ret < 0) + return ret; + + ret = snd_soc_component_write(component, ES7243E_CF_DSP_DIV, cd->cf_dsp_div); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_ADCCTL1_SCALE, cd->scale); + ret = snd_soc_component_update_bits(component, ES7243E_ADCCTL1, + ES7243E_ADCCTL1_SCALE, val); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_CLK7_LRCK_DIV_HI, cd->lrckdiv); + ret = snd_soc_component_update_bits(component, ES7243E_CLK7, + ES7243E_CLK7_LRCK_DIV_HI, val); + if (ret < 0) + return ret; + + ret = snd_soc_component_write(component, ES7243E_BCLK_DIV, cd->bclkdiv); + if (ret < 0) + return ret; + + switch ((params_width(params))) { + case 24: + width = 0; + break; + case 20: + width = 1; + break; + case 18: + width = 2; + break; + case 16: + width = 3; + break; + case 32: + width = 4; + break; + default: + return -ENOENT; + } + + val = FIELD_PREP(ES7243E_SDP_WL, width); + ret = snd_soc_component_update_bits(component, ES7243E_SDP, + ES7243E_SDP_WL, val); + if (ret < 0) + return ret; + + /* + * Delay timings are not documented in datasheet and come from vendor's + * driver implementation. + */ + fsleep(50 * USEC_PER_MSEC); + val = FIELD_PREP(ES7243E_SDP_MUTE, 0); + return snd_soc_component_update_bits(component, ES7243E_SDP, + ES7243E_SDP_MUTE, val); +} + +static int es7243e_mute(struct snd_soc_dai *dai, int mute, int direction) +{ + const int val = FIELD_PREP(ES7243E_SDP_MUTE, 3 * !!mute); + + return snd_soc_component_update_bits(dai->component, ES7243E_SDP, + ES7243E_SDP_MUTE, val); +} + +static const DECLARE_TLV_DB_RANGE(pga_scale, + 0, 10, TLV_DB_SCALE_ITEM(0, 300, 0), + 11, 14, TLV_DB_SCALE_ITEM(3300, 150, 0), +); + +static const DECLARE_TLV_DB_SCALE(vol_scale, -9550, 50, 0); + +static const struct snd_kcontrol_new es7243e_snd_controls[] = { + SOC_SINGLE_RANGE_TLV("PGA1 Volume", ES7243E_PGA1, 0, 0, 14, 0, pga_scale), + SOC_SINGLE_RANGE_TLV("PGA2 Volume", ES7243E_PGA2, 0, 0, 14, 0, pga_scale), + SOC_SINGLE_RANGE_TLV("ADC Volume", ES7243E_ADC_VOL, 0, 0, 255, 0, vol_scale), +}; + +static const struct snd_soc_dapm_widget es7243e_dapm_widgets[] = { + SND_SOC_DAPM_INPUT("INPUT"), + SND_SOC_DAPM_ADC("ADC", NULL, SND_SOC_NOPM, 0, 0), + SND_SOC_DAPM_AIF_OUT("SDOUT", "I2S Capture", 0, SND_SOC_NOPM, 0, 0), +}; + +static const struct snd_soc_dapm_route es7243e_dapm_routes[] = { + { "ADC", NULL, "INPUT" }, + { "SDOUT", NULL, "ADC" }, +}; + +static const struct snd_soc_dai_ops es7243e_ops = { + .startup = es7243e_pcm_startup, + .hw_params = es7243e_pcm_hw_params, + .set_fmt = es7243e_set_dai_fmt, + .set_sysclk = es7243e_set_dai_sysclk, + .mute_stream = es7243e_mute, +}; + +static struct snd_soc_dai_driver es7243e_dai = { + .name = "es7243e-hifi", + .capture = { + .stream_name = "Capture", + .channels_min = 2, + .channels_max = 2, + .rates = SNDRV_PCM_RATE_8000_48000, + .formats = (SNDRV_PCM_FMTBIT_S16_LE | + SNDRV_PCM_FMTBIT_S20_3LE | + SNDRV_PCM_FMTBIT_S24_LE | + SNDRV_PCM_FMTBIT_S32_LE), + }, + .ops = &es7243e_ops, +}; + +static const struct reg_sequence init_sequence[] = { + { ES7243E_CLK2, 0x00 }, + { ES7243E_SDP, 0x00 }, + { ES7243E_TDM, 0x00 }, + + /* Set MCLK/LRCK ratio to 256 */ + { ES7243E_ADC_OSR, 0x20 }, + { ES7243E_ADCCTL1, 0x00 }, + { ES7243E_MCLK_PRE, 0x01 }, + { ES7243E_CF_DSP_DIV, 0x00 }, + + { ES7243E_S1_SEL, 0xe0 }, + { ES7243E_S3_SEL, 0xa0 }, + + /* Set ADC volume to 0dB */ + { ES7243E_ADC_VOL, 0xbf }, + /* Enable dynamic HPF (high-pass filter), disable auto level control */ + { ES7243E_ADCCTL2, 0x80 }, + { ES7243E_ADC_HPF1, 0x0c }, + { ES7243E_ADC_HPF2, 0x0c }, + /* VDDA = 3.3V */ + { ES7243E_ADC_BIAS_0x18, 0x26 }, + { ES7243E_VMIDSEL, 0x02 }, + { ES7243E_PGA_BIAS, 0x77 }, + { ES7243E_ADC_BIAS_0x1A, 0xf4 }, + { ES7243E_ADC_MICBIAS, 0x66 }, + { ES7243E_ADC_VRPBIAS, 0x44 }, + { ES7243E_ADC_LP, 0x3c }, + { ES7243E_ADC_PGA_LP, 0x00 }, + { ES7243E_ADC_VMID, 0x0c }, + /* Set slave mode, enable clocks, power up */ + { ES7243E_RESET, 0x80 }, + { ES7243E_CLK1, 0x3a }, + { ES7243E_PDN, 0x00 }, + + /* Set PGAs gain to 0dB */ + { ES7243E_PGA1, 0x10 }, + { ES7243E_PGA2, 0x10, 100 * USEC_PER_MSEC }, + + /* Reset PGAs */ + { ES7243E_PDN, 0x03, 100 * USEC_PER_MSEC }, + { ES7243E_PDN, 0x00 }, +}; + +static int es7243e_probe(struct snd_soc_component *component) +{ + return regmap_multi_reg_write(component->regmap, init_sequence, + ARRAY_SIZE(init_sequence)); +} + +static int es7243e_suspend(struct snd_soc_component *component) +{ + struct es7243e_priv *es7243e = snd_soc_component_get_drvdata(component); + int ret; + unsigned int val, mask; + + val = FIELD_PREP(ES7243E_SDP_MUTE, 0); + ret = snd_soc_component_update_bits(component, ES7243E_SDP, + ES7243E_SDP_MUTE, val); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_PGA1_EN, 0); + snd_soc_component_update_bits(component, ES7243E_PGA1, + ES7243E_PGA1_EN, val); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_PGA2_EN, 0); + snd_soc_component_update_bits(component, ES7243E_PGA2, + ES7243E_PGA2_EN, val); + if (ret < 0) + return ret; + + ret = snd_soc_component_write(component, ES7243E_PDN, 0xff); + if (ret < 0) + return ret; + + mask = ES7243E_CLK1_ANA_ON | ES7243E_CLK1_ADC_ON; + ret = snd_soc_component_update_bits(component, ES7243E_CLK1, mask, 0); + if (ret < 0) + return ret; + + clk_disable_unprepare(es7243e->lrclk); + clk_disable_unprepare(es7243e->sclk); + + return 0; +} + +static int es7243e_resume(struct snd_soc_component *component) +{ + struct es7243e_priv *es7243e = snd_soc_component_get_drvdata(component); + int ret; + unsigned int val; + + ret = clk_prepare_enable(es7243e->sclk); + if (ret) + return ret; + + ret = clk_prepare_enable(es7243e->lrclk); + if (ret) + return ret; + + val = ES7243E_CLK1_ANA_ON | ES7243E_CLK1_ADC_ON; + ret = snd_soc_component_update_bits(component, ES7243E_CLK1, val, val); + if (ret < 0) + return ret; + + ret = snd_soc_component_write(component, ES7243E_PDN, 0); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_PGA1_EN, 1); + snd_soc_component_update_bits(component, ES7243E_PGA1, + ES7243E_PGA1_EN, val); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_PGA2_EN, 1); + snd_soc_component_update_bits(component, ES7243E_PGA2, + ES7243E_PGA2_EN, val); + if (ret < 0) + return ret; + + val = FIELD_PREP(ES7243E_SDP_MUTE, 3); + ret = snd_soc_component_update_bits(component, ES7243E_SDP, + ES7243E_SDP_MUTE, val); + if (ret < 0) + return ret; + + return 0; +} + +static const struct snd_soc_component_driver soc_component_dev_es7243e = { + .probe = es7243e_probe, + .controls = es7243e_snd_controls, + .suspend = es7243e_suspend, + .resume = es7243e_resume, + .num_controls = ARRAY_SIZE(es7243e_snd_controls), + .dapm_widgets = es7243e_dapm_widgets, + .num_dapm_widgets = ARRAY_SIZE(es7243e_dapm_widgets), + .dapm_routes = es7243e_dapm_routes, + .num_dapm_routes = ARRAY_SIZE(es7243e_dapm_routes), +}; + +static int es7243e_hw_init(struct device *dev) +{ + struct regmap *regmap = dev_get_regmap(dev, NULL); + u8 ids[2]; + u16 chip_id; + int ret; + + ret = regmap_bulk_read(regmap, ES7243E_CHIP_ID1, ids, ARRAY_SIZE(ids)); + if (ret < 0) + goto fail; + + chip_id = (ids[0] << 8) | ids[1]; + + if (chip_id != 0x7A43) { + return dev_err_probe(dev, -ENODEV, + "wrong CHIP ID: 0x%04x, expected 0x7A43\n", + chip_id); + } + + return 0; + +fail: + return dev_err_probe(dev, ret, "failed to read chip ID\n"); +} + +static int es7243e_i2c_probe(struct i2c_client *i2c) +{ + struct es7243e_priv *es7243e; + struct regmap *regmap; + int ret; + + es7243e = devm_kzalloc(&i2c->dev, sizeof(*es7243e), GFP_KERNEL); + if (!es7243e) + return -ENOMEM; + + es7243e->i2c = i2c; + dev_set_drvdata(&i2c->dev, es7243e); + + regmap = devm_regmap_init_i2c(i2c, &es7243e_regmap_config); + if (IS_ERR(regmap)) { + dev_err(&i2c->dev, "failed to init regmap\n"); + return PTR_ERR(regmap); + } + + es7243e->sclk = devm_clk_get_enabled(&i2c->dev, "sclk"); + if (IS_ERR(es7243e->sclk)) + return dev_err_probe(&i2c->dev, PTR_ERR(es7243e->sclk), + "failed to get sclk clock\n"); + + es7243e->lrclk = devm_clk_get_enabled(&i2c->dev, "lrclk"); + if (IS_ERR(es7243e->lrclk)) + return dev_err_probe(&i2c->dev, PTR_ERR(es7243e->lrclk), + "failed to get lrclk clock\n"); + + if (es7243e_hw_init(&i2c->dev)) + return -ENODEV; + + ret = devm_snd_soc_register_component(&i2c->dev, + &soc_component_dev_es7243e, + &es7243e_dai, 1); + if (ret) + return dev_err_probe(&i2c->dev, ret, "failed to register component\n"); + + return ret; +} + +static const struct i2c_device_id es7243e_i2c_id[] = { + { "es7243e", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, es7243e_i2c_id); + +static const struct of_device_id es7243e_dt_ids[] = { + { .compatible = "everest,es7243e", }, + { } +}; +MODULE_DEVICE_TABLE(of, es7243e_dt_ids); + +static struct i2c_driver es7243e_i2c_driver = { + .probe = es7243e_i2c_probe, + .id_table = es7243e_i2c_id, + .driver = { + .name = "es7243e-codec", + .of_match_table = es7243e_dt_ids, + }, +}; + +module_i2c_driver(es7243e_i2c_driver); +MODULE_DESCRIPTION("ASoC ES7243E audio ADC driver"); +MODULE_AUTHOR("Igor Prusov <ivprusov@salutedevices.com>"); +MODULE_LICENSE("GPL"); -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver 2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov @ 2024-09-21 12:59 ` kernel test robot 2024-09-21 17:38 ` kernel test robot ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2024-09-21 12:59 UTC (permalink / raw) To: Igor Prusov, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: oe-kbuild-all, linux-sound, linux-kernel, devicetree, kernel, prusovigor, David Yang, Martin Kurbanov Hi Igor, kernel test robot noticed the following build errors: [auto build test ERROR on baeb9a7d8b60b021d907127509c44507539c15e5] url: https://github.com/intel-lab-lkp/linux/commits/Igor-Prusov/ASoC-dt-bindings-Add-Everest-ES7243E/20240920-235246 base: baeb9a7d8b60b021d907127509c44507539c15e5 patch link: https://lore.kernel.org/r/20240920-es7243e-adc-v2-2-0be019735b81%40salutedevices.com patch subject: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240921/202409212032.P6kjCapX-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240921/202409212032.P6kjCapX-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202409212032.P6kjCapX-lkp@intel.com/ All errors (new ones prefixed by >>): sound/soc/codecs/es7243e.c: In function 'es7243e_set_dai_fmt': >> sound/soc/codecs/es7243e.c:252:27: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration] 252 | sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 0); | ^~~~~~~~~~ vim +/FIELD_PREP +252 sound/soc/codecs/es7243e.c 239 240 static int es7243e_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) 241 { 242 struct snd_soc_component *component = dai->component; 243 unsigned int sdpfmt = 0; 244 unsigned int clk2 = 0; 245 bool is_dsp = false; 246 bool invert_lrck = false; 247 int ret; 248 249 /* Set protocol of the serial data port */ 250 switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { 251 case SND_SOC_DAIFMT_I2S: > 252 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 0); 253 break; 254 case SND_SOC_DAIFMT_LEFT_J: 255 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 1); 256 break; 257 case SND_SOC_DAIFMT_DSP_A: 258 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 3); 259 is_dsp = true; 260 break; 261 case SND_SOC_DAIFMT_DSP_B: 262 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 3); 263 is_dsp = true; 264 break; 265 default: 266 return -EINVAL; 267 } 268 269 /* Set LR and BCLK polarity */ 270 switch (fmt & SND_SOC_DAIFMT_INV_MASK) { 271 case SND_SOC_DAIFMT_NB_NF: 272 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); 273 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 0); 274 break; 275 case SND_SOC_DAIFMT_IB_IF: 276 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 1); 277 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 1); 278 invert_lrck = true; 279 break; 280 case SND_SOC_DAIFMT_IB_NF: 281 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 1); 282 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 0); 283 break; 284 case SND_SOC_DAIFMT_NB_IF: 285 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); 286 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 1); 287 invert_lrck = true; 288 break; 289 default: 290 return -EINVAL; 291 } 292 293 /* Inverted LRCK is not available in DSP mode. */ 294 if (is_dsp && invert_lrck) 295 return -EINVAL; 296 297 ret = snd_soc_component_update_bits(component, ES7243E_CLK2, 298 ES7243E_CLK2_BCLK_INV, clk2); 299 if (ret < 0) 300 return ret; 301 302 return snd_soc_component_update_bits(component, ES7243E_SDP, 303 ES7243E_SDP_LRP, sdpfmt); 304 } 305 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver 2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov 2024-09-21 12:59 ` kernel test robot @ 2024-09-21 17:38 ` kernel test robot 2024-09-21 21:34 ` kernel test robot 2024-09-24 12:24 ` Mark Brown 3 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2024-09-21 17:38 UTC (permalink / raw) To: Igor Prusov, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: oe-kbuild-all, linux-sound, linux-kernel, devicetree, kernel, prusovigor, David Yang, Martin Kurbanov Hi Igor, kernel test robot noticed the following build warnings: [auto build test WARNING on baeb9a7d8b60b021d907127509c44507539c15e5] url: https://github.com/intel-lab-lkp/linux/commits/Igor-Prusov/ASoC-dt-bindings-Add-Everest-ES7243E/20240920-235246 base: baeb9a7d8b60b021d907127509c44507539c15e5 patch link: https://lore.kernel.org/r/20240920-es7243e-adc-v2-2-0be019735b81%40salutedevices.com patch subject: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240922/202409220118.t4hCju9t-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220118.t4hCju9t-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202409220118.t4hCju9t-lkp@intel.com/ All warnings (new ones prefixed by >>): >> sound/soc/codecs/es7243e.c:23: warning: expecting prototype for es7243e.c(). Prototype was for ES7243E_RESET() instead vim +23 sound/soc/codecs/es7243e.c 22 > 23 #define ES7243E_RESET 0x00 24 #define ES7243E_CLK1 0x01 25 #define ES7243E_CLK1_ANA_ON BIT(1) 26 #define ES7243E_CLK1_ADC_ON BIT(3) 27 #define ES7243E_CLK2 0x02 28 #define ES7243E_CLK2_BCLK_INV BIT(0) 29 #define ES7243E_ADC_OSR 0x03 30 #define ES7243E_MCLK_PRE 0x04 31 #define ES7243E_CF_DSP_DIV 0x05 32 #define ES7243E_BCLK_DIV 0x06 33 #define ES7243E_CLK7 0x07 34 #define ES7243E_CLK7_LRCK_DIV_HI GENMASK(3, 0) 35 #define ES7243E_LRCK_DIV 0x08 36 #define ES7243E_S1_SEL 0x09 37 #define ES7243E_S3_SEL 0x0A 38 #define ES7243E_SDP 0x0B 39 #define ES7243E_SDP_MUTE GENMASK(7, 6) 40 #define ES7243E_SDP_LRP BIT(5) 41 #define ES7243E_SDP_WL GENMASK(4, 2) 42 #define ES7243E_SDP_FMT GENMASK(1, 0) 43 #define ES7243E_TDM 0x0B 44 #define ES7243E_ADCCTL1 0x0D 45 #define ES7243E_ADCCTL1_SCALE GENMASK(2, 0) 46 #define ES7243E_ADC_VOL 0x0E 47 #define ES7243E_ADCCTL2 0x0F 48 #define ES7243E_AUTOMUTE1 0x10 49 #define ES7243E_AUTOMUTE2 0x11 50 #define ES7243E_AUTOMUTE3 0x12 51 #define ES7243E_AUTOMUTE4 0x13 52 #define ES7243E_ADC_HPF1 0x14 53 #define ES7243E_ADC_HPF2 0x15 54 #define ES7243E_PDN 0x16 55 #define ES7243E_PDN_ANA BIT(7) 56 #define ES7243E_PDN_BIAS BIT(6) 57 #define ES7243E_PDN_MOD1_RST BIT(5) 58 #define ES7243E_PDN_MOD2_RST BIT(4) 59 #define ES7243E_PDN_MOD1 BIT(3) 60 #define ES7243E_PDN_MOD2 BIT(2) 61 #define ES7243E_PDN_PGA1 BIT(1) 62 #define ES7243E_PDN_PGA2 BIT(0) 63 #define ES7243E_VMIDSEL 0x17 64 #define ES7243E_ADC_BIAS_0x18 0x18 65 #define ES7243E_PGA_BIAS 0x19 66 #define ES7243E_ADC_BIAS_0x1A 0x1A 67 #define ES7243E_ADC_MICBIAS 0x1B 68 #define ES7243E_ADC_VRPBIAS 0x1C 69 #define ES7243E_ADC_LP 0x1D 70 #define ES7243E_ADC_PGA_LP 0x1E 71 #define ES7243E_ADC_VMID 0x1F 72 #define ES7243E_PGA1 0x20 73 #define ES7243E_PGA1_EN BIT(4) 74 #define ES7243E_PGA2 0x21 75 #define ES7243E_PGA2_EN BIT(4) 76 #define ES7243E_DLL_PWN 0xF9 77 #define ES7243E_I2C_CONFIG 0xFC 78 #define ES7243E_FLAG 0xFA 79 #define ES7243E_CHIP_ID1 0xFD 80 #define ES7243E_CHIP_ID2 0xFE 81 #define ES7243E_CHIP_VER 0xFF 82 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver 2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov 2024-09-21 12:59 ` kernel test robot 2024-09-21 17:38 ` kernel test robot @ 2024-09-21 21:34 ` kernel test robot 2024-09-24 12:24 ` Mark Brown 3 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2024-09-21 21:34 UTC (permalink / raw) To: Igor Prusov, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: llvm, oe-kbuild-all, linux-sound, linux-kernel, devicetree, kernel, prusovigor, David Yang, Martin Kurbanov Hi Igor, kernel test robot noticed the following build errors: [auto build test ERROR on baeb9a7d8b60b021d907127509c44507539c15e5] url: https://github.com/intel-lab-lkp/linux/commits/Igor-Prusov/ASoC-dt-bindings-Add-Everest-ES7243E/20240920-235246 base: baeb9a7d8b60b021d907127509c44507539c15e5 patch link: https://lore.kernel.org/r/20240920-es7243e-adc-v2-2-0be019735b81%40salutedevices.com patch subject: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240922/202409220756.5MSHcbg7-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220756.5MSHcbg7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202409220756.5MSHcbg7-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from sound/soc/codecs/es7243e.c:15: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:25: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from sound/soc/codecs/es7243e.c:15: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:25: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from sound/soc/codecs/es7243e.c:15: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:25: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ In file included from sound/soc/codecs/es7243e.c:15: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:21: In file included from include/linux/mm.h:2239: include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> sound/soc/codecs/es7243e.c:252:13: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 252 | sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 0); | ^ sound/soc/codecs/es7243e.c:272:11: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 272 | clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); | ^ sound/soc/codecs/es7243e.c:351:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 351 | val = FIELD_PREP(ES7243E_ADCCTL1_SCALE, cd->scale); | ^ sound/soc/codecs/es7243e.c:405:18: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 405 | const int val = FIELD_PREP(ES7243E_SDP_MUTE, 3 * !!mute); | ^ sound/soc/codecs/es7243e.c:514:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 514 | val = FIELD_PREP(ES7243E_SDP_MUTE, 0); | ^ sound/soc/codecs/es7243e.c:570:8: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 570 | val = FIELD_PREP(ES7243E_PGA1_EN, 1); | ^ 7 warnings and 6 errors generated. vim +/FIELD_PREP +252 sound/soc/codecs/es7243e.c 239 240 static int es7243e_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) 241 { 242 struct snd_soc_component *component = dai->component; 243 unsigned int sdpfmt = 0; 244 unsigned int clk2 = 0; 245 bool is_dsp = false; 246 bool invert_lrck = false; 247 int ret; 248 249 /* Set protocol of the serial data port */ 250 switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { 251 case SND_SOC_DAIFMT_I2S: > 252 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 0); 253 break; 254 case SND_SOC_DAIFMT_LEFT_J: 255 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 1); 256 break; 257 case SND_SOC_DAIFMT_DSP_A: 258 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 3); 259 is_dsp = true; 260 break; 261 case SND_SOC_DAIFMT_DSP_B: 262 sdpfmt |= FIELD_PREP(ES7243E_SDP_FMT, 3); 263 is_dsp = true; 264 break; 265 default: 266 return -EINVAL; 267 } 268 269 /* Set LR and BCLK polarity */ 270 switch (fmt & SND_SOC_DAIFMT_INV_MASK) { 271 case SND_SOC_DAIFMT_NB_NF: 272 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); 273 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 0); 274 break; 275 case SND_SOC_DAIFMT_IB_IF: 276 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 1); 277 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 1); 278 invert_lrck = true; 279 break; 280 case SND_SOC_DAIFMT_IB_NF: 281 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 1); 282 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 0); 283 break; 284 case SND_SOC_DAIFMT_NB_IF: 285 clk2 |= FIELD_PREP(ES7243E_CLK2_BCLK_INV, 0); 286 sdpfmt |= FIELD_PREP(ES7243E_SDP_LRP, 1); 287 invert_lrck = true; 288 break; 289 default: 290 return -EINVAL; 291 } 292 293 /* Inverted LRCK is not available in DSP mode. */ 294 if (is_dsp && invert_lrck) 295 return -EINVAL; 296 297 ret = snd_soc_component_update_bits(component, ES7243E_CLK2, 298 ES7243E_CLK2_BCLK_INV, clk2); 299 if (ret < 0) 300 return ret; 301 302 return snd_soc_component_update_bits(component, ES7243E_SDP, 303 ES7243E_SDP_LRP, sdpfmt); 304 } 305 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver 2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov ` (2 preceding siblings ...) 2024-09-21 21:34 ` kernel test robot @ 2024-09-24 12:24 ` Mark Brown 3 siblings, 0 replies; 8+ messages in thread From: Mark Brown @ 2024-09-24 12:24 UTC (permalink / raw) To: Igor Prusov Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-sound, linux-kernel, devicetree, kernel, prusovigor, David Yang, Martin Kurbanov [-- Attachment #1: Type: text/plain, Size: 2549 bytes --] On Fri, Sep 20, 2024 at 06:41:08PM +0300, Igor Prusov wrote: > +config SND_SOC_ES7243E > + tristate "Everest Semi ES7243E CODEC" > + This is an I2C device, it should depend on I2C. > @@ -0,0 +1,693 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/** > + * es7243e.c - ASoC Everest Semiconductor ES7243E audio ADC driver > + * Please make the enitre comment a C++ one so things look more intentional. > + * Copyright (c) 2024, SaluteDevices. All Rights Reserved. All rights reserved? > +static const struct reg_sequence init_sequence[] = { > + { ES7243E_CLK2, 0x00 }, > + { ES7243E_SDP, 0x00 }, > + { ES7243E_TDM, 0x00 }, > + > + /* Set MCLK/LRCK ratio to 256 */ > + { ES7243E_ADC_OSR, 0x20 }, This should be dynamically configured rather than hard coded, provide set_bclk_ratio(). > + /* Set ADC volume to 0dB */ > + { ES7243E_ADC_VOL, 0xbf }, Most things should use the chip defaults, especially things like volumes - userspace can configure whatever it needs. > +static int es7243e_suspend(struct snd_soc_component *component) > +{ > + struct es7243e_priv *es7243e = snd_soc_component_get_drvdata(component); > + int ret; > + unsigned int val, mask; > + > + val = FIELD_PREP(ES7243E_SDP_MUTE, 0); > + ret = snd_soc_component_update_bits(component, ES7243E_SDP, > + ES7243E_SDP_MUTE, val); > + if (ret < 0) > + return ret; > + > + val = FIELD_PREP(ES7243E_PGA1_EN, 0); > + snd_soc_component_update_bits(component, ES7243E_PGA1, > + ES7243E_PGA1_EN, val); > + if (ret < 0) > + return ret; > + > + val = FIELD_PREP(ES7243E_PGA2_EN, 0); > + snd_soc_component_update_bits(component, ES7243E_PGA2, > + ES7243E_PGA2_EN, val); > + if (ret < 0) > + return ret; This looks a lot like you should be using DAPM with events on the PGAs, that will give power management at runtime as well. > + ret = snd_soc_component_write(component, ES7243E_PDN, 0xff); > + if (ret < 0) > + return ret; > + > + mask = ES7243E_CLK1_ANA_ON | ES7243E_CLK1_ADC_ON; > + ret = snd_soc_component_update_bits(component, ES7243E_CLK1, mask, 0); > + if (ret < 0) > + return ret; > + > + clk_disable_unprepare(es7243e->lrclk); > + clk_disable_unprepare(es7243e->sclk); You could also use set_bias_level() for chip level power, it doesn't look like there's substantial delay. > +static int es7243e_resume(struct snd_soc_component *component) > +{ > + struct es7243e_priv *es7243e = snd_soc_component_get_drvdata(component); > + int ret; > + unsigned int val; This doesn't resync the cache so the user volume settings will be lost. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-09-24 12:31 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-20 15:41 [PATCH v2 0/2] Add ES7243E ADC driver Igor Prusov 2024-09-20 15:41 ` [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E Igor Prusov 2024-09-24 12:31 ` Mark Brown 2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov 2024-09-21 12:59 ` kernel test robot 2024-09-21 17:38 ` kernel test robot 2024-09-21 21:34 ` kernel test robot 2024-09-24 12:24 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox