* [PATCH] ipe: Add missing terminator to list of unit tests
@ 2024-09-22 14:52 Guenter Roeck
2024-09-23 0:27 ` Paul Moore
2024-09-23 19:53 ` Paul Moore
0 siblings, 2 replies; 4+ messages in thread
From: Guenter Roeck @ 2024-09-22 14:52 UTC (permalink / raw)
To: Serge E . Hallyn
Cc: linux-security-module, linux-kernel, Guenter Roeck, Deven Bowers,
Paul Moore, Fan Wu
Add missing terminator to list of unit tests to avoid random crashes seen
when running the test.
Fixes: 10ca05a76065 ("ipe: kunit test for parser")
Cc: Deven Bowers <deven.desai@linux.microsoft.com>
Cc: Paul Moore <paul@paul-moore.com>
Cc: Fan Wu <wufan@linux.microsoft.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
security/ipe/policy_tests.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
index 89521f6b9994..5f1654deeb04 100644
--- a/security/ipe/policy_tests.c
+++ b/security/ipe/policy_tests.c
@@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
static struct kunit_case ipe_parser_test_cases[] = {
KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
KUNIT_CASE(ipe_parser_widestring_test),
+ { }
};
static struct kunit_suite ipe_parser_test_suite = {
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ipe: Add missing terminator to list of unit tests
2024-09-22 14:52 [PATCH] ipe: Add missing terminator to list of unit tests Guenter Roeck
@ 2024-09-23 0:27 ` Paul Moore
2024-09-23 17:40 ` Fan Wu
2024-09-23 19:53 ` Paul Moore
1 sibling, 1 reply; 4+ messages in thread
From: Paul Moore @ 2024-09-23 0:27 UTC (permalink / raw)
To: Guenter Roeck
Cc: Serge E . Hallyn, linux-security-module, linux-kernel,
Deven Bowers, Fan Wu
On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Add missing terminator to list of unit tests to avoid random crashes seen
> when running the test.
>
> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Fan Wu <wufan@linux.microsoft.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> security/ipe/policy_tests.c | 1 +
> 1 file changed, 1 insertion(+)
I'm guessing Fan doesn't have his tree setup yet, but if I can get an
ACK from Fan I can send this up via the LSM tree for the next
v6.12-rcX release.
> diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
> index 89521f6b9994..5f1654deeb04 100644
> --- a/security/ipe/policy_tests.c
> +++ b/security/ipe/policy_tests.c
> @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
> static struct kunit_case ipe_parser_test_cases[] = {
> KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
> KUNIT_CASE(ipe_parser_widestring_test),
> + { }
> };
>
> static struct kunit_suite ipe_parser_test_suite = {
--
paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ipe: Add missing terminator to list of unit tests
2024-09-23 0:27 ` Paul Moore
@ 2024-09-23 17:40 ` Fan Wu
0 siblings, 0 replies; 4+ messages in thread
From: Fan Wu @ 2024-09-23 17:40 UTC (permalink / raw)
To: Paul Moore, Guenter Roeck
Cc: Serge E . Hallyn, linux-security-module, linux-kernel,
Deven Bowers
On 9/22/2024 5:27 PM, Paul Moore wrote:
> On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> Add missing terminator to list of unit tests to avoid random crashes seen
>> when running the test.
>>
>> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
>> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
>> Cc: Paul Moore <paul@paul-moore.com>
>> Cc: Fan Wu <wufan@linux.microsoft.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> security/ipe/policy_tests.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> I'm guessing Fan doesn't have his tree setup yet, but if I can get an
> ACK from Fan I can send this up via the LSM tree for the next
> v6.12-rcX release.
>
>> diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
>> index 89521f6b9994..5f1654deeb04 100644
>> --- a/security/ipe/policy_tests.c
>> +++ b/security/ipe/policy_tests.c
>> @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
>> static struct kunit_case ipe_parser_test_cases[] = {
>> KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
>> KUNIT_CASE(ipe_parser_widestring_test),
>> + { }
>> };
>>
>> static struct kunit_suite ipe_parser_test_suite = {
>
Yes this looks good to me.
Acked-by: Fan Wu <wufan@linux.microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ipe: Add missing terminator to list of unit tests
2024-09-22 14:52 [PATCH] ipe: Add missing terminator to list of unit tests Guenter Roeck
2024-09-23 0:27 ` Paul Moore
@ 2024-09-23 19:53 ` Paul Moore
1 sibling, 0 replies; 4+ messages in thread
From: Paul Moore @ 2024-09-23 19:53 UTC (permalink / raw)
To: Guenter Roeck, Serge E . Hallyn
Cc: linux-security-module, linux-kernel, Guenter Roeck, Deven Bowers,
Fan Wu
On Sep 22, 2024 Guenter Roeck <linux@roeck-us.net> wrote:
>
> Add missing terminator to list of unit tests to avoid random crashes seen
> when running the test.
>
> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Fan Wu <wufan@linux.microsoft.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Fan Wu <wufan@linux.microsoft.com>
> ---
> security/ipe/policy_tests.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, merged into lsm/stable-6.12.
--
paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-23 19:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-22 14:52 [PATCH] ipe: Add missing terminator to list of unit tests Guenter Roeck
2024-09-23 0:27 ` Paul Moore
2024-09-23 17:40 ` Fan Wu
2024-09-23 19:53 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox