From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6713E28F4; Sun, 22 Sep 2024 15:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727017887; cv=none; b=CjLRpA2w3YpgSpxPM1u+LKrTia+tQrmQ7ZqGD+4a/MrrPe+DXnVS/J+rinMAo2nsk2Xwj83vZ2VXDOwy6sZnTe8rmZ7/o8Sy3NHut85NpZZhjA/LIJmt6Ki1NmrGjzczYCcFeI1vtjazzu+pxFAdGxfIHx1o44j8N/WsLkOKVr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727017887; c=relaxed/simple; bh=i9XCB8m7qYule9muylEf116wS7isyCTJubzHPe8ofZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ba+vPZY8F4f5oxOHqwnDA91jIj8ZmQ+pdqBhk+mOrL1fAK9w6rMQE2Kqr8pa8PAZZzpqsrVkOPHmPGUpB71EfLliWXTdoceyvsBojQrLry1QLilb+Cf+n1X+sF4JUvE1CwbdVDASRYSU6AIUnK6DbnwHCxLZQz0KSQqmTZO7FEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OLytZqJJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OLytZqJJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3E58C4CEC6; Sun, 22 Sep 2024 15:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727017886; bh=i9XCB8m7qYule9muylEf116wS7isyCTJubzHPe8ofZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OLytZqJJUd7VwLMxOF6xDjhI/ZZcBeJV6FnnllQvG3BlF4rhSsa96t+5fCucXWf2A D7NrCx0V2MlaKc7/CASDrLGm3oh6BqC1EEnPTdYcWC0gxtWIH5pzBGSeCK9VLZghdl Z5CYylP0YQCigRgwkf3oMgRf6bv3pwBhbxDdtw6v7bxvmbjHEjOBLbzfcPqWs0RJHS azW9f/WwGZv3XxnCDF6+ugNeE32eRB3pb8DIjFfs72tKo66rnGxWY2XejeyqHPwrof eagtZI70RV904N+nrcPzM9JNsH1OAO9glYPfZX73eV1TjQENjVirydD6ggTJDI0tU+ NaK9i8r746omw== From: SeongJae Park To: Leo Stone Cc: SeongJae Park , akpm@linux-foundation.org, ruanjinjie@huawei.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH] mm/damon: fix sparse warning for zero initializer Date: Sun, 22 Sep 2024 08:11:20 -0700 Message-ID: <20240922151121.469051-1-sj@kernel.org> X-Mailer: git-send-email 2.46.1 In-Reply-To: <20240921195511.364023-1-leocstone@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Leo, Thank you for this patch! On Sat, 21 Sep 2024 12:54:45 -0700 Leo Stone wrote: > sparse warns about zero initializing an array with {0,}, change it to > the equivalent {0}. > > Fixes the sparse warning: > mm/damon/tests/vaddr-kunit.h:69:47: warning: missing braces around initializer > > Signed-off-by: Leo Stone Reviewed-by: SeongJae Park I also think below tag would be good to add? 17ccae8bb5c9 ("mm/damon: add kunit tests") Thanks, SJ > --- > mm/damon/tests/vaddr-kunit.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/tests/vaddr-kunit.h b/mm/damon/tests/vaddr-kunit.h > index a339d117150f..3dad8dfd9005 100644 > --- a/mm/damon/tests/vaddr-kunit.h > +++ b/mm/damon/tests/vaddr-kunit.h > @@ -66,7 +66,7 @@ static int __link_vmas(struct maple_tree *mt, struct vm_area_struct *vmas, > static void damon_test_three_regions_in_vmas(struct kunit *test) > { > static struct mm_struct mm; > - struct damon_addr_range regions[3] = {0,}; > + struct damon_addr_range regions[3] = {0}; > /* 10-20-25, 200-210-220, 300-305, 307-330 */ > struct vm_area_struct vmas[] = { > (struct vm_area_struct) {.vm_start = 10, .vm_end = 20}, > -- > 2.43.0