From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC4826AED; Sun, 22 Sep 2024 16:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727024204; cv=none; b=Km8cXPrx/EP0v7wpE1+tRX8ALzo0uKAChWdQM0TG5lsfPTwQv+66PsHvRl61JN3t5cyNJzaIMF+0Zd/ZqzSmcojJJpG9pSX1T2LnVW7HhIjX543gTqG9O/4V5u0hsdFhyFDQ4XyIwEnEyd8FsASRtcnW/ApVOHqvJLUBXbVKaHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727024204; c=relaxed/simple; bh=IzUiiBWxKOEoxrsutv2RysTy/iP/OHwPa08dPre7tQ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qq3cWWlQX8LsfIiJJD+Y3MA6F5hJOHgoeUC3AwWchHSdeh3rn5olcDmKXOV0NcNCRaTN0g71geHFENi8welwtl5itVLJh7kooMwfNkmqOqx8FvSiKDc3KjZPMwBRRQSjQeWlkVZrFs34PAm6PaeXUdIallCE2wnThBTgM2WKxKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q4YgRILk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q4YgRILk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12AE3C4CEC3; Sun, 22 Sep 2024 16:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727024203; bh=IzUiiBWxKOEoxrsutv2RysTy/iP/OHwPa08dPre7tQ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q4YgRILk12OshWT6BnrLKMqHDUe3Lx64bSH519hGw6a7t7JDwI4sg7P8a1NX1tN93 bzCjrvaFzvobs/I+k+DScvkFIyCobfOCXWEyUyFNGWL0pTdexv2hO//0YNqjnUUfEN UVCt/QCY9w0IIxsBpkhZkT0Z45S06+4BrPACZ4tJVBKFeAhn8l8i52LDeuAanK+X+d xT30buhmoOFV+SoPTGjtA5NKA/kut0lO721Fet6CB35nKA7UgrLdxBrVIuCYZZ+Noz SQPXAartD/M4n8gNubeSeSdsjCXvMIClxRL8v7YXUeGFnliuWsoENwgovMXFCsdx4n B63hxDr1g2sxg== Date: Sun, 22 Sep 2024 17:56:38 +0100 From: Simon Horman To: Markus Elfring Cc: GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Himanshu Madhani , Jakub Kicinski , Manish Chopra , Paolo Abeni , Shahed Shaikh , LKML , kernel-janitors@vger.kernel.org, Manish Chopra Subject: Re: [PATCH] qlcnic: Use common error handling code in four functions Message-ID: <20240922165638.GB3426578@kernel.org> References: <7c98349a-bfa5-409b-847e-ed8439e80afd@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c98349a-bfa5-409b-847e-ed8439e80afd@web.de> On Thu, Sep 19, 2024 at 09:50:13PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 19 Sep 2024 21:30:45 +0200 > > Add jump targets so that a bit of exception handling can be better reused > at the end of four function implementations. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Hi Markus, This is an old driver, that doesn't appear to have been under active development for quite some time. Unless there is a way to exercise these changes I don't think that clean-ups of this nature are worth the risk of regressions they might introduce. If we can see bugs in error paths, let's fix them. Else, let's leave them be. -- pw-bot: rejected