From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Skvortsov <andrej.skvortzov@gmail.com>,
Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>,
Minchan Kim <minchan@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
stable@vger.kernel.org,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v2] zram: don't free statically defined names
Date: Tue, 24 Sep 2024 01:16:15 +0900 [thread overview]
Message-ID: <20240923161615.GG38742@google.com> (raw)
In-Reply-To: <20240923161108.991709-1-andrej.skvortzov@gmail.com>
On (24/09/23 19:11), Andrey Skvortsov wrote:
> The change is similar to that is used in comp_algorithm_set.
> default_compressor is used for ZRAM_PRIMARY_COMP only, but if
> CONFIG_ZRAM_MULTI_COMP isn't set, then ZRAM_PRIMARY_COMP and
> ZRAM_SECONDARY_COMP are the same.
>
> This is detected by KASAN.
>
> ==================================================================
> Call trace:
> kfree+0x60/0x3a0
> zram_destroy_comps+0x98/0x198 [zram]
> zram_reset_device+0x22c/0x4a8 [zram]
> reset_store+0x1bc/0x2d8 [zram]
> dev_attr_store+0x44/0x80
> sysfs_kf_write+0xfc/0x188
> kernfs_fop_write_iter+0x28c/0x428
> vfs_write+0x4dc/0x9b8
> ksys_write+0x100/0x1f8
> __arm64_sys_write+0x74/0xb8
> invoke_syscall+0xd8/0x260
> el0_svc_common.constprop.0+0xb4/0x240
> do_el0_svc+0x48/0x68
> el0_svc+0x40/0xc8
> el0t_64_sync_handler+0x120/0x130
> el0t_64_sync+0x190/0x198
> ==================================================================
>
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> Fixes: 684826f8271a ("zram: free secondary algorithms names")
> Cc: <stable@vger.kernel.org>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
prev parent reply other threads:[~2024-09-23 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 16:11 [PATCH v2] zram: don't free statically defined names Andrey Skvortsov
2024-09-23 16:16 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923161615.GG38742@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andrej.skvortzov@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
--cc=venkat88@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox