Re: [RFC v3 2/2] usb: typec: tcpm: Add support for parsing time dt properties

Amit Sunil Dhamne
2024-09-25T03:16:47Z

Hi,

On 9/24/24 7:44 PM, Amit Sunil Dhamne wrote:
> Hi Heikki,
>
> On 9/24/24 5:55 AM, Heikki Krogerus wrote:
>> Hi,
>>
>>> @@ -7611,10 +7650,13 @@ struct tcpm_port *tcpm_register_port(struct
>>> device *dev, struct tcpc_dev *tcpc)
>>>       err = tcpm_fw_get_caps(port, tcpc->fwnode);
>>>       if (err < 0)
>>>           goto out_destroy_wq;
>>> +
>>
>> This extra newline is not relevant or necessary. Otherwise this LGTM:
>
> Thanks for reviewing! Please let me know if I should upload a new set
> or this is alright at this time?

Uploaded a new patchset anyway:
https://lore.kernel.org/all/20240925031135.1101048-3-amitsd@google.com/

Thanks!

>
> --
>
> Amit
>
>>
>> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>>
>>>       err = tcpm_fw_get_snk_vdos(port, tcpc->fwnode);
>>>       if (err < 0)
>>>           goto out_destroy_wq;
>>>   +    tcpm_fw_get_timings(port, tcpc->fwnode);
>>> +
>>>       port->try_role = port->typec_caps.prefer_role;
>>>         port->typec_caps.revision = 0x0120;    /* Type-C spec
>>> release 1.2 */
>> thanks,
>>