Re: [PATCH v3] zram: don't free statically defined names

Sergey Senozhatsky
2024-09-25T00:37:24Z

On (24/09/24 11:29), Chris Li wrote:
> On Tue, Sep 24, 2024 at 8:56 AM Chris Li <chrisl@kernel.org> wrote:
[..]
> Given the merge window is closing. I suggest just reverting this
> change. As it is the fix also causing regression in the swap stress
> test for me. It is possible that is my test setup issue, but reverting
> sounds the safe bet.

The patch in question is just a kfree() call that is only executed
during zram reset and that fixes tiny memory leaks when zram is
configured with alternative (re-compression) streams. I cannot
imagine how that can have any impact on runtime, that makes no
sense to me, I'm not sure that revert is justified here.