* [PATCH] mfd: da9052-spi: change read-mask to write-mask
@ 2024-09-18 9:12 Marcus Folkesson
2024-09-19 8:52 ` Marcus Folkesson
0 siblings, 1 reply; 3+ messages in thread
From: Marcus Folkesson @ 2024-09-18 9:12 UTC (permalink / raw)
To: Support Opensource, Lee Jones; +Cc: linux-kernel, Marcus Folkesson
Actually, the LSB bit is set on write rather than read.
Change it to avoid nasty things to happen.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/mfd/da9052-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index be5f2b34e18aebc7a9506123b366af5a5447df43..80fc5c0cac2fb0e5e99e6db8972f80ae4155b226 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -37,7 +37,7 @@ static int da9052_spi_probe(struct spi_device *spi)
spi_set_drvdata(spi, da9052);
config = da9052_regmap_config;
- config.read_flag_mask = 1;
+ config.write_flag_mask = 1;
config.reg_bits = 7;
config.pad_bits = 1;
config.val_bits = 8;
---
base-commit: 33cc938e65a98f1d29d0a18403dbbee050dcad9a
change-id: 20240918-da9052-df843a1b9d0e
Best regards,
--
Marcus Folkesson <marcus.folkesson@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: da9052-spi: change read-mask to write-mask
2024-09-18 9:12 [PATCH] mfd: da9052-spi: change read-mask to write-mask Marcus Folkesson
@ 2024-09-19 8:52 ` Marcus Folkesson
2024-09-25 9:58 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Marcus Folkesson @ 2024-09-19 8:52 UTC (permalink / raw)
To: Support Opensource, Lee Jones; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Wed, Sep 18, 2024 at 11:12:22AM +0200, Marcus Folkesson wrote:
> Actually, the LSB bit is set on write rather than read.
> Change it to avoid nasty things to happen.
>
Fixes: e9e9d3973594 ("mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: da9052-spi: change read-mask to write-mask
2024-09-19 8:52 ` Marcus Folkesson
@ 2024-09-25 9:58 ` Lee Jones
0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-09-25 9:58 UTC (permalink / raw)
To: Marcus Folkesson; +Cc: Support Opensource, linux-kernel
On Thu, 19 Sep 2024, Marcus Folkesson wrote:
> On Wed, Sep 18, 2024 at 11:12:22AM +0200, Marcus Folkesson wrote:
> > Actually, the LSB bit is set on write rather than read.
> > Change it to avoid nasty things to happen.
> >
> Fixes: e9e9d3973594 ("mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver")
Please resubmit the patch.
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-25 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 9:12 [PATCH] mfd: da9052-spi: change read-mask to write-mask Marcus Folkesson
2024-09-19 8:52 ` Marcus Folkesson
2024-09-25 9:58 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox