Re: [PATCH AUTOSEL 6.11 109/244] ASoC: soc-pcm: Indicate warning if dpcm_playback/capture were used for availability limition

Mark Brown
2024-09-25T12:13:26Z

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

On Wed, Sep 25, 2024 at 07:25:30AM -0400, Sasha Levin wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> [ Upstream commit fd69dfe6789f4ed46d1fdb52e223cff83946d997 ]
>
> I have been wondering why DPCM needs special flag (= dpcm_playback/capture)
> to use it. Below is the history why it was added to ASoC.

...

> Because of these history, this dpcm_xxx is unneeded flag today. But because
> we have been used it for 10 years since (B), it may have been used
> differently. For example some DAI available both playback/capture, but it
> set dpcm_playback flag only, in this case dpcm_xxx flag is used as
> availability limitation. We can use playback_only flag instead in this
> case, but it is very difficult to find such DAI today.
>
> Let's add grace time to remove dpcm_playback/capture flag.
>
> This patch don't use dpcm_xxx flag anymore, and indicates warning to use
> xxx_only flag if both playback/capture were available but using only
> one of dpcm_xxx flag, and not using xxx_only flag.

This is a cleanup/refactoring preparation patch, I can see no reason why
it would be considered for stable.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]