From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8F62191499; Wed, 25 Sep 2024 12:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727266606; cv=none; b=KvtEp1oFzyHRpYK4rTSxZGPo98ngWivgzZ+0zMNJtnUQz0iV+Iy4uCDMWK30bEnC8q9xzIbmBadl6zVTXH6EZzrot/0Y4xJBPhWPSimXgWzMQ/urgpjf9HHHGxJ8XqC2QzYffJxvSYzmL955hgGvAx1GkxbA3VQRfQNGO1QUc/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727266606; c=relaxed/simple; bh=G67GbTF+iTgJVA86LDwk7DMSITrG5Q5tEDvNNktzFh4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cd0yeY5TQ2zp0UFcEUdNUSLZXA1icuE2xDN6v0NerD+R3B4+B1VmGwPfZYprMkNJx5FhAPrL2/toTO2SoCuWRvZqQ9gJZuBG70nPR4GLC7tpFk4vU5KJ+ffkiaZe6IRIEPg5PTSmHQXMUcMPsuNJOd0rJb/Xq5qa2iaRNpMzLwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=seOsetwo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="seOsetwo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48997C4CEC3; Wed, 25 Sep 2024 12:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727266606; bh=G67GbTF+iTgJVA86LDwk7DMSITrG5Q5tEDvNNktzFh4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=seOsetwo3bKiieH1BOsDSzTif0V4ooFI8dveo8jnZZs68VROSnvs6sGu3/ok1yIEq VfRGgKRMSbBhGIZcaKv0I/Rc5iI71o1xT77DYOO3n8pYbrRIbhyC1Rnmuurh6PXZ7b d3Q1FV46C+FeWIzoLcg8xwVxdfpy1Zt9CtEBOdE3cd0i2Wi3PxAAkqPLaN1oVNx1Ay acd3eeTmle+8qelWYZnEmstXYEXQO/oZ+eNLLEzyvWmvNRtyraArZT9kwrmH9ehZ81 eFWfM01c0yqJ9orPFlBuLovrDUkK/Ukc+fldu1RhbDRaGIzlfvw8g3yRt8Hs32yw4Q f9sitHZNypsrA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Tom Chung , Rodrigo Siqueira , Roman Li , Alex Hung , Aurabindo Pillai , Harry Wentland , Hamza Mahfooz , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, harikrishna.revalla@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 110/139] drm/amd/display: Fix index out of bounds in degamma hardware format translation Date: Wed, 25 Sep 2024 08:08:50 -0400 Message-ID: <20240925121137.1307574-110-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240925121137.1307574-1-sashal@kernel.org> References: <20240925121137.1307574-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.52 Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit b7e99058eb2e86aabd7a10761e76cae33d22b49f ] Fixes index out of bounds issue in `cm_helper_translate_curve_to_degamma_hw_format` function. The issue could occur when the index 'i' exceeds the number of transfer function points (TRANSFER_FUNC_POINTS). The fix adds a check to ensure 'i' is within bounds before accessing the transfer function points. If 'i' is out of bounds the function returns false to indicate an error. Reported by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:594 cm_helper_translate_curve_to_degamma_hw_format() error: buffer overflow 'output_tf->tf_pts.red' 1025 <= s32max drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:595 cm_helper_translate_curve_to_degamma_hw_format() error: buffer overflow 'output_tf->tf_pts.green' 1025 <= s32max drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_cm_common.c:596 cm_helper_translate_curve_to_degamma_hw_format() error: buffer overflow 'output_tf->tf_pts.blue' 1025 <= s32max Cc: Tom Chung Cc: Rodrigo Siqueira Cc: Roman Li Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Cc: Hamza Mahfooz Signed-off-by: Srinivasan Shanmugam Reviewed-by: Tom Chung Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c index c0372aa4ec838..684e30f9cf898 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c @@ -571,6 +571,8 @@ bool cm_helper_translate_curve_to_degamma_hw_format( i += increment) { if (j == hw_points - 1) break; + if (i >= TRANSFER_FUNC_POINTS) + return false; rgb_resulted[j].red = output_tf->tf_pts.red[i]; rgb_resulted[j].green = output_tf->tf_pts.green[i]; rgb_resulted[j].blue = output_tf->tf_pts.blue[i]; -- 2.43.0