* [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add missing "interrupt-controller" to example
@ 2024-09-25 17:34 Rob Herring (Arm)
2024-09-26 7:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-09-25 17:34 UTC (permalink / raw)
To: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley,
Caleb Connolly
Cc: linux-pm, devicetree, linux-kernel
Enabling dtc interrupt_provider check reveals the example is missing
the "interrupt-controller" property as it is a dependency of
"#interrupt-cells".
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
index 277c47e048b6..a1b4926e7190 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
@@ -61,6 +61,7 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
#interrupt-cells = <4>;
+ interrupt-controller;
charger@1000 {
compatible = "qcom,pmi8998-charger";
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add missing "interrupt-controller" to example
2024-09-25 17:34 [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add missing "interrupt-controller" to example Rob Herring (Arm)
@ 2024-09-26 7:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-26 7:05 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley,
Caleb Connolly, linux-pm, devicetree, linux-kernel
On Wed, Sep 25, 2024 at 12:34:12PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells".
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> index 277c47e048b6..a1b4926e7190 100644
> --- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> @@ -61,6 +61,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
> #interrupt-cells = <4>;
> + interrupt-controller;
Opposite, the interrupt-cells should be dropped. The parent ("pmic") is
qcom,spmi-pmic.yaml which is not an interrupt controller, according to
the bindings.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-26 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 17:34 [PATCH] dt-bindings: power/supply: qcom,pmi8998-char: Add missing "interrupt-controller" to example Rob Herring (Arm)
2024-09-26 7:05 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox