* [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples
@ 2024-09-25 17:35 Rob Herring (Arm)
2024-09-26 6:44 ` Nikita Shubin
2024-09-26 16:55 ` Conor Dooley
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-09-25 17:35 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Krzysztof Kozlowski,
Conor Dooley, Nikita Shubin
Cc: Rob Herring, linux-gpio, devicetree, linux-kernel
From: Rob Herring <robh@kernel.org>
Enabling dtc interrupt_provider check reveals the examples are missing
the "#interrupt-cells" property as it is a dependency of
"interrupt-controller".
Some of the indentation is off, so fix that too.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
index daadfb4926c3..3a1079d6ee20 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
@@ -73,9 +73,10 @@ examples:
reg-names = "data", "dir", "intr";
gpio-controller;
#gpio-cells = <2>;
- interrupt-controller;
- interrupt-parent = <&vic1>;
- interrupts = <27>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&vic1>;
+ interrupts = <27>;
};
gpio@80840004 {
@@ -87,6 +88,7 @@ examples:
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
+ #interrupt-cells = <2>;
interrupt-parent = <&vic1>;
interrupts = <27>;
};
@@ -127,6 +129,7 @@ examples:
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
+ #interrupt-cells = <2>;
interrupts-extended = <&vic0 19>, <&vic0 20>,
<&vic0 21>, <&vic0 22>,
<&vic1 15>, <&vic1 16>,
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples
2024-09-25 17:35 [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples Rob Herring (Arm)
@ 2024-09-26 6:44 ` Nikita Shubin
2024-09-26 16:55 ` Conor Dooley
1 sibling, 0 replies; 3+ messages in thread
From: Nikita Shubin @ 2024-09-26 6:44 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Alexander Sverdlin, Arnd Bergmann, linux-gpio, devicetree,
linux-kernel, Linus Walleij, Bartosz Golaszewski,
Krzysztof Kozlowski, Conor Dooley
Hi Rob!
Thank you!
Reviewed-by: Nikita Shubin <nikita.shubin@maquefel.me>
On Wed, 2024-09-25 at 12:35 -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@kernel.org>
>
> Enabling dtc interrupt_provider check reveals the examples are
> missing
> the "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
>
> Some of the indentation is off, so fix that too.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++--
> -
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> index daadfb4926c3..3a1079d6ee20 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> @@ -73,9 +73,10 @@ examples:
> reg-names = "data", "dir", "intr";
> gpio-controller;
> #gpio-cells = <2>;
> - interrupt-controller;
> - interrupt-parent = <&vic1>;
> - interrupts = <27>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&vic1>;
> + interrupts = <27>;
> };
>
> gpio@80840004 {
> @@ -87,6 +88,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupt-parent = <&vic1>;
> interrupts = <27>;
> };
> @@ -127,6 +129,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupts-extended = <&vic0 19>, <&vic0 20>,
> <&vic0 21>, <&vic0 22>,
> <&vic1 15>, <&vic1 16>,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples
2024-09-25 17:35 [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples Rob Herring (Arm)
2024-09-26 6:44 ` Nikita Shubin
@ 2024-09-26 16:55 ` Conor Dooley
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-09-26 16:55 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Linus Walleij, Bartosz Golaszewski, Krzysztof Kozlowski,
Conor Dooley, Nikita Shubin, linux-gpio, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
On Wed, Sep 25, 2024 at 12:35:10PM -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@kernel.org>
>
> Enabling dtc interrupt_provider check reveals the examples are missing
> the "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
>
> Some of the indentation is off, so fix that too.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> index daadfb4926c3..3a1079d6ee20 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> @@ -73,9 +73,10 @@ examples:
> reg-names = "data", "dir", "intr";
> gpio-controller;
> #gpio-cells = <2>;
> - interrupt-controller;
> - interrupt-parent = <&vic1>;
> - interrupts = <27>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&vic1>;
> + interrupts = <27>;
> };
>
> gpio@80840004 {
> @@ -87,6 +88,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupt-parent = <&vic1>;
> interrupts = <27>;
> };
> @@ -127,6 +129,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupts-extended = <&vic0 19>, <&vic0 20>,
> <&vic0 21>, <&vic0 22>,
> <&vic1 15>, <&vic1 16>,
> --
> 2.45.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-26 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 17:35 [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples Rob Herring (Arm)
2024-09-26 6:44 ` Nikita Shubin
2024-09-26 16:55 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox