From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060DA1684A1; Thu, 26 Sep 2024 01:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727315572; cv=none; b=cJZEOBfe6HMrec1FAvwTh9LDhFZkxJCUxn+pJrIjjC5ZiVMpjrdCU7C5sB04AFo1lnrk/htSJAgZO8qV0tVRL1ariaQu++OUsrcGMIZ2qNkcKk1081h1YB9v4P+ObMDxtDTV3EgLpa7LxsqYp+LlVp+UP3k7giXtUoKD5k6WHNk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727315572; c=relaxed/simple; bh=MobofQEzC8dRo1cojab5fJxNwAfwEILkvkDNv3fGzuQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LND9sYK3dJPhfZA8F1goFbM5Z7mxEeoT7KEkoV8b94aJEGbgOKYNRSowTcbb2Kj8mdV6I7r3ZH5WqMJe+IFaWMN1gHeCdEiLoqr4LDb5GUmKfx6ZLQfla22LI6MWRZ+2IIqt70n++wDMA4Hl4Khw40AyD6nKsEbZ/XT7TuC9isY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=I9mozbNF; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="I9mozbNF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727315570; x=1758851570; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MobofQEzC8dRo1cojab5fJxNwAfwEILkvkDNv3fGzuQ=; b=I9mozbNFiUJFDI78SH6SSSEnn99JQWGGEMUPX7Es+OW8cvlUNbQ6Hktu mPGMhrmRW1kEokli5+3jVgKNzfcVZp6jAli/rNVTRef0qo5USdzPNUBU3 ti8RjL+V5fWtdv5OnskCqI0foOo6cFXqiZHe5plgNJH90GiynwPxYBUoL DoRFHwGFX3uPg3Lzr22wGF814cFwr9UpC5vJ1ZYeGmWUS5eIh08NiBfcU 2Ri4t+LZ4a1U80NkWvfzyLfji4wWhST0tcAYGl1+hkiCWi6mKWlJyHfMX +IMtfB3Z/cxEf1DkhVvWOEt68qznT38RZW5vFSusB/HZdQqv79+QlFSFW g==; X-CSE-ConnectionGUID: 1vfozYSLQ3eWMafRA2UO2Q== X-CSE-MsgGUID: MiNKAX1eQt+JT1IqLTaMXg== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="26518043" X-IronPort-AV: E=Sophos;i="6.10,259,1719903600"; d="scan'208";a="26518043" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2024 18:52:50 -0700 X-CSE-ConnectionGUID: bRS9d/eLT6Gaz/RuY1wobA== X-CSE-MsgGUID: YCWhNJfnQQKYiczHLwlnNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,259,1719903600"; d="scan'208";a="71635267" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa007.fm.intel.com with ESMTP; 25 Sep 2024 18:52:46 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1stdgS-000K7X-1n; Thu, 26 Sep 2024 01:52:44 +0000 Date: Thu, 26 Sep 2024 09:52:28 +0800 From: kernel test robot To: Markus Elfring , linux-usb@vger.kernel.org, Andreas Noever , Michael Jamet , Mika Westerberg , Yehezkel Bernat Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] thunderbolt: Use common error handling code in update_property_block() Message-ID: <202409260928.qBlg2dBU-lkp@intel.com> References: <26b7f215-4f83-413c-9dab-737d790053c0@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26b7f215-4f83-413c-9dab-737d790053c0@web.de> Hi Markus, kernel test robot noticed the following build errors: [auto build test ERROR on westeri-thunderbolt/next] [also build test ERROR on linus/master v6.11 next-20240925] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Markus-Elfring/thunderbolt-Use-common-error-handling-code-in-update_property_block/20240925-161308 base: https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next patch link: https://lore.kernel.org/r/26b7f215-4f83-413c-9dab-737d790053c0%40web.de patch subject: [PATCH] thunderbolt: Use common error handling code in update_property_block() config: x86_64-randconfig-001-20240926 (https://download.01.org/0day-ci/archive/20240926/202409260928.qBlg2dBU-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240926/202409260928.qBlg2dBU-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202409260928.qBlg2dBU-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/thunderbolt/xdomain.c:703:23: error: use of undeclared identifier 'dir' 703 | tb_property_free_dir(dir); | ^ 1 error generated. vim +/dir +703 drivers/thunderbolt/xdomain.c 645 646 static void update_property_block(struct tb_xdomain *xd) 647 { 648 mutex_lock(&xdomain_lock); 649 mutex_lock(&xd->lock); 650 /* 651 * If the local property block is not up-to-date, rebuild it now 652 * based on the global property template. 653 */ 654 if (!xd->local_property_block || 655 xd->local_property_block_gen < xdomain_property_block_gen) { 656 struct tb_property_dir *dir; 657 int ret, block_len; 658 u32 *block; 659 660 dir = tb_property_copy_dir(xdomain_property_dir); 661 if (!dir) { 662 dev_warn(&xd->dev, "failed to copy properties\n"); 663 goto out_unlock; 664 } 665 666 /* Fill in non-static properties now */ 667 tb_property_add_text(dir, "deviceid", utsname()->nodename); 668 tb_property_add_immediate(dir, "maxhopid", xd->local_max_hopid); 669 670 ret = tb_property_format_dir(dir, NULL, 0); 671 if (ret < 0) { 672 dev_warn(&xd->dev, "local property block creation failed\n"); 673 goto out_free_dir; 674 } 675 676 block_len = ret; 677 block = kcalloc(block_len, sizeof(*block), GFP_KERNEL); 678 if (!block) 679 goto out_free_dir; 680 681 ret = tb_property_format_dir(dir, block, block_len); 682 if (ret) { 683 dev_warn(&xd->dev, "property block generation failed\n"); 684 kfree(block); 685 goto out_free_dir; 686 } 687 688 tb_property_free_dir(dir); 689 /* Release the previous block */ 690 kfree(xd->local_property_block); 691 /* Assign new one */ 692 xd->local_property_block = block; 693 xd->local_property_block_len = block_len; 694 xd->local_property_block_gen = xdomain_property_block_gen; 695 } 696 697 out_unlock: 698 mutex_unlock(&xd->lock); 699 mutex_unlock(&xdomain_lock); 700 return; 701 702 out_free_dir: > 703 tb_property_free_dir(dir); 704 goto out_unlock; 705 } 706 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki