public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	 Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 Kan Liang <kan.liang@linux.intel.com>,
	John Garry <john.g.garry@oracle.com>,
	 Jing Zhang <renyu.zj@linux.alibaba.com>,
	Sandipan Das <sandipan.das@amd.com>,
	 Benjamin Gray <bgray@linux.ibm.com>, Xu Yang <xu.yang_2@nxp.com>,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org
Subject: [PATCH v4 01/12] perf jevents: Allow multiple metricgroups.json files
Date: Thu, 26 Sep 2024 10:35:43 -0700	[thread overview]
Message-ID: <20240926173554.404411-2-irogers@google.com> (raw)
In-Reply-To: <20240926173554.404411-1-irogers@google.com>

Allow multiple metricgroups.json files by handling any file ending
with metricgroups.json as a metricgroups file.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/jevents.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index bb0a5d92df4a..8d2cecb87e88 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -612,7 +612,7 @@ def preprocess_one_file(parents: Sequence[str], item: os.DirEntry) -> None:
   if not item.is_file() or not item.name.endswith('.json'):
     return
 
-  if item.name == 'metricgroups.json':
+  if item.name.endswith('metricgroups.json'):
     metricgroup_descriptions = json.load(open(item.path))
     for mgroup in metricgroup_descriptions:
       assert len(mgroup) > 1, parents
@@ -665,7 +665,7 @@ def process_one_file(parents: Sequence[str], item: os.DirEntry) -> None:
 
   # Ignore other directories. If the file name does not have a .json
   # extension, ignore it. It could be a readme.txt for instance.
-  if not item.is_file() or not item.name.endswith('.json') or item.name == 'metricgroups.json':
+  if not item.is_file() or not item.name.endswith('.json') or item.name.endswith('metricgroups.json'):
     return
 
   add_events_table_entries(item, get_topic(item.name))
-- 
2.46.1.824.gd892dcdcdd-goog


  reply	other threads:[~2024-09-26 17:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26 17:35 [PATCH v4 00/12] Foundations for metric generation with Python Ian Rogers
2024-09-26 17:35 ` Ian Rogers [this message]
2024-09-26 17:35 ` [PATCH v4 02/12] perf jevents: Update metric constraint support Ian Rogers
2024-09-26 17:35 ` [PATCH v4 03/12] perf jevents: Add descriptions to metricgroup abstraction Ian Rogers
2024-09-26 17:35 ` [PATCH v4 04/12] perf jevents: Allow metric groups not to be named Ian Rogers
2024-09-26 17:35 ` [PATCH v4 05/12] perf jevents: Support parsing negative exponents Ian Rogers
2024-09-26 17:35 ` [PATCH v4 06/12] perf jevents: Term list fix in event parsing Ian Rogers
2024-09-26 17:35 ` [PATCH v4 07/12] perf jevents: Add threshold expressions to Metric Ian Rogers
2024-09-26 17:35 ` [PATCH v4 08/12] perf jevents: Move json encoding to its own functions Ian Rogers
2024-09-26 17:35 ` [PATCH v4 09/12] perf jevents: Drop duplicate pending metrics Ian Rogers
2024-09-26 17:35 ` [PATCH v4 10/12] perf jevents: Skip optional metrics in metric group list Ian Rogers
2024-09-26 17:35 ` [PATCH v4 11/12] perf jevents: Build support for generating metrics from python Ian Rogers
2024-09-26 17:35 ` [PATCH v4 12/12] perf jevents: Add load event json to verify and allow fallbacks Ian Rogers
2024-10-11  4:32   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240926173554.404411-2-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bgray@linux.ibm.com \
    --cc=john.g.garry@oracle.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=renyu.zj@linux.alibaba.com \
    --cc=sandipan.das@amd.com \
    --cc=xu.yang_2@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox