public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Volodymyr Boyko <boyko.cxx@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: boyko.cxx@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] net: retain NOCARRIER on protodown interfaces
Date: Fri, 27 Sep 2024 10:33:30 +0300	[thread overview]
Message-ID: <20240927073331.80425-1-boyko.cxx@gmail.com> (raw)

Make interface with enabled protodown to retain NOCARRIER state during
transfer of operstate from its lower device.

Signed-off-by: Volodymyr Boyko <boyko.cxx@gmail.com>
---
Currently bringing up lower device enables carrier on upper devices
ignoring the protodown flag.

Steps to reproduce:
```
ip l a test0 up type dummy
ip l a test0.mv0 up link test0 type macvlan mode bridge
ip l s test0.mv0 protodown on
sleep 1
printf 'before flap:\n'
ip -o l show | grep test0
ip l set down test0 && ip l set up test0
printf 'after flap:\n'
ip -o l show | grep test0
ip l del test0
```

output without this change:
```
before flap:
28: test0.mv0@test0: <NO-CARRIER,BROADCAST,MULTICAST,UP>
	 state LOWERLAYERDOWN protodown on
after flap:
28: test0.mv0@test0: <BROADCAST,MULTICAST,UP,LOWER_UP>
	 state UP protodown on
```

output with this change:
```
before flap:
28: test0.mv0@test0: <NO-CARRIER,BROADCAST,MULTICAST,UP>
	state DOWN protodown on
after flap:
28: test0.mv0@test0: <NO-CARRIER,BROADCAST,MULTICAST,UP>
	state DOWN protodown on
```
---
 net/core/dev.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 1e740faf9e78..10b0ae0ca5a8 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -10198,10 +10198,12 @@ void netif_stacked_transfer_operstate(const struct net_device *rootdev,
 	else
 		netif_testing_off(dev);
 
-	if (netif_carrier_ok(rootdev))
-		netif_carrier_on(dev);
-	else
-		netif_carrier_off(dev);
+	if (!dev->proto_down) {
+		if (netif_carrier_ok(rootdev))
+			netif_carrier_on(dev);
+		else
+			netif_carrier_off(dev);
+	}
 }
 EXPORT_SYMBOL(netif_stacked_transfer_operstate);
 
-- 
2.39.5


             reply	other threads:[~2024-09-27  7:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27  7:33 Volodymyr Boyko [this message]
2024-10-03  8:55 ` [PATCH] net: retain NOCARRIER on protodown interfaces Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240927073331.80425-1-boyko.cxx@gmail.com \
    --to=boyko.cxx@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox