Re: [PATCH net-next 1/6] net: gianfar: use devm_alloc_etherdev_mqs

Maxime Chevallier
2024-10-02T07:15:48Z

On Tue, 1 Oct 2024 14:21:59 -0700
Rosen Penev <rosenp@gmail.com> wrote:

> There seems to be a mistake here. There's a num_rx_qs variable that is not
> being passed to the allocation function. The mq variant just calls mqs
> with the last parameter of the former duplicated to the last parameter
> of the latter. That's fine if they match. Not sure they do.

As far as I can tell, both queue numbers used during the netdev alloc
are always the same, so this looks good to me.

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Thanks,

Maxime