Re: [PATCH v8 3/5] drm/panthor: add DRM fdinfo support

Boris Brezillon
2024-10-02T08:14:16Z

On Sun, 29 Sep 2024 08:25:38 +0800
kernel test robot <lkp@intel.com> wrote:

> Hi Adrián,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v6.11 next-20240927]
> [cannot apply to drm-misc/drm-misc-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Adri-n-Larumbe/drm-panthor-introduce-job-cycle-and-timestamp-accounting/20240924-071018
> base: linus/master
> patch link: https://lore.kernel.org/r/20240923230912.2207320-4-adrian.larumbe%40collabora.com
> patch subject: [PATCH v8 3/5] drm/panthor: add DRM fdinfo support
> config: arm-randconfig-002-20240929 (https://download.01.org/0day-ci/archive/20240929/202409291048.zLqDeqpO-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240929/202409291048.zLqDeqpO-lkp@intel.com/reproduce)

I gave this a try with Adrian's series applied on top of drm-misc-next,
and I couldn't reproduce the issue.

>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409291048.zLqDeqpO-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/math64.h:6,
> from include/linux/time.h:6,
> from include/linux/stat.h:19,
> from include/linux/module.h:13,
> from drivers/gpu/drm/panthor/panthor_drv.c:7:
> drivers/gpu/drm/panthor/panthor_drv.c: In function 'panthor_gpu_show_fdinfo':
> >> drivers/gpu/drm/panthor/panthor_drv.c:1389:45: error: implicit declaration of function 'arch_timer_get_cntfrq' [-Wimplicit-function-declaration]
> 1389 | arch_timer_get_cntfrq()));
> | ^~~~~~~~~~~~~~~~~~~~~
> include/linux/math.h:40:39: note: in definition of macro 'DIV_ROUND_DOWN_ULL'
> 40 | ({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; })
> | ^~
> drivers/gpu/drm/panthor/panthor_drv.c:1388:28: note: in expansion of macro 'DIV_ROUND_UP_ULL'
> 1388 | DIV_ROUND_UP_ULL((pfile->stats.time * NSEC_PER_SEC),
> | ^~~~~~~~~~~~~~~~
>
>
> vim +/arch_timer_get_cntfrq +1389 drivers/gpu/drm/panthor/panthor_drv.c
>
> 1377
> 1378 static void panthor_gpu_show_fdinfo(struct panthor_device *ptdev,
> 1379 struct panthor_file *pfile,
> 1380 struct drm_printer *p)
> 1381 {
> 1382 if (ptdev->profile_mask & PANTHOR_DEVICE_PROFILING_ALL)
> 1383 panthor_fdinfo_gather_group_samples(pfile);
> 1384
> 1385 if (ptdev->profile_mask & PANTHOR_DEVICE_PROFILING_TIMESTAMP) {
> 1386 #ifdef CONFIG_ARM_ARCH_TIMER
> 1387 drm_printf(p, "drm-engine-panthor:\t%llu ns\n",
> 1388 DIV_ROUND_UP_ULL((pfile->stats.time * NSEC_PER_SEC),
> > 1389 arch_timer_get_cntfrq()));
> 1390 #endif
> 1391 }
> 1392 if (ptdev->profile_mask & PANTHOR_DEVICE_PROFILING_CYCLES)
> 1393 drm_printf(p, "drm-cycles-panthor:\t%llu\n", pfile->stats.cycles);
> 1394
> 1395 drm_printf(p, "drm-maxfreq-panthor:\t%lu Hz\n", ptdev->fast_rate);
> 1396 drm_printf(p, "drm-curfreq-panthor:\t%lu Hz\n", ptdev->current_frequency);
> 1397 }
> 1398
>