From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CCB81FDD for ; Thu, 3 Oct 2024 00:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727914127; cv=none; b=Z9DiEMwxgBlbgaDZVmMFir5qI9Snh/3N0/2lgSD780eIffRFiCMlGjz7OtIfmf7yvbdHZQPNER0L7Zn9LYyhhrgCVZYeOseYovj3FtNweLP6RikQG7UajgB6qvkztXnsSO60QtiUSzNBW0aZ53/yPFh84yEC1YtK741X9ShWKVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727914127; c=relaxed/simple; bh=KUrfk+eq3257BUq5EaY4utlmEACyrb2EHZYgj/5cUlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hWejpqL2Rs5GmCGGAFGbRM0eY/LO1g2qCK5ghjAFRkzi9D7+cgz/HREUXIDwDfLLKF20G0oUziFDJFkGNpucEMyF0YPiJdUSKPle7y+mZ7vLu9I9xEZyZLF0EuLbKCXlxwxvFQqon9Q31K5ujvnU7+CqCIJOmpt0pq0Y6pFyxoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org; spf=pass smtp.mailfrom=joelfernandes.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b=K5yulx0I; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="K5yulx0I" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7a9a23fc16fso35974785a.2 for ; Wed, 02 Oct 2024 17:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1727914124; x=1728518924; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=d3cwmVH4T8IqaLZrJPf4dN6HB0iRJ3ayFzGdEtNHxoA=; b=K5yulx0Io0WDvodrDo4Y+tsYCP1+WoV1wVLw4cJZTcHcft4mlGDSFOm4qwLw9gKDXK 9rJD+i6u3JKlZbNOq9OVosgSrj/Vgf8bmvBZgJ1UEZPen9RQ/AZW0rH7ofVaT6uq9+rJ vdy6Efoen3boo7EvZKMwbV3e0I97Zoh6GHzmw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727914124; x=1728518924; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d3cwmVH4T8IqaLZrJPf4dN6HB0iRJ3ayFzGdEtNHxoA=; b=fs8XenMODWXSiCQnVWEyMLAXYSbvg69lNYkmldlklWd6FZXfj9Qkuc6nh3R/pNLdoc 7tIy251yr6yKz+Lk9nz77WrLiJRNb30kPvyyJQqYR4p47c29+r1m/f0yF8EYjVMT7zGv l3GHGn7oGpOYI+0pf+MGHn1n3YmB/iaNLSJ+0cIWEJxhChTUVh+kSlRfsL1i/b3wevWX 0/Y8oybau0src33EysQrD0F/0N7IpDKbXN5YrRBwjFDx3671GTHVetDWOQHHhS7k6dxc UNXBLW2v2wcLTDTmyUIaw1n9PCDRQ7gcxwrxwZjxddMX8Cg862SE55zmgoQixpeSjGMC bZ0w== X-Forwarded-Encrypted: i=1; AJvYcCV6lH2ZCeXJ5IbP+vWP5DvIl7cf6MBl5llsyD1dX/gvoFYiqu1algGX4gwWAgsKpfPKVg1dyqmPY7VVydU=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ92ZhQuXXby0bMjffP509aX7VcpsAbGwNKFFEPRMQvptw4XrO vjZTNjh1jIzEgmP+xxo54Jz5fyiYhyUTEHrClhp387ApTT4okWG6Pi8G1HnqMnk= X-Google-Smtp-Source: AGHT+IFyyGM2DUoFUWQ5HNQaWWB8/IaPvClgER78DCcGgoTY7+i7cDT8H5iX51KO9rlUJfwMgd+NTQ== X-Received: by 2002:a05:620a:2697:b0:7ac:dd3a:6787 with SMTP id af79cd13be357-7ae62732decmr738226785a.52.1727914124476; Wed, 02 Oct 2024 17:08:44 -0700 (PDT) Received: from localhost (129.177.85.34.bc.googleusercontent.com. [34.85.177.129]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae3783f80bsm669783585a.123.2024.10.02.17.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2024 17:08:43 -0700 (PDT) Date: Thu, 3 Oct 2024 00:08:43 +0000 From: Joel Fernandes To: Mathieu Desnoyers Cc: Linus Torvalds , Andrew Morton , Peter Zijlstra , linux-kernel@vger.kernel.org, Nicholas Piggin , Michael Ellerman , Greg Kroah-Hartman , Sebastian Andrzej Siewior , "Paul E. McKenney" , Will Deacon , Boqun Feng , Alan Stern , John Stultz , Neeraj Upadhyay , Frederic Weisbecker , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Lai Jiangshan , Zqiang , Ingo Molnar , Waiman Long , Mark Rutland , Thomas Gleixner , Vlastimil Babka , maged.michael@gmail.com, Mateusz Guzik , Jonas Oberhauser , rcu@vger.kernel.org, linux-mm@kvack.org, lkmm@lists.linux.dev, Gary Guo , Nikita Popov , llvm@lists.linux.dev Subject: Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency Message-ID: <20241003000843.GA192403@google.com> References: <20241002010205.1341915-1-mathieu.desnoyers@efficios.com> <20241002010205.1341915-2-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241002010205.1341915-2-mathieu.desnoyers@efficios.com> On Tue, Oct 01, 2024 at 09:02:02PM -0400, Mathieu Desnoyers wrote: > Compiler CSE and SSA GVN optimizations can cause the address dependency > of addresses returned by rcu_dereference to be lost when comparing those > pointers with either constants or previously loaded pointers. > > Introduce ptr_eq() to compare two addresses while preserving the address > dependencies for later use of the address. It should be used when > comparing an address returned by rcu_dereference(). > > This is needed to prevent the compiler CSE and SSA GVN optimizations > from using @a (or @b) in places where the source refers to @b (or @a) > based on the fact that after the comparison, the two are known to be > equal, which does not preserve address dependencies and allows the > following misordering speculations: > > - If @b is a constant, the compiler can issue the loads which depend > on @a before loading @a. > - If @b is a register populated by a prior load, weakly-ordered > CPUs can speculate loads which depend on @a before loading @a. > > The same logic applies with @a and @b swapped. > [...] > +/* > + * Compare two addresses while preserving the address dependencies for > + * later use of the address. It should be used when comparing an address > + * returned by rcu_dereference(). > + * > + * This is needed to prevent the compiler CSE and SSA GVN optimizations > + * from using @a (or @b) in places where the source refers to @b (or @a) > + * based on the fact that after the comparison, the two are known to be > + * equal, which does not preserve address dependencies and allows the > + * following misordering speculations: > + * > + * - If @b is a constant, the compiler can issue the loads which depend > + * on @a before loading @a. > + * - If @b is a register populated by a prior load, weakly-ordered > + * CPUs can speculate loads which depend on @a before loading @a. > + * > + * The same logic applies with @a and @b swapped. > + * > + * Return value: true if pointers are equal, false otherwise. > + * > + * The compiler barrier() is ineffective at fixing this issue. It does > + * not prevent the compiler CSE from losing the address dependency: > + * > + * int fct_2_volatile_barriers(void) > + * { > + * int *a, *b; > + * > + * do { > + * a = READ_ONCE(p); > + * asm volatile ("" : : : "memory"); > + * b = READ_ONCE(p); > + * } while (a != b); > + * asm volatile ("" : : : "memory"); <-- barrier() > + * return *b; > + * } > + * > + * With gcc 14.2 (arm64): > + * > + * fct_2_volatile_barriers: > + * adrp x0, .LANCHOR0 > + * add x0, x0, :lo12:.LANCHOR0 > + * .L2: > + * ldr x1, [x0] <-- x1 populated by first load. > + * ldr x2, [x0] > + * cmp x1, x2 > + * bne .L2 > + * ldr w0, [x1] <-- x1 is used for access which should depend on b. > + * ret > + * I could reproduce this in compiler explorer, but I'm curious what flags are you using? For me it does a bunch of usage of the stack for temporary storage (still incorrectly returns *a though as you pointed). Interestingly, if I just move the comparison into an an __always_inline__ function like below, but without the optimizer hide stuff, gcc 14.2 on arm64 does generate the correct code: static inline __attribute__((__always_inline__)) int ptr_eq(const volatile void *a, const volatile void *b) {     /* No OPTIMIZER_HIDE_VAR */     return a == b; } volatile int *p = 0; int fct_2_volatile_barriers() {     int *a, *b;     do {         a = READ_ONCE(p);         asm volatile ("" : : : "memory");         b = READ_ONCE(p);     } while (!ptr_eq(a, b));     asm volatile ("" : : : "memory");  // barrier()     return *b; } But not sure if it fixes the speculation issue you referred to. Putting back the OPTIMIZER_HIDE_VAR() then just seems to pass the a and b stored on the stack through a washing machine:         ldr     x0, [sp, 8]         str     x0, [sp, 8]         ldr     x0, [sp]         str     x0, [sp] And here I thought the "" in OPTIMIZER_HIDE_VAR was not supposed to generate any code but I guess it is still a NOOP. Anyway, as such this LGTM since whether OPTIMIZER_HIDE_VAR() used or not, it does fix the problem. Reviewed-by: Joel Fernandes (Google) thanks, - Joel