From: "Markku Ahvenjärvi" <mankku@gmail.com>
To: seanjc@google.com
Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
janne.karhunen@gmail.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mankku@gmail.com, mingo@redhat.com,
pbonzini@redhat.com, tglx@linutronix.de, x86@kernel.org
Subject: Re: [PATCH 1/1] KVM: nVMX: update VPPR on vmlaunch/vmresume
Date: Thu, 3 Oct 2024 14:29:25 +0300 [thread overview]
Message-ID: <20241003113050.22875-1-mankku@gmail.com> (raw)
In-Reply-To: <Zv2Ay9Y3TswTwW_B@google.com>
Hi Sean,
> Talking to myself :-)
A good monologue. :)
As you said, PPR is updated constantly with kvm_vcpu_has_events() anyways.
Actually implicit updates, especially in kvm_apic_has_interrupt(), makes it a
bit difficult to follow when these updates take place. It is quite easy to
accidentally make an update in architecturally incorrect place. Could be
useful to make it explicit.
> Assuming it actually fixes your issue, this is what I'm planning on posting. I
> suspect KVM botches something when the deprivileged host is active, but given
> that the below will allow for additional cleanups, and practically speaking doesn't
> have any downsides, I don't see any reason to withhold the hack-a-fix. Though
> hopefully we'll someday figure out exactly what's broken.
It fixes the issue. Thanks a lot Sean!
Kind regards,
Markku
next prev parent reply other threads:[~2024-10-03 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 7:59 [PATCH 0/1] KVM: nVMX: update VPPR on vmlaunch/vmresume Markku Ahvenjärvi
2024-09-20 7:59 ` [PATCH 1/1] " Markku Ahvenjärvi
2024-09-20 8:18 ` Sean Christopherson
2024-09-20 12:40 ` Markku Ahvenjärvi
2024-10-02 12:42 ` Markku Ahvenjärvi
2024-10-02 15:52 ` Sean Christopherson
2024-10-02 16:49 ` Sean Christopherson
2024-10-02 17:20 ` Sean Christopherson
2024-10-03 11:29 ` Markku Ahvenjärvi [this message]
2024-10-10 11:00 ` Chao Gao
2024-10-14 10:57 ` Markku Ahvenjärvi
2024-10-16 18:54 ` Sean Christopherson
2024-10-17 13:27 ` Chao Gao
2024-10-17 16:05 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003113050.22875-1-mankku@gmail.com \
--to=mankku@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=janne.karhunen@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox