* [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE
@ 2024-10-03 23:07 Miguel Ojeda
2024-10-04 7:14 ` Jocelyn Falempe
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2024-10-03 23:07 UTC (permalink / raw)
To: Jocelyn Falempe, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann
Cc: dri-devel, linux-kernel, patches, Miguel Ojeda
Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
ld.lld: error: undefined symbol: zlib_deflate_workspacesize
>>> referenced by drm_panic.c
>>> drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init) in archive vmlinux.a
Thus select `CONFIG_ZLIB_DEFLATE`.
Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
drivers/gpu/drm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 1cb5a4f19293..cf5bc77e2362 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -152,6 +152,7 @@ config DRM_PANIC_SCREEN
config DRM_PANIC_SCREEN_QR_CODE
bool "Add a panic screen with a QR code"
depends on DRM_PANIC && RUST
+ select ZLIB_DEFLATE
help
This option adds a QR code generator, and a panic screen with a QR
code. The QR code will contain the last lines of kmsg and other debug
--
2.46.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE
2024-10-03 23:07 [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE Miguel Ojeda
@ 2024-10-04 7:14 ` Jocelyn Falempe
2024-10-14 12:48 ` Jocelyn Falempe
0 siblings, 1 reply; 3+ messages in thread
From: Jocelyn Falempe @ 2024-10-04 7:14 UTC (permalink / raw)
To: Miguel Ojeda, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann
Cc: dri-devel, linux-kernel, patches
On 04/10/2024 01:07, Miguel Ojeda wrote:
> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
>
> ld.lld: error: undefined symbol: zlib_deflate_workspacesize
> >>> referenced by drm_panic.c
> >>> drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init) in archive vmlinux.a
>
> Thus select `CONFIG_ZLIB_DEFLATE`.
Hi, good catch, yes it should select the zlib deflate.
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Best regards,
--
Jocelyn
>
> Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> drivers/gpu/drm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 1cb5a4f19293..cf5bc77e2362 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -152,6 +152,7 @@ config DRM_PANIC_SCREEN
> config DRM_PANIC_SCREEN_QR_CODE
> bool "Add a panic screen with a QR code"
> depends on DRM_PANIC && RUST
> + select ZLIB_DEFLATE
> help
> This option adds a QR code generator, and a panic screen with a QR
> code. The QR code will contain the last lines of kmsg and other debug
> --
> 2.46.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE
2024-10-04 7:14 ` Jocelyn Falempe
@ 2024-10-14 12:48 ` Jocelyn Falempe
0 siblings, 0 replies; 3+ messages in thread
From: Jocelyn Falempe @ 2024-10-14 12:48 UTC (permalink / raw)
To: Miguel Ojeda, David Airlie, Simona Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann
Cc: dri-devel, linux-kernel, patches
On 04/10/2024 09:14, Jocelyn Falempe wrote:
> On 04/10/2024 01:07, Miguel Ojeda wrote:
>> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
>>
>> ld.lld: error: undefined symbol: zlib_deflate_workspacesize
>> >>> referenced by drm_panic.c
>> >>> drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init)
>> in archive vmlinux.a
>>
>> Thus select `CONFIG_ZLIB_DEFLATE`.
>
> Hi, good catch, yes it should select the zlib deflate.
>
> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
I've just pushed it to drm-misc-next.
Thanks for your contribution.
--
Jocelyn
>
> Best regards,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-14 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-03 23:07 [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR_CODE Miguel Ojeda
2024-10-04 7:14 ` Jocelyn Falempe
2024-10-14 12:48 ` Jocelyn Falempe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).