From: Jonas Gorski <jonas.gorski@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Murali Krishna Policharla <murali.policharla@broadcom.com>,
Russell King <linux@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/5] net: dsa: b53: fix jumbo frames on 10/100 ports
Date: Fri, 04 Oct 2024 10:47:21 +0200 [thread overview]
Message-ID: <20241004-b53_jumbo_fixes-v1-5-ce1e54aa7b3c@gmail.com> (raw)
In-Reply-To: <20241004-b53_jumbo_fixes-v1-0-ce1e54aa7b3c@gmail.com>
All modern chips support and need the 10_100 bit set for supporting jumbo
frames on 10/100 ports, so instead of enabling it only for 583XX enable
it for everything except bcm63xx, where the bit is writeable, but does
nothing.
Tested on BCM53115, where jumbo frames were dropped at 10/100 speeds
without the bit set.
Fixes: 6ae5834b983a ("net: dsa: b53: add MTU configuration support")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
drivers/net/dsa/b53/b53_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index 5b83f9b6cdac3de6c5e6e2164c78146d694674cd..c39cb119e760db5fcbfaaf44abe033f6977e7005 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -2264,7 +2264,7 @@ static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu)
return 0;
enable_jumbo = (mtu > ETH_DATA_LEN);
- allow_10_100 = (dev->chip_id == BCM583XX_DEVICE_ID);
+ allow_10_100 = !is63xx(dev);
return b53_set_jumbo(dev, enable_jumbo, allow_10_100);
}
--
2.43.0
next prev parent reply other threads:[~2024-10-04 8:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 8:47 [PATCH 0/5] net: dsa: b53: assorted jumbo frame fixes Jonas Gorski
2024-10-04 8:47 ` [PATCH 1/5] net: dsa: b53: fix jumbo frame mtu check Jonas Gorski
2024-10-05 3:38 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 2/5] net: dsa: b53: fix max MTU for 1g switches Jonas Gorski
2024-10-05 3:38 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 3/5] net: dsa: b53: fix max MTU for BCM5325/BCM5365 Jonas Gorski
2024-10-05 3:39 ` Florian Fainelli
2024-10-04 8:47 ` [PATCH 4/5] net: dsa: b53: allow lower MTUs on BCM5325/5365 Jonas Gorski
2024-10-05 3:39 ` Florian Fainelli
2024-10-04 8:47 ` Jonas Gorski [this message]
2024-10-05 3:40 ` [PATCH 5/5] net: dsa: b53: fix jumbo frames on 10/100 ports Florian Fainelli
2024-10-08 8:50 ` [PATCH 0/5] net: dsa: b53: assorted jumbo frame fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004-b53_jumbo_fixes-v1-5-ce1e54aa7b3c@gmail.com \
--to=jonas.gorski@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=murali.policharla@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox