linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] brcmfmac: Remove unused brcmf_cfg80211_get_iftype
@ 2024-10-04  0:42 linux
  2024-10-17 16:49 ` wifi: brcmfmac: Remove unused brcmf_cfg80211_get_iftype() Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2024-10-04  0:42 UTC (permalink / raw)
  To: arend.vanspriel, kvalo, linux-wireless
  Cc: brcm80211, brcm80211-dev-list.pdl, linux-kernel,
	Dr. David Alan Gilbert

From: "Dr. David Alan Gilbert" <linux@treblig.org>

brcmf_cfg80211_get_iftype() has been unused since 2013's commit
5cd51c2bad56 ("brcmfmac: Find correct MAC descriptor in case of TDLS.")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 7 -------
 .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h    | 1 -
 2 files changed, 8 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 349aa3439502..297a7c738c01 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -7820,13 +7820,6 @@ s32 brcmf_cfg80211_down(struct net_device *ndev)
 	return err;
 }
 
-enum nl80211_iftype brcmf_cfg80211_get_iftype(struct brcmf_if *ifp)
-{
-	struct wireless_dev *wdev = &ifp->vif->wdev;
-
-	return wdev->iftype;
-}
-
 bool brcmf_get_vif_state_any(struct brcmf_cfg80211_info *cfg,
 			     unsigned long state)
 {
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
index dc3a6a537507..2abae8894614 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
@@ -443,7 +443,6 @@ void brcmf_cfg80211_detach(struct brcmf_cfg80211_info *cfg);
 s32 brcmf_cfg80211_up(struct net_device *ndev);
 s32 brcmf_cfg80211_down(struct net_device *ndev);
 struct cfg80211_ops *brcmf_cfg80211_get_ops(struct brcmf_mp_device *settings);
-enum nl80211_iftype brcmf_cfg80211_get_iftype(struct brcmf_if *ifp);
 
 struct brcmf_cfg80211_vif *brcmf_alloc_vif(struct brcmf_cfg80211_info *cfg,
 					   enum nl80211_iftype type);
-- 
2.46.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: wifi: brcmfmac: Remove unused brcmf_cfg80211_get_iftype()
  2024-10-04  0:42 [PATCH] brcmfmac: Remove unused brcmf_cfg80211_get_iftype linux
@ 2024-10-17 16:49 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2024-10-17 16:49 UTC (permalink / raw)
  To: linux
  Cc: arend.vanspriel, linux-wireless, brcm80211,
	brcm80211-dev-list.pdl, linux-kernel, Dr. David Alan Gilbert

linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> brcmf_cfg80211_get_iftype() has been unused since 2013's commit
> 5cd51c2bad56 ("brcmfmac: Find correct MAC descriptor in case of TDLS.")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Patch applied to wireless-next.git, thanks.

e2e25113473b wifi: brcmfmac: Remove unused brcmf_cfg80211_get_iftype()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20241004004252.470836-1-linux@treblig.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-17 16:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04  0:42 [PATCH] brcmfmac: Remove unused brcmf_cfg80211_get_iftype linux
2024-10-17 16:49 ` wifi: brcmfmac: Remove unused brcmf_cfg80211_get_iftype() Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).