linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manuel Quintero F <sakunix@yahoo.com>
To: duncan.sands@free.fr
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Manuel Quintero F <sakunix@yahoo.com>
Subject: [PATCH] USB: atm: speedtch: do not use assignment in if condition
Date: Thu,  3 Oct 2024 20:05:12 -0700	[thread overview]
Message-ID: <20241004030512.2036-1-sakunix@yahoo.com> (raw)
In-Reply-To: 20241004030512.2036-1-sakunix.ref@yahoo.com

Fix checkpatch error "do not use assignment in if condition"

Signed-off-by: Manuel Quintero F <sakunix@yahoo.com>
Signed-off-by: Manuel Quintero F <sakunix@yahoo.com>
---
 drivers/usb/atm/speedtch.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c
index 973548b5c15c..dfd362abf602 100644
--- a/drivers/usb/atm/speedtch.c
+++ b/drivers/usb/atm/speedtch.c
@@ -324,7 +324,9 @@ static int speedtch_upload_firmware(struct speedtch_instance_data *instance,
 	   because we're in our own kernel thread anyway. */
 	msleep_interruptible(1000);
 
-	if ((ret = usb_set_interface(usb_dev, INTERFACE_DATA, instance->params.altsetting)) < 0) {
+	ret = usb_set_interface(usb_dev, INTERFACE_DATA, instance->params.altsetting
+
+	if (ret < 0) {
 		usb_err(usbatm, "%s: setting interface to %d failed (%d)!\n", __func__, instance->params.altsetting, ret);
 		goto out_free;
 	}
-- 
2.45.2


       reply	other threads:[~2024-10-04  3:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241004030512.2036-1-sakunix.ref@yahoo.com>
2024-10-04  3:05 ` Manuel Quintero F [this message]
2024-10-04  6:20   ` [PATCH] USB: atm: speedtch: do not use assignment in if condition Greg KH
2024-10-05  9:50   ` kernel test robot
2024-10-05  9:50   ` kernel test robot
2024-10-05 10:11   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004030512.2036-1-sakunix@yahoo.com \
    --to=sakunix@yahoo.com \
    --cc=duncan.sands@free.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).