From: joeyli <jlee@suse.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Justin Sanders <justin@coraid.com>,
Chun-Yi Lee <joeyli.kernel@gmail.com>,
Pavel Emelianov <xemul@openvz.org>,
Kirill Korotaev <dev@openvz.org>,
"David S . Miller" <davem@davemloft.net>,
Nicolai Stange <nstange@suse.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] aoe: fix the potential use-after-free problem in more places
Date: Fri, 4 Oct 2024 15:42:21 +0800 [thread overview]
Message-ID: <20241004074221.GK3296@linux-l9pv.suse> (raw)
In-Reply-To: <172787504822.64996.12000204584360248821.b4-ty@kernel.dk>
Hi Jens,
On Wed, Oct 02, 2024 at 07:17:28AM -0600, Jens Axboe wrote:
>
> On Wed, 02 Oct 2024 11:54:58 +0800, Chun-Yi Lee wrote:
> > For fixing CVE-2023-6270, f98364e92662 ("aoe: fix the potential
> > use-after-free problem in aoecmd_cfg_pkts") makes tx() calling dev_put()
> > instead of doing in aoecmd_cfg_pkts(). It avoids that the tx() runs
> > into use-after-free.
> >
> > Then Nicolai Stange found more places in aoe have potential use-after-free
> > problem with tx(). e.g. revalidate(), aoecmd_ata_rw(), resend(), probe()
> > and aoecmd_cfg_rsp(). Those functions also use aoenet_xmit() to push
> > packet to tx queue. So they should also use dev_hold() to increase the
> > refcnt of skb->dev.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] aoe: fix the potential use-after-free problem in more places
> commit: 6d6e54fc71ad1ab0a87047fd9c211e75d86084a3
>
Thanks for your review!
Joey Lee
prev parent reply other threads:[~2024-10-04 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 3:54 [PATCH v3] aoe: fix the potential use-after-free problem in more places Chun-Yi Lee
2024-10-02 6:50 ` Greg KH
2024-10-02 13:17 ` Jens Axboe
2024-10-04 7:42 ` joeyli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004074221.GK3296@linux-l9pv.suse \
--to=jlee@suse.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dev@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=joeyli.kernel@gmail.com \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nstange@suse.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox