From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041F013BACB for ; Fri, 4 Oct 2024 07:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728028371; cv=none; b=fRP74ztLODVnAVk6JDxWnYWvjDmZ9jKtx9uKUhJ2z3XkSqtbK6CesPdJ0jg2aOhGrWJgP30JtuBddtZVHRRkIfXLApwfDUYeoifLeUhnzKtGan79aFNcKR4sx0hXyv2h5SLNyi6udaJaH4MzdOqsEIRIA2QusM9VITVAliOt3/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728028371; c=relaxed/simple; bh=CgrY0CfBLm/Lv7oKpW3zMYd1YEIHB0kEzF3/d0trJHY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A9UK3M8AvEJVn2JAmhUwAcLh7bT/Jf6lps5C8RRGUqV5TZosbtsqV7kOLNzxiwLrk5I/jDQpIExWSQwb9hqkve49gw4tmX9wYz9YedDkBFEMCKbUtYA0smH+SFSYCDJir/UOO+Dzb9J1oikELbdgQzUiLl8jBrYRrpFANOso4Dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SqaiBavG; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SqaiBavG" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2fac3f1287bso21468031fa.1 for ; Fri, 04 Oct 2024 00:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1728028364; x=1728633164; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=nCmr2NzFsgxtVcm+KzzvEFNxYTpPvNbNNxLvpB5hrI8=; b=SqaiBavGPkKEQUTMyvd+aClushIV9GGRU28ITkgBr6ymQLbOmNPUpm5EbVHh69Eo4t 9XN/gEn/97Q3IrOuFEiaDw9nN4tFFQIgbmMuGXYXp9zPqMmjK8GO/ONXoWVJKdbiEd81 7Zh7ioqQk1hp58Byfbsp0LPniP6jJngwHbIi3I5Mi4wkIix8Hrrqmx0Eq4BenFdPqqZG WRZiDiUF75tWMqvgrahZUEmyymE4Yf7QZfp38pLFPbYEbJgoaAQX5bCy45Gp5a7vOwZs BReu68jbCLrAiLPKanG9rEnjpsp1QII/qs2CBrIvBi0ZQP+GCPcTCPLs4m+XK0TX3mQg MGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728028364; x=1728633164; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nCmr2NzFsgxtVcm+KzzvEFNxYTpPvNbNNxLvpB5hrI8=; b=dPLyOWQMKB1LczbxrVJZU+Db4LKuHkxW0jj8orQ/m0htukW+8fFtc0FobxWNmZQTJZ vhTfYQ1bf1jPBqoj1iMJnrjDnl4vRXFViFtOWRTNug3P32xpPBsZyDqK4wbDy4qzebax IjacjQm87cye3U0aylZLOkxngf+0S1hmJMXKlF7pAfQkyxWwRvJ7T6GW8mLtTtfwrbnC zoyGyy9glCTyBoZDqGgDLEaZws6hPrFfm3TOEyVBHt3lfDO+5u1Mc3NZvtuM8o/8zffa ByQ1xMuMXHjaaOU3+HjaIrhYlQnxTYHeF/R61RisKEuogKspdjPJO39BSqF5JGLUgV/t l9/w== X-Forwarded-Encrypted: i=1; AJvYcCWpWPp05IjJNY7W/g1mGeVOLBSI9eXPMKk1QDh8+5JRwNreusRZhGbkPQPEYeXqeZYcYdzTYWFlS//Su4c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0teB5rm4gctN70ocuzamcGjL6QlVODclHFCwBe9GrvTn9AfVm PhoKjH9Ed/tgh5e3wuw3FmH5JyNxGMWQYLHkLVJH0conVxN68Y/Lkii/JKrmR6I= X-Google-Smtp-Source: AGHT+IE76QOCeJJ5ofZlvzBk7neiRJtspXeFIE3aYgejhCS89B2VGNTiw1f3BSY3t9L6R7QL9AYttQ== X-Received: by 2002:a2e:f1a:0:b0:2fa:d84a:bda1 with SMTP id 38308e7fff4ca-2faf3c1439dmr7645161fa.10.1728028363509; Fri, 04 Oct 2024 00:52:43 -0700 (PDT) Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9dbc441b5sm2035252a12.0.2024.10.04.00.52.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2024 00:52:43 -0700 (PDT) Date: Fri, 4 Oct 2024 15:52:39 +0800 From: joeyli To: Damien Le Moal Cc: Chun-Yi Lee , Justin Sanders , Jens Axboe , Pavel Emelianov , Kirill Korotaev , "David S . Miller" , Nicolai Stange , Greg KH , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/2] aoe: using wrappers instead of dev_hold/dev_put for tracking the references of net_device in aoeif Message-ID: <20241004075239.GL3296@linux-l9pv.suse> References: <20241002040616.25193-1-jlee@suse.com> <20241002040616.25193-3-jlee@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Hi Damien, On Wed, Oct 02, 2024 at 02:37:12PM +0900, Damien Le Moal wrote: > On 10/2/24 1:06 PM, Chun-Yi Lee wrote: > > Signed-off-by: Chun-Yi Lee > > The wrappers where introduced in patch 1 without any user. So it seems that > this patch should be squashed together with patch 1. > I separated this two patches because the second one is base on another patch '[PATCH v3] aoe: fix the potential use-after-free problem in more places'. Now that patch be accepted by Jens: https://www.spinics.net/lists/kernel/msg5384787.html According this, I will merge this patch with the 'PATCH 1' in next version. Thanks for your review and suggestion! Joey Lee