* [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts
@ 2024-10-04 7:52 Aaron Thompson
2024-10-04 17:14 ` Nathan Chancellor
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aaron Thompson @ 2024-10-04 7:52 UTC (permalink / raw)
To: Masahiro Yamada, Nathan Chancellor, Nicolas Schier, linux-kbuild,
linux-kernel
Cc: Aaron Thompson
From: Aaron Thompson <dev@aaront.org>
The blank line causes execve() to fail:
# strace ./postinst
execve("./postinst", ...) = -1 ENOEXEC (Exec format error)
strace: exec: Exec format error
+++ exited with 1 +++
However running the scripts via shell does work (at least with bash)
because the shell attempts to execute the file as a shell script when
execve() fails.
Fixes: b611daae5efc ("kbuild: deb-pkg: split image and debug objects staging out into functions")
Signed-off-by: Aaron Thompson <dev@aaront.org>
---
scripts/package/builddeb | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index c1757db6aa8a..404587fc71fe 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -74,7 +74,6 @@ install_linux_image () {
mkdir -p "${pdir}/DEBIAN"
cat <<-EOF > "${pdir}/DEBIAN/${script}"
-
#!/bin/sh
set -e
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts
2024-10-04 7:52 [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts Aaron Thompson
@ 2024-10-04 17:14 ` Nathan Chancellor
2024-10-04 18:46 ` Nicolas Schier
2024-10-06 17:24 ` Masahiro Yamada
2 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2024-10-04 17:14 UTC (permalink / raw)
To: Aaron Thompson
Cc: Masahiro Yamada, Nicolas Schier, linux-kbuild, linux-kernel
On Fri, Oct 04, 2024 at 07:52:45AM +0000, Aaron Thompson wrote:
> From: Aaron Thompson <dev@aaront.org>
>
> The blank line causes execve() to fail:
>
> # strace ./postinst
> execve("./postinst", ...) = -1 ENOEXEC (Exec format error)
> strace: exec: Exec format error
> +++ exited with 1 +++
>
> However running the scripts via shell does work (at least with bash)
> because the shell attempts to execute the file as a shell script when
> execve() fails.
>
> Fixes: b611daae5efc ("kbuild: deb-pkg: split image and debug objects staging out into functions")
> Signed-off-by: Aaron Thompson <dev@aaront.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> scripts/package/builddeb | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c1757db6aa8a..404587fc71fe 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -74,7 +74,6 @@ install_linux_image () {
>
> mkdir -p "${pdir}/DEBIAN"
> cat <<-EOF > "${pdir}/DEBIAN/${script}"
> -
> #!/bin/sh
>
> set -e
>
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts
2024-10-04 7:52 [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts Aaron Thompson
2024-10-04 17:14 ` Nathan Chancellor
@ 2024-10-04 18:46 ` Nicolas Schier
2024-10-06 17:24 ` Masahiro Yamada
2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Schier @ 2024-10-04 18:46 UTC (permalink / raw)
To: Aaron Thompson
Cc: Masahiro Yamada, Nathan Chancellor, linux-kbuild, linux-kernel
On Fri, Oct 04, 2024 at 07:52:45AM +0000, Aaron Thompson wrote:
> From: Aaron Thompson <dev@aaront.org>
>
> The blank line causes execve() to fail:
>
> # strace ./postinst
> execve("./postinst", ...) = -1 ENOEXEC (Exec format error)
> strace: exec: Exec format error
> +++ exited with 1 +++
>
> However running the scripts via shell does work (at least with bash)
> because the shell attempts to execute the file as a shell script when
> execve() fails.
>
> Fixes: b611daae5efc ("kbuild: deb-pkg: split image and debug objects staging out into functions")
> Signed-off-by: Aaron Thompson <dev@aaront.org>
> ---
> scripts/package/builddeb | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c1757db6aa8a..404587fc71fe 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -74,7 +74,6 @@ install_linux_image () {
>
> mkdir -p "${pdir}/DEBIAN"
> cat <<-EOF > "${pdir}/DEBIAN/${script}"
> -
> #!/bin/sh
>
> set -e
>
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> --
> 2.39.5
>
Thanks.
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts
2024-10-04 7:52 [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts Aaron Thompson
2024-10-04 17:14 ` Nathan Chancellor
2024-10-04 18:46 ` Nicolas Schier
@ 2024-10-06 17:24 ` Masahiro Yamada
2 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2024-10-06 17:24 UTC (permalink / raw)
To: Aaron Thompson
Cc: Nathan Chancellor, Nicolas Schier, linux-kbuild, linux-kernel
On Fri, Oct 4, 2024 at 4:54 PM Aaron Thompson <dev@aaront.org> wrote:
>
> From: Aaron Thompson <dev@aaront.org>
>
> The blank line causes execve() to fail:
>
> # strace ./postinst
> execve("./postinst", ...) = -1 ENOEXEC (Exec format error)
> strace: exec: Exec format error
> +++ exited with 1 +++
>
> However running the scripts via shell does work (at least with bash)
> because the shell attempts to execute the file as a shell script when
> execve() fails.
>
> Fixes: b611daae5efc ("kbuild: deb-pkg: split image and debug objects staging out into functions")
> Signed-off-by: Aaron Thompson <dev@aaront.org>
> ---
Applied to linux-kbuild.
Thanks.
> scripts/package/builddeb | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index c1757db6aa8a..404587fc71fe 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -74,7 +74,6 @@ install_linux_image () {
>
> mkdir -p "${pdir}/DEBIAN"
> cat <<-EOF > "${pdir}/DEBIAN/${script}"
> -
> #!/bin/sh
>
> set -e
>
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> --
> 2.39.5
>
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-06 17:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 7:52 [PATCH] kbuild: deb-pkg: Remove blank first line from maint scripts Aaron Thompson
2024-10-04 17:14 ` Nathan Chancellor
2024-10-04 18:46 ` Nicolas Schier
2024-10-06 17:24 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox