From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Ying Sun <sunying@isrc.iscas.ac.cn>,
Petr Tesarik <petr@tesarici.cz>,
Andrew Jones <ajones@ventanamicro.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Sasha Levin <sashal@kernel.org>,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, akpm@linux-foundation.org, bhe@redhat.com,
kent.overstreet@linux.dev, pasha.tatashin@soleen.com,
surenb@google.com, linux-riscv@lists.infradead.org
Subject: [PATCH AUTOSEL 6.10 40/70] riscv/kexec_file: Fix relocation type R_RISCV_ADD16 and R_RISCV_SUB16 unknown
Date: Fri, 4 Oct 2024 14:20:38 -0400 [thread overview]
Message-ID: <20241004182200.3670903-40-sashal@kernel.org> (raw)
In-Reply-To: <20241004182200.3670903-1-sashal@kernel.org>
From: Ying Sun <sunying@isrc.iscas.ac.cn>
[ Upstream commit c6ebf2c528470a09be77d0d9df2c6617ea037ac5 ]
Runs on the kernel with CONFIG_RISCV_ALTERNATIVE enabled:
kexec -sl vmlinux
Error:
kexec_image: Unknown rela relocation: 34
kexec_image: Error loading purgatory ret=-8
and
kexec_image: Unknown rela relocation: 38
kexec_image: Error loading purgatory ret=-8
The purgatory code uses the 16-bit addition and subtraction relocation
type, but not handled, resulting in kexec_file_load failure.
So add handle to arch_kexec_apply_relocations_add().
Tested on RISC-V64 Qemu-virt, issue fixed.
Co-developed-by: Petr Tesarik <petr@tesarici.cz>
Signed-off-by: Petr Tesarik <petr@tesarici.cz>
Signed-off-by: Ying Sun <sunying@isrc.iscas.ac.cn>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20240711083236.2859632-1-sunying@isrc.iscas.ac.cn
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/riscv/kernel/elf_kexec.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/riscv/kernel/elf_kexec.c b/arch/riscv/kernel/elf_kexec.c
index 11c0d2e0becfe..3c37661801f95 100644
--- a/arch/riscv/kernel/elf_kexec.c
+++ b/arch/riscv/kernel/elf_kexec.c
@@ -451,6 +451,12 @@ int arch_kexec_apply_relocations_add(struct purgatory_info *pi,
*(u32 *)loc = CLEAN_IMM(CJTYPE, *(u32 *)loc) |
ENCODE_CJTYPE_IMM(val - addr);
break;
+ case R_RISCV_ADD16:
+ *(u16 *)loc += val;
+ break;
+ case R_RISCV_SUB16:
+ *(u16 *)loc -= val;
+ break;
case R_RISCV_ADD32:
*(u32 *)loc += val;
break;
--
2.43.0
next prev parent reply other threads:[~2024-10-04 18:23 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 18:19 [PATCH AUTOSEL 6.10 01/70] bpf: Call the missed btf_record_free() when map creation fails Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 02/70] selftests/bpf: Fix ARG_PTR_TO_LONG {half-,}uninitialized test Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 03/70] bpf: Fix a sdiv overflow issue Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 04/70] bpf: Check percpu map value size first Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 05/70] bpftool: Fix undefined behavior in qsort(NULL, 0, ...) Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 06/70] bpftool: Fix undefined behavior caused by shifting into the sign bit Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 07/70] s390/boot: Compile all files with the same march flag Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 08/70] s390/facility: Disable compile time optimization for decompressor code Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 09/70] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 10/70] bpf, x64: Fix a jit convergence issue Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 11/70] ext4: fix i_data_sem unlock order in ext4_ind_migrate() Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 12/70] ext4: avoid use-after-free in ext4_ext_show_leaf() Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 13/70] ext4: ext4_search_dir should return a proper error Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 14/70] iomap: fix iomap_dio_zero() for fs bs > system page size Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 15/70] ext4: don't set SB_RDONLY after filesystem errors Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 16/70] ext4: nested locking for xattr inode Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 17/70] s390/cpum_sf: Remove WARN_ON_ONCE statements Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 18/70] s390/traps: Handle early warnings gracefully Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 19/70] bpf: Prevent tail call between progs attached to different hooks Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 20/70] ktest.pl: Avoid false positives with grub2 skip regex Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 21/70] RDMA/mad: Improve handling of timed out WRs of mad agent Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 22/70] soundwire: intel_bus_common: enable interrupts before exiting reset Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 23/70] PCI: Add function 0 DMA alias quirk for Glenfly Arise chip Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 24/70] RDMA/rtrs-srv: Avoid null pointer deref during path establishment Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 25/70] clk: bcm: bcm53573: fix OF node leak in init Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 26/70] PCI: Add ACS quirk for Qualcomm SA8775P Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 27/70] i2c: i801: Use a different adapter-name for IDF adapters Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 28/70] PCI: Mark Creative Labs EMU20k2 INTx masking as broken Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 29/70] i3c: master: cdns: Fix use after free vulnerability in cdns_i3c_master Driver Due to Race Condition Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 30/70] RISC-V: Don't have MAX_PHYSMEM_BITS exceed phys_addr_t Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 31/70] io_uring: check if we need to reschedule during overflow flush Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 32/70] ntb: ntb_hw_switchtec: Fix use after free vulnerability in switchtec_ntb_remove due to race condition Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 33/70] mfd: intel_soc_pmic_chtwc: Make Lenovo Yoga Tab 3 X90F DMI match less strict Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 34/70] riscv: Omit optimized string routines when using KASAN Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 35/70] riscv: avoid Imbalance in RAS Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 36/70] RDMA/mlx5: Enforce umem boundaries for explicit ODP page faults Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 37/70] PCI: qcom: Disable mirroring of DBI and iATU register space in BAR region Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 38/70] PCI: endpoint: Assign PCI domain number for endpoint controllers Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 39/70] soundwire: cadence: re-check Peripheral status with delayed_work Sasha Levin
2024-10-04 18:20 ` Sasha Levin [this message]
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 41/70] media: videobuf2-core: clear memory related fields in __vb2_plane_dmabuf_put() Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 42/70] remoteproc: imx_rproc: Use imx specific hook for find_loaded_rsc_table Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 43/70] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 44/70] fuse: allow O_PATH fd for FUSE_DEV_IOC_BACKING_OPEN Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 45/70] fuse: handle idmappings properly in ->write_iter() Sasha Levin
2024-10-07 10:05 ` Miklos Szeredi
2024-10-11 13:50 ` Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 46/70] serial: protect uart_port_dtr_rts() in uart_shutdown() too Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 47/70] usb: typec: tipd: Free IRQ only if it was requested before Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 48/70] usb: chipidea: udc: enable suspend interrupt after usb reset Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 49/70] usb: dwc2: Adjust the timing of USB Driver Interrupt Registration in the Crashkernel Scenario Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 50/70] xhci: dbc: Fix STALL transfer event handling Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 51/70] comedi: ni_routing: tools: Check when the file could not be opened Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 52/70] LoongArch: Fix memleak in pci_acpi_scan_root() Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 53/70] netfilter: nf_nat: don't try nat source port reallocation for reverse dir clash Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 54/70] netfilter: nf_reject: Fix build warning when CONFIG_BRIDGE_NETFILTER=n Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 55/70] virtio_pmem: Check device status before requesting flush Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 56/70] tools/iio: Add memory allocation failure check for trigger_name Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 57/70] staging: vme_user: added bound check to geoid Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 58/70] usb: gadget: uvc: Fix ERR_PTR dereference in uvc_v4l2.c Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 59/70] dm vdo: don't refer to dedupe_context after releasing it Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 60/70] driver core: bus: Fix double free in driver API bus_register() Sasha Levin
2024-10-04 18:20 ` [PATCH AUTOSEL 6.10 61/70] driver core: bus: Return -EIO instead of 0 when show/store invalid bus attribute Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 62/70] scsi: lpfc: Add ELS_RSP cmd to the list of WQEs to flush in lpfc_els_flush_cmd() Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 63/70] scsi: lpfc: Ensure DA_ID handling completion before deleting an NPIV instance Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 64/70] scsi: lpfc: Revise TRACE_EVENT log flag severities from KERN_ERR to KERN_WARNING Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 65/70] drm/xe/oa: Fix overflow in oa batch buffer Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 66/70] drm/amdgpu: nuke the VM PD/PT shadow handling Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 67/70] drm/amd/display: Check null pointer before dereferencing se Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 68/70] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 69/70] smb: client: fix UAF in async decryption Sasha Levin
2024-10-04 18:21 ` [PATCH AUTOSEL 6.10 70/70] fbdev: sisfb: Fix strbuf array overflow Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004182200.3670903-40-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhe@redhat.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=pasha.tatashin@soleen.com \
--cc=paul.walmsley@sifive.com \
--cc=petr@tesarici.cz \
--cc=stable@vger.kernel.org \
--cc=sunying@isrc.iscas.ac.cn \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox