From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34BA01DF756; Fri, 4 Oct 2024 18:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066615; cv=none; b=iEPBYvCemKfMYChZR5VPj1ZV0dnJxzD3/JNg7r/Y+zMlfR4Zy/jyNn3/gq0uU8AKMOYpBSiXftnjrIYcDSSHN+R450hbaVG3zoT1HnWwEswmpzzOeZZgIhiJo+Ju9N3mGIWDPWove66SudQjGOSrvbuZce/QwY7eLgDzikZwZPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066615; c=relaxed/simple; bh=otjOsiDz4bTanHKzYuDkhYA9yxCY++MDYjkxVF0KTtc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bgL7WkE4nDpQzR/nJgHJszLtU6keKKJopq5PWADhHE47EseGmkK0q3rlOuTMw2OKrEZH0274XzgNhXxVupE0sTRhQd3N8ZlDMKBDFI58qPvCw/xGNtJPyqWudbfO+0/PkjObbrylNYy3RYG+KgfbzCrikKwKL3k6b1RnNx6fLrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=us3ioA/Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="us3ioA/Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1C38C4CECD; Fri, 4 Oct 2024 18:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728066614; bh=otjOsiDz4bTanHKzYuDkhYA9yxCY++MDYjkxVF0KTtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=us3ioA/ZODlJmzE1d27yXKqhFTWqprECohtwR0pNxKgHNuaU90WRzPq90bu6tX/YP i0it+MyYKQ/5x20EYbR0K8arQ/vwI91IeIDO4FV2xblfv25Uw9EAlq3WN4xC0Jz3Qc MOgxJVALYYyfhE/Rj2veOuVwch7pZgam0LOwK6d+J/L0X65xMlKQ1EmBtjOorshpg7 TTQq3k4rbDI9xVzYzbX4nUg6wa1fR7Chgclz8FhkGaWvqLRIxQOTiB0X2h+szu5n91 70MoEcwxqZid1FkO1WltY4iTG6/CW2OtiMMfax5wO2tqRXglUJ80qH9E9kOlQtzieA RtKid3MO3AS7g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gerald Schaefer , Heiko Carstens , Sasha Levin , agordeev@linux.ibm.com, gor@linux.ibm.com, linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 04/26] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Date: Fri, 4 Oct 2024 14:29:30 -0400 Message-ID: <20241004183005.3675332-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004183005.3675332-1-sashal@kernel.org> References: <20241004183005.3675332-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.226 Content-Transfer-Encoding: 8bit From: Gerald Schaefer [ Upstream commit 131b8db78558120f58c5dc745ea9655f6b854162 ] Adding/removing large amount of pages at once to/from the CMM balloon can result in rcu_sched stalls or workqueue lockups, because of busy looping w/o cond_resched(). Prevent this by adding a cond_resched(). cmm_free_pages() holds a spin_lock while looping, so it cannot be added directly to the existing loop. Instead, introduce a wrapper function that operates on maximum 256 pages at once, and add it there. Signed-off-by: Gerald Schaefer Reviewed-by: Heiko Carstens Signed-off-by: Heiko Carstens Signed-off-by: Sasha Levin --- arch/s390/mm/cmm.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index 1141c8d5c0d03..9b4304fa37bfc 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -95,11 +95,12 @@ static long cmm_alloc_pages(long nr, long *counter, (*counter)++; spin_unlock(&cmm_lock); nr--; + cond_resched(); } return nr; } -static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) +static long __cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) { struct cmm_page_array *pa; unsigned long addr; @@ -123,6 +124,21 @@ static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) return nr; } +static long cmm_free_pages(long nr, long *counter, struct cmm_page_array **list) +{ + long inc = 0; + + while (nr) { + inc = min(256L, nr); + nr -= inc; + inc = __cmm_free_pages(inc, counter, list); + if (inc) + break; + cond_resched(); + } + return nr + inc; +} + static int cmm_oom_notify(struct notifier_block *self, unsigned long dummy, void *parm) { -- 2.43.0