public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Yunke Cao <yunkec@chromium.org>, Tomasz Figa <tfiga@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Sasha Levin <sashal@kernel.org>,
	m.szyprowski@samsung.com, mchehab@kernel.org,
	linux-media@vger.kernel.org
Subject: [PATCH AUTOSEL 5.4 15/21] media: videobuf2-core: clear memory related fields in __vb2_plane_dmabuf_put()
Date: Fri,  4 Oct 2024 14:30:50 -0400	[thread overview]
Message-ID: <20241004183105.3675901-15-sashal@kernel.org> (raw)
In-Reply-To: <20241004183105.3675901-1-sashal@kernel.org>

From: Yunke Cao <yunkec@chromium.org>

[ Upstream commit 6a9c97ab6b7e85697e0b74e86062192a5ffffd99 ]

Clear vb2_plane's memory related fields in __vb2_plane_dmabuf_put(),
including bytesused, length, fd and data_offset.

Remove the duplicated code in __prepare_dmabuf().

Signed-off-by: Yunke Cao <yunkec@chromium.org>
Acked-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/media/common/videobuf2/videobuf2-core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
index 13602939906fc..98651c934d4e0 100644
--- a/drivers/media/common/videobuf2/videobuf2-core.c
+++ b/drivers/media/common/videobuf2/videobuf2-core.c
@@ -282,6 +282,10 @@ static void __vb2_plane_dmabuf_put(struct vb2_buffer *vb, struct vb2_plane *p)
 	p->mem_priv = NULL;
 	p->dbuf = NULL;
 	p->dbuf_mapped = 0;
+	p->bytesused = 0;
+	p->length = 0;
+	p->m.fd = 0;
+	p->data_offset = 0;
 }
 
 /*
@@ -1177,10 +1181,6 @@ static int __prepare_dmabuf(struct vb2_buffer *vb)
 
 		/* Release previously acquired memory if present */
 		__vb2_plane_dmabuf_put(vb, &vb->planes[plane]);
-		vb->planes[plane].bytesused = 0;
-		vb->planes[plane].length = 0;
-		vb->planes[plane].m.fd = 0;
-		vb->planes[plane].data_offset = 0;
 
 		/* Acquire each plane's memory */
 		mem_priv = call_ptr_memop(vb, attach_dmabuf,
-- 
2.43.0


  parent reply	other threads:[~2024-10-04 18:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 18:30 [PATCH AUTOSEL 5.4 01/21] bpf: Check percpu map value size first Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 02/21] s390/boot: Compile all files with the same march flag Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 03/21] s390/facility: Disable compile time optimization for decompressor code Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 04/21] s390/mm: Add cond_resched() to cmm_alloc/free_pages() Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 05/21] ext4: fix i_data_sem unlock order in ext4_ind_migrate() Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 06/21] ext4: ext4_search_dir should return a proper error Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 07/21] ext4: nested locking for xattr inode Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 08/21] s390/cpum_sf: Remove WARN_ON_ONCE statements Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 09/21] ktest.pl: Avoid false positives with grub2 skip regex Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 10/21] clk: bcm: bcm53573: fix OF node leak in init Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 11/21] PCI: Add ACS quirk for Qualcomm SA8775P Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 12/21] i2c: i801: Use a different adapter-name for IDF adapters Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 13/21] PCI: Mark Creative Labs EMU20k2 INTx masking as broken Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 14/21] ntb: ntb_hw_switchtec: Fix use after free vulnerability in switchtec_ntb_remove due to race condition Sasha Levin
2024-10-04 18:30 ` Sasha Levin [this message]
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 16/21] usb: chipidea: udc: enable suspend interrupt after usb reset Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 17/21] usb: dwc2: Adjust the timing of USB Driver Interrupt Registration in the Crashkernel Scenario Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 18/21] virtio_pmem: Check device status before requesting flush Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 19/21] tools/iio: Add memory allocation failure check for trigger_name Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 20/21] driver core: bus: Return -EIO instead of 0 when show/store invalid bus attribute Sasha Levin
2024-10-04 18:30 ` [PATCH AUTOSEL 5.4 21/21] fbdev: sisfb: Fix strbuf array overflow Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241004183105.3675901-15-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tfiga@chromium.org \
    --cc=yunkec@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox