From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1B21DF998; Fri, 4 Oct 2024 18:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066681; cv=none; b=k3KDJLlKoGeK897egR5qAGRdJHAzEkwUegoUlzkLPwfMW6FVI4aaI38/J4EoUDnQfNMXZBGeg4Gz0+ffhz9fVg8RI4BmvMOV4XUSp8EpsbiTDhz613lU2FFhlYgjXBDAgIchLtEVRsiXnX7KAAquAurFHk/AXssGTmwuhOHk4bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066681; c=relaxed/simple; bh=GvV8EjsUE3NmqWV0FhBsVmHWAgx3XoLYYo1Fs/CrTfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iHnXPNvzWkDVQhs+aM8yWIL3rwEpPAL2QXuZ3oJeT4LkXlGmhiC2+k0q0gcFGcgUW62eYSrMPOmwLz/5lGPHerQI6Mm78dvu9Gb8tN4h48bhsW+oj+MSWS+cTAosxIIJLAT/9n4vKs5tzVsR1iVx0P+0aqIrzdWO6xtlfg9dQoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=apgg51ci; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="apgg51ci" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0D69C4CEC6; Fri, 4 Oct 2024 18:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728066681; bh=GvV8EjsUE3NmqWV0FhBsVmHWAgx3XoLYYo1Fs/CrTfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=apgg51ciGaPAyj3aDdaaSXuIP2xZU9xyk3fLjTmzSC2NLewWPMdLgG+HQVyXmpK1m peuwVqjLLEOVaYlhB9GTpk+FaGalOpPPK86mg22CUrw0HFRFZ8JDctex8JJBGu5zlv fwyW84g1zB8itutLcQH43gcgojv3zObJBAo0BFKyP6t3lcVArF3tx188WYgMYzsuB2 8YdowsDuuTgwEKqXiSNB+1NC8yfEu8OLKrYnFrtQyvQDII1+cAm/e7OPJPUYHlkbD3 al+JYt4knVCe0nElLS3dPGUvkIsDaFBFzySd0aRxywJ+M+FGqEH4vCuNY6kBpM0V/G QNARdUY6/4BoA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Richter , Sumanth Korikkar , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sasha Levin , svens@linux.ibm.com, linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 08/21] s390/cpum_sf: Remove WARN_ON_ONCE statements Date: Fri, 4 Oct 2024 14:30:43 -0400 Message-ID: <20241004183105.3675901-8-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004183105.3675901-1-sashal@kernel.org> References: <20241004183105.3675901-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.284 Content-Transfer-Encoding: 8bit From: Thomas Richter [ Upstream commit b495e710157606889f2d8bdc62aebf2aa02f67a7 ] Remove WARN_ON_ONCE statements. These have not triggered in the past. Signed-off-by: Thomas Richter Acked-by: Sumanth Korikkar Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Signed-off-by: Vasily Gorbik Signed-off-by: Sasha Levin --- arch/s390/kernel/perf_cpum_sf.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c index b83bddf35e068..4f251cd624d7e 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -1412,7 +1412,7 @@ static int aux_output_begin(struct perf_output_handle *handle, unsigned long head, base, offset; struct hws_trailer_entry *te; - if (WARN_ON_ONCE(handle->head & ~PAGE_MASK)) + if (handle->head & ~PAGE_MASK) return -EINVAL; aux->head = handle->head >> PAGE_SHIFT; @@ -1580,7 +1580,7 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw) unsigned long num_sdb; aux = perf_get_aux(handle); - if (WARN_ON_ONCE(!aux)) + if (!aux) return; /* Inform user space new data arrived */ @@ -1599,7 +1599,7 @@ static void hw_collect_aux(struct cpu_hw_sf *cpuhw) debug_sprintf_event(sfdbg, 1, "AUX buffer used up\n"); break; } - if (WARN_ON_ONCE(!aux)) + if (!aux) return; /* Update head and alert_mark to new position */ @@ -1836,12 +1836,8 @@ static void cpumsf_pmu_start(struct perf_event *event, int flags) { struct cpu_hw_sf *cpuhw = this_cpu_ptr(&cpu_hw_sf); - if (WARN_ON_ONCE(!(event->hw.state & PERF_HES_STOPPED))) + if (!(event->hw.state & PERF_HES_STOPPED)) return; - - if (flags & PERF_EF_RELOAD) - WARN_ON_ONCE(!(event->hw.state & PERF_HES_UPTODATE)); - perf_pmu_disable(event->pmu); event->hw.state = 0; cpuhw->lsctl.cs = 1; -- 2.43.0