From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Sui Jingfeng <sui.jingfeng@linux.dev>
Subject: [PATCH 3/3] drm/etnaviv: Print an error message if inserting IOVA range fails
Date: Sat, 5 Oct 2024 03:42:07 +0800 [thread overview]
Message-ID: <20241004194207.1013744-4-sui.jingfeng@linux.dev> (raw)
In-Reply-To: <20241004194207.1013744-1-sui.jingfeng@linux.dev>
Print an error message to help debug when such an issue happen, since it's
not so obvious.
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
---
v0 -> v1: Use dev_err_ratelimited() to prevent spamming the logs
v0 is at https://lore.kernel.org/dri-devel/20240930221706.399139-1-sui.jingfeng@linux.dev/
---
drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index a52ec5eb0e3d..37866ed05c13 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -300,8 +300,12 @@ int etnaviv_iommu_map_gem(struct etnaviv_iommu_context *context,
ret = etnaviv_iommu_insert_exact(context, node, user_size, va);
else
ret = etnaviv_iommu_find_iova(context, node, user_size);
- if (ret < 0)
+ if (ret < 0) {
+ dev_err_ratelimited(context->global->dev,
+ "Insert iova failed: 0x%llx(0x%x)\n",
+ va, user_size);
goto unlock;
+ }
mapping->iova = node->start;
ret = etnaviv_iommu_map(context, node->start, user_size, sgt,
--
2.34.1
next prev parent reply other threads:[~2024-10-04 19:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 19:42 [PATCH 0/3] Fix GPU virtual address collosion when CPU page size != GPU page size Sui Jingfeng
2024-10-04 19:42 ` [PATCH 1/3] drm/etnaviv: Track GPU VA size separately Sui Jingfeng
2024-10-07 10:12 ` Lucas Stach
2024-10-25 17:42 ` Sui Jingfeng
2024-10-27 4:48 ` Sui Jingfeng
2024-10-04 19:42 ` [PATCH 2/3] drm/etnaviv: Map and unmap the GPU VA range with respect to its user size Sui Jingfeng
2024-10-07 10:17 ` Lucas Stach
2024-10-25 17:19 ` Sui Jingfeng
2024-10-26 5:55 ` Sui Jingfeng
2024-10-04 19:42 ` Sui Jingfeng [this message]
2024-10-07 10:20 ` [PATCH 3/3] drm/etnaviv: Print an error message if inserting IOVA range fails Lucas Stach
2024-10-28 16:01 ` Lucas Stach
2024-10-28 16:25 ` Sui Jingfeng
2024-10-25 8:06 ` [PATCH 0/3] Fix GPU virtual address collosion when CPU page size != GPU page size Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004194207.1013744-4-sui.jingfeng@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=airlied@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox