From: Menglong Dong <menglong8.dong@gmail.com>
To: idosch@nvidia.com, kuba@kernel.org, aleksander.lobakin@intel.com,
horms@kernel.org
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, dongml2@chinatelecom.cn, amcohen@nvidia.com,
gnault@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com,
razor@blackwall.org, petrm@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next v5 00/12] net: vxlan: add skb drop reasons support
Date: Sun, 6 Oct 2024 14:56:04 +0800 [thread overview]
Message-ID: <20241006065616.2563243-1-dongml2@chinatelecom.cn> (raw)
In this series, we add skb drop reasons support to VXLAN, and following
new skb drop reasons are introduced:
SKB_DROP_REASON_VXLAN_INVALID_HDR
SKB_DROP_REASON_VXLAN_VNI_NOT_FOUND
SKB_DROP_REASON_VXLAN_ENTRY_EXISTS
SKB_DROP_REASON_VXLAN_NO_REMOTE
SKB_DROP_REASON_MAC_INVALID_SOURCE
SKB_DROP_REASON_IP_TUNNEL_ECN
SKB_DROP_REASON_TUNNEL_TXINFO
SKB_DROP_REASON_LOCAL_MAC
We add some helper functions in this series, who will capture the drop
reasons from pskb_may_pull_reason and return them:
pskb_network_may_pull_reason()
pskb_inet_may_pull_reason()
And we also make the following functions return skb drop reasons:
skb_vlan_inet_prepare()
vxlan_remcsum()
vxlan_snoop()
vxlan_set_mac()
Changes since v4:
- make skb_vlan_inet_prepare() return drop reasons, instead of introduce
a wrapper for it in the 3rd patch.
- modify the document for SKB_DROP_REASON_LOCAL_MAC and
SKB_DROP_REASON_TUNNEL_TXINFO.
Changes since v3:
- rename SKB_DROP_REASON_VXLAN_INVALID_SMAC to
SKB_DROP_REASON_MAC_INVALID_SOURCE in the 6th patch
Changes since v2:
- move all the drop reasons of VXLAN to the "core", instead of introducing
the VXLAN drop reason subsystem
- add the 6th patch, which capture the drop reasons from vxlan_snoop()
- move the commits for vxlan_remcsum() and vxlan_set_mac() after
vxlan_rcv() to update the call of them accordingly
- fix some format problems
Changes since v1:
- document all the drop reasons that we introduce
- rename the drop reasons to make them more descriptive, as Ido advised
- remove the 2nd patch, which introduce the SKB_DR_RESET
- add the 4th patch, which adds skb_vlan_inet_prepare_reason() helper
- introduce the 6th patch, which make vxlan_set_mac return drop reasons
- introduce the 10th patch, which uses VXLAN_DROP_NO_REMOTE as the drop
reasons, as Ido advised
Menglong Dong (12):
net: skb: add pskb_network_may_pull_reason() helper
net: tunnel: add pskb_inet_may_pull_reason() helper
net: tunnel: make skb_vlan_inet_prepare() return drop reasons
net: vxlan: add skb drop reasons to vxlan_rcv()
net: vxlan: make vxlan_remcsum() return drop reasons
net: vxlan: make vxlan_snoop() return drop reasons
net: vxlan: make vxlan_set_mac() return drop reasons
net: vxlan: use kfree_skb_reason() in vxlan_xmit()
net: vxlan: add drop reasons support to vxlan_xmit_one()
net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit()
net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass()
net: vxlan: use kfree_skb_reason() in encap_bypass_if_local()
drivers/net/bareudp.c | 4 +-
drivers/net/geneve.c | 4 +-
drivers/net/vxlan/vxlan_core.c | 111 +++++++++++++++++++++------------
drivers/net/vxlan/vxlan_mdb.c | 2 +-
include/linux/skbuff.h | 8 ++-
include/net/dropreason-core.h | 39 ++++++++++++
include/net/ip_tunnels.h | 23 ++++---
7 files changed, 138 insertions(+), 53 deletions(-)
--
2.39.5
next reply other threads:[~2024-10-06 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 6:56 Menglong Dong [this message]
2024-10-06 6:56 ` [PATCH net-next v5 01/12] net: skb: add pskb_network_may_pull_reason() helper Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 03/12] net: tunnel: make skb_vlan_inet_prepare() return drop reasons Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 04/12] net: vxlan: add skb drop reasons to vxlan_rcv() Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 05/12] net: vxlan: make vxlan_remcsum() return drop reasons Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 06/12] net: vxlan: make vxlan_snoop() " Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 07/12] net: vxlan: make vxlan_set_mac() " Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() Menglong Dong
2024-10-06 8:53 ` Guillaume Nault
2024-10-07 2:00 ` Menglong Dong
2024-10-08 12:28 ` Simon Horman
2024-10-08 14:06 ` Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 10/12] net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit() Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 11/12] net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass() Menglong Dong
2024-10-06 6:56 ` [PATCH net-next v5 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241006065616.2563243-1-dongml2@chinatelecom.cn \
--to=menglong8.dong@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox