Re: [PATCH v3 09/10] iio: adc: ad7606: Add iio-backend support

Jonathan Cameron
2024-10-10T18:04:15Z

> >> diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
> >> index 3666a58f8a6f..d86eb7c3e4f7 100644
> >> --- a/drivers/iio/adc/ad7606.c
> >> +++ b/drivers/iio/adc/ad7606.c
> >> @@ -21,6 +21,7 @@
> >> @@ -737,6 +773,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
> >> return ret;
> >>
> >> return 0;
> >> + case IIO_CHAN_INFO_SAMP_FREQ:
> >> + if (val < 0 && val2 != 0)
> >> + return -EINVAL;
> >> + return ad7606_set_sampling_freq(st, val);
> > Currently I think for the !backend + pwm case this can go out of
> > range for which that code works (fsleep removed in next patch).
> > Perhaps delay adding this until after that patch.
>
> Hi Jonathan,
>
> The sampling frequency can be adjusted only for the backend version,
> otherwise (including pwm+interrupt), there is no sysfs access to the
> sampling frequency (only available for AD7606_BI_CHANNEL).
Ah! That makes sense.
Thanks,

J