From: Oleg Nesterov <oleg@redhat.com>
To: luca.boccassi@gmail.com
Cc: linux-kernel@vger.kernel.org, christian@brauner.io
Subject: Re: [PATCH v5] pidfd: add ioctl to retrieve pid info
Date: Sun, 6 Oct 2024 19:38:13 +0200 [thread overview]
Message-ID: <20241006173812.GB10213@redhat.com> (raw)
In-Reply-To: <20241006145727.291401-1-luca.boccassi@gmail.com>
On 10/06, luca.boccassi@gmail.com wrote:
>
> +#ifdef CONFIG_CGROUPS
> + if (request_mask & PIDFD_INFO_CGROUPID) {
Should we nack other bits in request_mask?
> + struct cgroup *cgrp = task_css_check(task, pids_cgrp_id, 1)->cgroup;
Well, the last "1" argument just fools CONFIG_PROVE_RCU, right?
It seems you need rcu_read_lock() + task_cgroup(pids_cgrp_id)...
Oleg.
prev parent reply other threads:[~2024-10-06 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 14:54 [PATCH v5] pidfd: add ioctl to retrieve pid info luca.boccassi
2024-10-06 17:21 ` Oleg Nesterov
2024-10-06 17:52 ` Luca Boccassi
2024-10-06 18:55 ` Oleg Nesterov
2024-10-06 21:33 ` Luca Boccassi
2024-10-07 12:11 ` Christian Brauner
2024-10-06 17:38 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241006173812.GB10213@redhat.com \
--to=oleg@redhat.com \
--cc=christian@brauner.io \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox