From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org, jacob.e.keller@intel.com,
horms@kernel.org, sd@queasysnail.net, chunkeey@gmail.com
Subject: Re: [PATCH net-next v3 17/17] net: ibm: emac: mal: move dcr map down
Date: Mon, 7 Oct 2024 07:05:14 -0700 [thread overview]
Message-ID: <20241007070514.4439425d@kernel.org> (raw)
In-Reply-To: <CAKxU2N-F+Gcv_LVvH5uB+x5gGABwzFsvxZOg+ApQ-DAHaFz3iw@mail.gmail.com>
On Fri, 4 Oct 2024 16:43:48 -0700 Rosen Penev wrote:
> > On Wed, 2 Oct 2024 19:11:35 -0700 Rosen Penev wrote:
> > > There's actually a bug above where it returns instead of calling goto.
> > > Instead of calling goto, move dcr_map and friends down as they're used
> > > right after the spinlock in mal_reset.
> >
> > Not a fix?
> It's a fix for a prior commit, yes. 6d3ba097ee81d if I'm using git
> blame correctly.
Hm, I don't have this hash in my local tree.
What I'm getting at is that if it's a fix for a patch already in
networking trees the patch needs to have a Fixes tag. And if the
bug is present in net - the patch needs to go to net rather than
net-next.
next prev parent reply other threads:[~2024-10-07 14:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 2:11 [PATCH net-next v3 00/17] ibm: emac: more cleanups Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 01/17] net: ibm: emac: use netif_receive_skb_list Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 02/17] net: ibm: emac: remove custom init/exit functions Rosen Penev
2024-10-04 23:31 ` Jakub Kicinski
2024-10-03 2:11 ` [PATCH net-next v3 03/17] net: ibm: emac: use module_platform_driver for modules Rosen Penev
2024-10-04 23:32 ` Jakub Kicinski
2024-10-05 0:10 ` Rosen Penev
2024-10-06 11:53 ` kernel test robot
2024-10-06 19:13 ` kernel test robot
2024-10-03 2:11 ` [PATCH net-next v3 04/17] net: ibm: emac: use devm_platform_ioremap_resource Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 05/17] net: ibm: emac: use platform_get_irq Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 06/17] net: ibm: emac: remove bootlist support Rosen Penev
2024-10-04 23:34 ` Jakub Kicinski
2024-10-05 0:13 ` Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 07/17] net: ibm: emac: tah: use devm for kzalloc Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 08/17] net: ibm: emac: tah: devm_platform_get_resources Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 09/17] net: ibm: emac: rgmii: use devm for kzalloc Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 10/17] net: ibm: emac: rgmii: devm_platform_get_resource Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 11/17] net: ibm: emac: zmii: use devm for kzalloc Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 12/17] net: ibm: emac: zmii: devm_platform_get_resource Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 13/17] net: ibm: emac: mal: use devm for kzalloc Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 14/17] net: ibm: emac: mal: use devm for request_irq Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 15/17] net: ibm: emac: mal: move irq maps down Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 16/17] net: ibm: emac: mal: add dcr_unmap to _remove Rosen Penev
2024-10-04 23:35 ` Jakub Kicinski
2024-10-04 23:49 ` Rosen Penev
2024-10-03 2:11 ` [PATCH net-next v3 17/17] net: ibm: emac: mal: move dcr map down Rosen Penev
2024-10-04 23:36 ` Jakub Kicinski
2024-10-04 23:43 ` Rosen Penev
2024-10-07 14:05 ` Jakub Kicinski [this message]
2024-10-07 15:28 ` Jakub Kicinski
2024-10-04 23:32 ` [PATCH net-next v3 00/17] ibm: emac: more cleanups Jakub Kicinski
2024-10-04 23:38 ` Rosen Penev
2024-10-04 23:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007070514.4439425d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox