* [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree()
@ 2024-10-07 11:51 Thorsten Blum
2024-10-11 3:11 ` Zack Rusin
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-10-07 11:51 UTC (permalink / raw)
To: Zack Rusin, Broadcom internal kernel review list,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: Thorsten Blum, dri-devel, linux-kernel
Since kvfree() already checks if its argument is NULL, an additional
check before calling kvfree() is unnecessary and can be removed.
Remove both and the following Coccinelle/coccicheck warnings reported by
ifnullfree.cocci:
WARNING: NULL check before some freeing functions is not needed
WARNING: NULL check before some freeing functions is not needed
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
index 890a66a2361f..64bd7d74854e 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
@@ -635,10 +635,8 @@ int vmw_bo_cpu_blit(struct vmw_bo *vmw_dst,
kunmap_atomic(d.src_addr);
if (d.dst_addr)
kunmap_atomic(d.dst_addr);
- if (src_pages)
- kvfree(src_pages);
- if (dst_pages)
- kvfree(dst_pages);
+ kvfree(src_pages);
+ kvfree(dst_pages);
return ret;
}
--
2.46.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree()
2024-10-07 11:51 [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree() Thorsten Blum
@ 2024-10-11 3:11 ` Zack Rusin
0 siblings, 0 replies; 2+ messages in thread
From: Zack Rusin @ 2024-10-11 3:11 UTC (permalink / raw)
To: Thorsten Blum
Cc: Broadcom internal kernel review list, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, linux-kernel
On Mon, Oct 7, 2024 at 7:52 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Since kvfree() already checks if its argument is NULL, an additional
> check before calling kvfree() is unnecessary and can be removed.
>
> Remove both and the following Coccinelle/coccicheck warnings reported by
> ifnullfree.cocci:
>
> WARNING: NULL check before some freeing functions is not needed
> WARNING: NULL check before some freeing functions is not needed
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> index 890a66a2361f..64bd7d74854e 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> @@ -635,10 +635,8 @@ int vmw_bo_cpu_blit(struct vmw_bo *vmw_dst,
> kunmap_atomic(d.src_addr);
> if (d.dst_addr)
> kunmap_atomic(d.dst_addr);
> - if (src_pages)
> - kvfree(src_pages);
> - if (dst_pages)
> - kvfree(dst_pages);
> + kvfree(src_pages);
> + kvfree(dst_pages);
>
> return ret;
> }
> --
> 2.46.2
>
Thank you. Looks good. I went ahead and pushed it to drm-misc-fixes.
z
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-11 3:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 11:51 [RESEND PATCH] drm/vmwgfx: Remove unnecessary NULL checks before kvfree() Thorsten Blum
2024-10-11 3:11 ` Zack Rusin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox