public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: <linus.walleij@linaro.org>, <brgl@bgdev.pl>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <joel@jms.id.au>,
	<andrew@codeconstruct.com.au>, <linux-gpio@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<BMC-SW@aspeedtech.com>, <Peter.Yin@quantatw.com>,
	<Jay_Zhang@wiwynn.com>
Subject: [PATCH v7 1/7] gpio: aspeed: Add the flush write to ensure the write complete.
Date: Tue, 8 Oct 2024 16:14:44 +0800	[thread overview]
Message-ID: <20241008081450.1490955-2-billy_tsai@aspeedtech.com> (raw)
In-Reply-To: <20241008081450.1490955-1-billy_tsai@aspeedtech.com>

Performing a dummy read ensures that the register write operation is fully
completed, mitigating any potential bus delays that could otherwise impact
the frequency of bitbang usage. E.g., if the JTAG application uses GPIO to
control the JTAG pins (TCK, TMS, TDI, TDO, and TRST), and the application
sets the TCK clock to 1 MHz, the GPIO's high/low transitions will rely on
a delay function to ensure the clock frequency does not exceed 1 MHz.
However, this can lead to rapid toggling of the GPIO because the write
operation is POSTed and does not wait for a bus acknowledgment.

Fixes: 361b79119a4b ("gpio: Add Aspeed driver")
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 drivers/gpio/gpio-aspeed.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 04c03402db6d..98551b7f6de2 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -406,6 +406,8 @@ static void __aspeed_gpio_set(struct gpio_chip *gc, unsigned int offset,
 	gpio->dcache[GPIO_BANK(offset)] = reg;
 
 	iowrite32(reg, addr);
+	/* Flush write */
+	ioread32(addr);
 }
 
 static void aspeed_gpio_set(struct gpio_chip *gc, unsigned int offset,
-- 
2.25.1


  reply	other threads:[~2024-10-08  8:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  8:14 [PATCH v7 0/7] Add Aspeed G7 gpio support Billy Tsai
2024-10-08  8:14 ` Billy Tsai [this message]
2024-10-08  8:14 ` [PATCH v7 2/7] gpio: aspeed: Use devm_clk api to manage clock source Billy Tsai
2024-10-08  8:14 ` [PATCH v7 3/7] gpio: aspeed: Change the macro to support deferred probe Billy Tsai
2024-10-08  8:14 ` [PATCH v7 4/7] gpio: aspeed: Remove the name for bank array Billy Tsai
2024-10-08  8:14 ` [PATCH v7 5/7] gpio: aspeed: Create llops to handle hardware access Billy Tsai
2024-10-09  1:57   ` Andrew Jeffery
2024-10-08  8:14 ` [PATCH v7 6/7] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-10-08  8:14 ` [PATCH v7 7/7] gpio: aspeed: Support G7 Aspeed gpio controller Billy Tsai
2024-10-09  2:12   ` Andrew Jeffery
2024-10-09  2:28     ` Billy Tsai
2024-10-09  6:47       ` Andrew Jeffery
2024-10-08 14:02 ` (subset) [PATCH v7 0/7] Add Aspeed G7 gpio support Bartosz Golaszewski
2024-10-08 14:04 ` Bartosz Golaszewski
2024-10-14  7:04 ` (subset) " Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241008081450.1490955-2-billy_tsai@aspeedtech.com \
    --to=billy_tsai@aspeedtech.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=Jay_Zhang@wiwynn.com \
    --cc=Peter.Yin@quantatw.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox