From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Oleksandr Ocheretnyi <oocheret@cisco.com>
Cc: linux@roeck-us.net, jdelvare@suse.de,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
wim@linux-watchdog.org, wsa@kernel.org,
xe-linux-external@cisco.com
Subject: Re: [PATCH v3] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call
Date: Tue, 8 Oct 2024 19:33:12 +0300 [thread overview]
Message-ID: <20241008163312.GS275077@black.fi.intel.com> (raw)
In-Reply-To: <20241007155702.3676667-1-oocheret@cisco.com>
On Mon, Oct 07, 2024 at 08:57:02AM -0700, Oleksandr Ocheretnyi wrote:
> Hello Mika,
>
> > I suggest adding some #define for the magical number 8 so that it is
> > easier for anyone looking at this driver to figure out what it is doing.
>
> Are the changes with #define NMI_NOW bit fine for you?
Sure,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2024-10-08 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 7:53 [PATCH v1] iTCO_wdt: ignore NMI_NOW bit on register comparison Oleksandr Ocheretnyi
2024-08-26 11:18 ` Mika Westerberg
2024-08-26 15:12 ` Guenter Roeck
2024-08-26 15:15 ` Guenter Roeck
2024-08-26 15:41 ` Guenter Roeck
2024-09-12 14:19 ` [PATCH v2] iTCO_wdt: mask NMI_NOW bit for update_no_reboot_bit() call Oleksandr Ocheretnyi
2024-09-12 21:15 ` Guenter Roeck
2024-09-12 21:15 ` Guenter Roeck
2024-09-13 19:14 ` [PATCH v3] " Oleksandr Ocheretnyi
2024-09-17 1:09 ` Guenter Roeck
2024-10-07 15:57 ` Oleksandr Ocheretnyi
2024-10-08 16:33 ` Mika Westerberg [this message]
2024-09-13 5:29 ` [PATCH v2] " kernel test robot
2024-09-13 7:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008163312.GS275077@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oocheret@cisco.com \
--cc=wim@linux-watchdog.org \
--cc=wsa@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox