From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@infradead.org>
Cc: Allison Karlitskaya <allison.karlitskaya@redhat.com>,
Chao Yu <chao@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
Gao Xiang <hsiangkao@linux.alibaba.com>
Subject: [PATCH v2 2/2] erofs: use get_tree_bdev_flags() to avoid misleading messages
Date: Wed, 9 Oct 2024 11:31:51 +0800 [thread overview]
Message-ID: <20241009033151.2334888-2-hsiangkao@linux.alibaba.com> (raw)
In-Reply-To: <20241009033151.2334888-1-hsiangkao@linux.alibaba.com>
Users can pass in an arbitrary source path for the proper type of
a mount then without "Can't lookup blockdev" error message.
Reported-by: Allison Karlitskaya <allison.karlitskaya@redhat.com>
Closes: https://lore.kernel.org/r/CAOYeF9VQ8jKVmpy5Zy9DNhO6xmWSKMB-DO8yvBB0XvBE7=3Ugg@mail.gmail.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
changes since v1:
- use new get_tree_bdev_flags().
fs/erofs/super.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 666873f745da..b89836a8760d 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -705,7 +705,9 @@ static int erofs_fc_get_tree(struct fs_context *fc)
if (IS_ENABLED(CONFIG_EROFS_FS_ONDEMAND) && sbi->fsid)
return get_tree_nodev(fc, erofs_fc_fill_super);
- ret = get_tree_bdev(fc, erofs_fc_fill_super);
+ ret = get_tree_bdev_flags(fc, erofs_fc_fill_super,
+ IS_ENABLED(CONFIG_EROFS_FS_BACKED_BY_FILE) ?
+ GET_TREE_BDEV_QUIET_LOOKUP : 0);
#ifdef CONFIG_EROFS_FS_BACKED_BY_FILE
if (ret == -ENOTBLK) {
if (!fc->source)
--
2.43.5
next prev parent reply other threads:[~2024-10-09 3:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 3:31 [PATCH v2 1/2] fs/super.c: introduce get_tree_bdev_flags() Gao Xiang
2024-10-09 3:31 ` Gao Xiang [this message]
2024-10-09 7:31 ` [PATCH v2 2/2] erofs: use get_tree_bdev_flags() to avoid misleading messages Christoph Hellwig
2024-10-09 7:37 ` Gao Xiang
2024-10-09 16:57 ` Gao Xiang
2024-10-09 7:30 ` [PATCH v2 1/2] fs/super.c: introduce get_tree_bdev_flags() Christoph Hellwig
2024-10-09 15:04 ` Jan Kara
2024-10-10 9:48 ` Christian Brauner
2024-10-21 7:54 ` Gao Xiang
2024-10-21 12:27 ` Christian Brauner
2024-10-21 12:34 ` Gao Xiang
2024-10-21 12:32 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009033151.2334888-2-hsiangkao@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=allison.karlitskaya@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox