From: Guan-Yu Lin <guanyulin@google.com>
To: Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, stern@rowland.harvard.edu,
elder@kernel.org, oneukum@suse.com, yajun.deng@linux.dev,
dianders@chromium.org, kekrby@gmail.com, perex@perex.cz,
tiwai@suse.com, tj@kernel.org, stanley_chang@realtek.com,
andreyknvl@gmail.com, christophe.jaillet@wanadoo.fr,
quic_jjohnson@quicinc.com, ricardo@marliere.net,
grundler@chromium.org, niko.mauno@vaisala.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, badhri@google.com,
albertccwang@google.com, quic_wcheng@quicinc.com,
pumahsu@google.com, Guan-Yu Lin <guanyulin@google.com>
Subject: [PATCH v4 3/5] usb: add apis for sideband uasge tracking
Date: Wed, 9 Oct 2024 05:42:57 +0000 [thread overview]
Message-ID: <20241009054429.3970438-4-guanyulin@google.com> (raw)
In-Reply-To: <20241009054429.3970438-1-guanyulin@google.com>
Introduce sb_usage_count and corresponding apis to track sideband usage
on each usb_device. A sideband refers to the co-processor that accesses
the usb_device via shared control on the same USB host controller. To
optimize power usage, it's essential to monitor whether ther sideband is
actively using the usb_device. This information is vital when
determining if a usb_device can be safely suspended during system power
state transitions.
Signed-off-by: Guan-Yu Lin <guanyulin@google.com>
---
drivers/usb/core/driver.c | 54 +++++++++++++++++++++++++++++++++++++++
include/linux/usb.h | 13 ++++++++++
2 files changed, 67 insertions(+)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
index 0c3f12daac79..c1ba5ed15214 100644
--- a/drivers/usb/core/driver.c
+++ b/drivers/usb/core/driver.c
@@ -1673,6 +1673,60 @@ void usb_disable_autosuspend(struct usb_device *udev)
}
EXPORT_SYMBOL_GPL(usb_disable_autosuspend);
+/**
+ * usb_sideband_get - notify usb driver there's a new active sideband
+ * @udev: the usb_device which has an active sideband
+ *
+ * An active sideband indicates that another entity is currently using the usb
+ * device. Notify the usb device by increasing the sb_usage_count. This allows
+ * usb driver to adjust power management policy based on sideband activities.
+ */
+void usb_sideband_get(struct usb_device *udev)
+{
+ struct usb_device *parent = udev;
+
+ do {
+ atomic_inc(&parent->sb_usage_count);
+ parent = parent->parent;
+ } while (parent);
+}
+EXPORT_SYMBOL_GPL(usb_sideband_get);
+
+/**
+ * usb_sideband_put - notify usb driver there's a sideband deactivated
+ * @udev: the usb_device which has a sideband deactivated
+ *
+ * The inverse operation of usb_sideband_get, which notifies the usb device by
+ * decreasing the sb_usage_count. This allows usb driver to adjust power
+ * management policy based on sideband activities.
+ */
+void usb_sideband_put(struct usb_device *udev)
+{
+ struct usb_device *parent = udev;
+
+ do {
+ atomic_dec(&parent->sb_usage_count);
+ parent = parent->parent;
+ } while (parent);
+}
+EXPORT_SYMBOL_GPL(usb_sideband_put);
+
+/**
+ * usb_sideband_check - check sideband activities on the host controller
+ * @udev: the usb_device which has a sideband deactivated
+ *
+ * Check if there are any sideband activity on the USB device right now. This
+ * information could be used for power management or other forms or resource
+ * management.
+ *
+ * Returns true on any active sideband existence, false otherwise
+ */
+bool usb_sideband_check(struct usb_device *udev)
+{
+ return !!atomic_read(&udev->sb_usage_count);
+}
+EXPORT_SYMBOL_GPL(usb_sideband_check);
+
/**
* usb_autosuspend_device - delayed autosuspend of a USB device and its interfaces
* @udev: the usb_device to autosuspend
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 672d8fc2abdb..5b9fea378960 100644
--- a/include/linux/usb.h
+++ b/include/linux/usb.h
@@ -645,6 +645,7 @@ struct usb3_lpm_parameters {
* parent->hub_delay + wHubDelay + tTPTransmissionDelay (40ns)
* Will be used as wValue for SetIsochDelay requests.
* @use_generic_driver: ask driver core to reprobe using the generic driver.
+ * @sb_usage_count: number of active sideband accessing this usb device.
*
* Notes:
* Usbcore drivers should not set usbdev->state directly. Instead use
@@ -731,6 +732,8 @@ struct usb_device {
u16 hub_delay;
unsigned use_generic_driver:1;
+
+ atomic_t sb_usage_count;
};
#define to_usb_device(__dev) container_of_const(__dev, struct usb_device, dev)
@@ -798,6 +801,9 @@ static inline int usb_acpi_port_lpm_incapable(struct usb_device *hdev, int index
#ifdef CONFIG_PM
extern void usb_enable_autosuspend(struct usb_device *udev);
extern void usb_disable_autosuspend(struct usb_device *udev);
+extern void usb_sideband_get(struct usb_device *udev);
+extern void usb_sideband_put(struct usb_device *udev);
+extern bool usb_sideband_check(struct usb_device *udev);
extern int usb_autopm_get_interface(struct usb_interface *intf);
extern void usb_autopm_put_interface(struct usb_interface *intf);
@@ -818,6 +824,13 @@ static inline int usb_enable_autosuspend(struct usb_device *udev)
static inline int usb_disable_autosuspend(struct usb_device *udev)
{ return 0; }
+static inline int usb_sideband_get(struct usb_device *udev)
+{ return 0; }
+static inline int usb_sideband_put(struct usb_device *udev)
+{ return 0; }
+static inline bool usb_sideband_check(struct usb_device *udev)
+{ return false; }
+
static inline int usb_autopm_get_interface(struct usb_interface *intf)
{ return 0; }
static inline int usb_autopm_get_interface_async(struct usb_interface *intf)
--
2.47.0.rc0.187.ge670bccf7e-goog
next prev parent reply other threads:[~2024-10-09 5:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 5:42 [PATCH v4 0/5] Support system sleep with offloaded usb transfers Guan-Yu Lin
2024-10-09 5:42 ` [PATCH v4 1/5] usb: dwc3: separate dev_pm_ops for each pm_event Guan-Yu Lin
2024-10-09 12:45 ` Greg KH
2024-10-10 4:12 ` Guan-Yu Lin
2024-10-09 5:42 ` [PATCH v4 2/5] usb: xhci-plat: " Guan-Yu Lin
2024-10-09 5:42 ` Guan-Yu Lin [this message]
2024-10-09 7:33 ` [PATCH v4 3/5] usb: add apis for sideband uasge tracking Amadeusz Sławiński
2024-10-09 11:36 ` Guan-Yu Lin
2024-10-09 12:44 ` Greg KH
2024-10-10 5:30 ` Guan-Yu Lin
2024-10-10 6:33 ` Greg KH
2024-10-10 16:14 ` Guan-Yu Lin
2024-10-11 4:30 ` Greg KH
2024-10-11 7:33 ` Guan-Yu Lin
2024-10-09 5:42 ` [PATCH v4 4/5] xhci: sideband: add api to trace sideband usage Guan-Yu Lin
2024-10-09 12:47 ` Greg KH
2024-10-10 4:16 ` Guan-Yu Lin
2024-10-09 5:42 ` [PATCH v4 5/5] usb: host: enable sideband transfer during system sleep Guan-Yu Lin
2024-10-09 12:47 ` Greg KH
2024-10-11 7:34 ` Guan-Yu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009054429.3970438-4-guanyulin@google.com \
--to=guanyulin@google.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=albertccwang@google.com \
--cc=andreyknvl@gmail.com \
--cc=badhri@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dianders@chromium.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@chromium.org \
--cc=kekrby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=niko.mauno@vaisala.com \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=pumahsu@google.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=ricardo@marliere.net \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox